-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Capsule Modal #2150
Update Capsule Modal #2150
Conversation
@vr2amesh I was able to connect a capsule wallet to the demo, but not complete any of the checklist functions listed: can you take a look? |
Will take a look now |
@leightkt Hi there, I just tested it now, and I was able to do all of those checklist functions. What are you seeing on your end? |
@vr2amesh I connect my wallet and can switch chains- but when I click sign transaction or send transaction- nothing happnes |
@leightkt What do you see in the console? The stuff that comes up there is consistent with the output we get from other wallets as well. I don't think the signTransaction is supported in the demo app. I confirmed that the behavior of Capsule wallet is consistent with those other ones/ |
@vr2amesh ok so I see a console log of the signed message- I was expecting some sort of UI with Capsule. |
@leightkt Ah! I understand now. There isn't a UI for these functions. We're meant to be an embedded wallet with minimal UI, so this is expected behavior |
@vr2amesh got ya- thank you for confirming and sorry for the confusion! overall- this PR is looking good. Can you please remove the capsule/yarn.lock file, the update to PORT in package.json and merge in the most recent web3onboard develop branch? I can then get this approved/merged. |
@leightkt Absolutely will do! Thank you so much |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
988dfce
to
efdecab
Compare
Description
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)