Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Capsule Modal #2150

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

vr2amesh
Copy link
Contributor

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

package.json Outdated Show resolved Hide resolved
@leightkt
Copy link
Contributor

leightkt commented Apr 18, 2024

@vr2amesh I was able to connect a capsule wallet to the demo, but not complete any of the checklist functions listed:
send transaction
switch chains
sign message
sign typed message

can you take a look?

@vr2amesh
Copy link
Contributor Author

@vr2amesh I was able to connect a capsule wallet to the demo, but not complete any of the checklist functions listed: send transaction switch chains sign message sign typed message

can you take a look?

Will take a look now

@vr2amesh
Copy link
Contributor Author

@leightkt Hi there, I just tested it now, and I was able to do all of those checklist functions. What are you seeing on your end?

@leightkt
Copy link
Contributor

@vr2amesh I connect my wallet and can switch chains- but when I click sign transaction or send transaction- nothing happnes

@vr2amesh
Copy link
Contributor Author

@leightkt What do you see in the console? The stuff that comes up there is consistent with the output we get from other wallets as well. I don't think the signTransaction is supported in the demo app. I confirmed that the behavior of Capsule wallet is consistent with those other ones/

@leightkt
Copy link
Contributor

@vr2amesh ok so I see a console log of the signed message- I was expecting some sort of UI with Capsule.
I was also able to confirm sending a transaction- again, is there no UI for these functions? (just want to make sure I'm understanding correctly).

@vr2amesh
Copy link
Contributor Author

@leightkt Ah! I understand now. There isn't a UI for these functions. We're meant to be an embedded wallet with minimal UI, so this is expected behavior

@leightkt
Copy link
Contributor

@vr2amesh got ya- thank you for confirming and sorry for the confusion! overall- this PR is looking good. Can you please remove the capsule/yarn.lock file, the update to PORT in package.json and merge in the most recent web3onboard develop branch? I can then get this approved/merged.

@vr2amesh
Copy link
Contributor Author

@leightkt Absolutely will do! Thank you so much

Copy link

socket-security bot commented Apr 18, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@vr2amesh vr2amesh force-pushed the vinay-update-modal branch from 988dfce to efdecab Compare April 18, 2024 19:29
package.json Show resolved Hide resolved
@leightkt leightkt merged commit 6b2b964 into blocknative:develop Apr 18, 2024
3 checks passed
@jlm0 jlm0 deleted the vinay-update-modal branch October 21, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants