Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating StableWallet into InjectedWallet #2116

Merged
merged 12 commits into from
Apr 12, 2024
Merged

Integrating StableWallet into InjectedWallet #2116

merged 12 commits into from
Apr 12, 2024

Conversation

mytangying
Copy link
Contributor

@mytangying mytangying commented Mar 26, 2024 •
edited
Loading

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@socket-security Socket Security
Copy link

socket-security bot commented Mar 26, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/next@12.2.5
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
Install scripts npm/core-js-pure@3.24.1
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
Protestware/Troll package npm/es5-ext@0.10.62
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
Install scripts npm/es5-ext@0.10.62
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0
Install scripts npm/esbuild@0.18.20
Install scripts npm/svelte-preprocess@5.0.1
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Install scripts npm/@sveltejs/kit@1.0.0-next.589
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/esbuild@0.20.2

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/next@12.2.5
  • @SocketSecurity ignore npm/core-js-pure@3.24.1
  • @SocketSecurity ignore npm/es5-ext@0.10.62
  • @SocketSecurity ignore npm/esbuild@0.18.20
  • @SocketSecurity ignore npm/svelte-preprocess@5.0.1
  • @SocketSecurity ignore npm/@sveltejs/kit@1.0.0-next.589
  • @SocketSecurity ignore npm/esbuild@0.20.2

@Adamj1232
Copy link
Member

@mytangying since StableWallet is a browser injected wallet we dont support creating a new module just to add support.
Web3-Onboard injected module now support 6963 wallets which means if your wallet is EIP 6963 compatible(highly recommended) the injected module will pick it up automatically without requiring web3-onboard integration.

@mytangying mytangying changed the title feature: Integrating StableWallet into onboard Integrating StableWallet into InjectedWallet Mar 28, 2024
@Adamj1232
Copy link
Member

@mytangying the PR is looking good. Can you please bump the alpha version within the injected/package.json at the top of the file?
Can you please also verify the checks in the description of this PR and confirm all testing has been done using the internal demo (yarn && yarn dev)?

Adamj1232
Adamj1232 reviewed Apr 9, 2024
View reviewed changes
docs/package.json Outdated Show resolved Hide resolved
@Adamj1232
Copy link
Member

@mytangying please merge in the latest develop and bump the versions as described in the PR when you have a moment.
I tried to push on my end but your repo is locked down.
I will be putting a release together in the next couple hours if you would like to make this repo into that.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 10, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/runtime@7.18.9 None +1 229 kB nicolo-ribaudo
npm/@esbuild-plugins/node-globals-polyfill@0.2.3 Transitive: environment, filesystem, network, shell +24 224 MB xmorse
npm/@esbuild-plugins/node-modules-polyfill@0.2.2 filesystem Transitive: environment, network, shell, unsafe +31 226 MB xmorse
npm/@ethersproject/abstract-provider@5.6.1 None 0 60.2 kB ricmoo
npm/@ethersproject/abstract-signer@5.6.2 None 0 82.2 kB ricmoo
npm/@ethersproject/address@5.6.1 None 0 33.1 kB ricmoo
npm/@fontsource/fira-mono@4.5.10 None 0 1.02 MB lotusdevshack
npm/@jridgewell/sourcemap-codec@1.4.14 None 0 40 kB jridgewell
npm/@rollup/plugin-commonjs@25.0.7 filesystem Transitive: environment +12 861 kB shellscape
npm/@sveltejs/adapter-auto@1.0.0-next.91 environment, filesystem, shell +1 78.4 kB svelte-admin
npm/@sveltejs/kit@1.0.0-next.589 environment, eval, filesystem Transitive: network, unsafe +20 2.75 MB svelte-admin
npm/@types/cookie@0.5.1 None 0 9.76 kB types
npm/@types/estree@1.0.0 None 0 25.7 kB types
npm/@typescript-eslint/eslint-plugin@5.49.0 Transitive: environment, filesystem +26 5.69 MB jameshenry
npm/@typescript-eslint/parser@5.49.0 Transitive: environment, filesystem +15 1.98 MB jameshenry
npm/@unstoppabledomains/resolution@8.5.0 None +1 888 kB dchan0319
npm/@walletconnect/jsonrpc-provider@1.0.13 None 0 103 kB gancho_walletconnect
npm/@walletconnect/jsonrpc-types@1.0.3 None +1 188 kB gancho_walletconnect
npm/@walletconnect/jsonrpc-utils@1.0.8 None +1 345 kB gancho_walletconnect
npm/@walletconnect/window-getters@1.0.1 None 0 218 kB bkrem
npm/@web3-onboard/injected-wallets@2.10.1 None +7 1.19 MB cmeisl
npm/@web3-onboard/react@2.8.11 Transitive: environment +1 62.5 kB cmeisl
npm/@web3-onboard/walletconnect@2.3.9 Transitive: environment, eval, filesystem, network, unsafe +173 34.2 MB cmeisl
npm/ajv@6.12.6 eval +4 1.47 MB esp
npm/ansi-styles@4.3.0 None +2 50.9 kB sindresorhus
npm/array-includes@3.1.5 None 0 22.9 kB ljharb
npm/assert@2.1.0 Transitive: environment, eval +9 357 kB ljharb
npm/braces@3.0.2 None +3 98.1 kB doowb
npm/brorand@1.1.0 None 0 3.52 kB indutny
npm/browserify-aes@1.2.0 None +1 34.6 kB cwmma
npm/browserify-rsa@4.1.0 None +1 103 kB cwmma
npm/browserify-zlib@0.2.0 None +1 980 kB dignifiedquire
npm/buffer@6.0.3 None +1 101 kB feross
npm/call-bind@1.0.2 None +1 39.9 kB ljharb
npm/call-bind@1.0.7 None +5 100 kB ljharb
npm/cipher-base@1.0.4 None 0 7.95 kB cwmma
npm/create-hash@1.2.0 None +1 12.9 kB cwmma
npm/create-hmac@1.1.7 None 0 5.81 kB cwmma
npm/crypto-browserify@3.12.0 None +12 334 kB cwmma
npm/d@1.0.1 None +1 125 kB medikoo
npm/debug@4.3.4 environment +1 49.2 kB qix
npm/decode-uri-component@0.2.2 None 0 6.09 kB samverschueren
npm/deepmerge@4.3.0 None 0 30.4 kB tehshrike
npm/define-data-property@1.1.4 None +3 62.7 kB ljharb
npm/define-properties@1.1.4 None +1 19.7 kB ljharb
npm/define-properties@1.2.1 None +1 39.4 kB ljharb
npm/elliptic@6.5.4 None +2 148 kB indutny
npm/es-abstract@1.20.1 None +22 1.79 MB ljharb
npm/es5-ext@0.10.62 eval +1 402 kB medikoo
npm/es6-symbol@3.1.3 None +2 131 kB medikoo
npm/eslint-config-next@12.2.5 unsafe Transitive: environment, eval, filesystem, network +55 42.8 MB vercel-release-bot
npm/eslint-config-prettier@8.6.0 None 0 18.2 kB lydell
npm/eslint-plugin-svelte3@4.0.0 None 0 41.3 kB conduitry
npm/eslint@8.22.0 filesystem Transitive: environment, unsafe +8 3.79 MB eslintbot
npm/eslint@8.33.0 filesystem Transitive: environment, shell, unsafe +61 8.93 MB eslintbot
npm/espree@9.3.3 None 0 75.8 kB eslintbot
npm/estraverse@5.3.0 None 0 37.1 kB michaelficarra
npm/estree-walker@2.0.2 None 0 50.2 kB rich_harris
npm/evp_bytestokey@1.0.3 None +1 12.8 kB dcousens
npm/fast-deep-equal@3.1.3 None 0 13 kB esp
npm/fast-glob@3.2.12 filesystem +1 148 kB mrmlnc
npm/get-intrinsic@1.1.2 eval +2 64.6 kB ljharb
npm/get-intrinsic@1.2.4 eval +5 127 kB ljharb
npm/glob@7.1.7 filesystem 0 55.9 kB isaacs
npm/has-bigints@1.0.2 None 0 12.8 kB ljharb
npm/has-property-descriptors@1.0.2 None +1 22.7 kB ljharb
npm/has-tostringtag@1.0.2 None +1 38.2 kB ljharb
npm/hash-base@3.0.4 None 0 6.03 kB dcousens
npm/hash.js@1.1.7 None 0 41.7 kB indutny
npm/ieee754@1.2.1 None 0 6.8 kB feross
npm/import-fresh@3.3.0 Transitive: filesystem, unsafe +3 19.8 kB sindresorhus
npm/inherits@2.0.4 None 0 3.96 kB isaacs
npm/is-callable@1.2.4 None 0 20.1 kB ljharb
npm/is-core-module@2.10.0 None +2 55.2 kB ljharb
npm/is-glob@4.0.3 None +1 19.8 kB phated
npm/is-string@1.0.7 None +1 30 kB ljharb
npm/is-symbol@1.0.4 None 0 22 kB ljharb
npm/is-typedarray@1.0.0 None 0 4.41 kB hughsk
npm/jsx-ast-utils@3.3.3 None 0 230 kB ljharb
npm/merge2@1.4.1 None 0 8.9 kB zensh
npm/minimalistic-assert@1.0.1 None 0 1.55 kB cwmma
npm/minimatch@3.1.2 None +3 57.8 kB isaacs
npm/minimist@1.2.6 None 0 33.2 kB substack
npm/minimist@1.2.7 None 0 50.7 kB ljharb
npm/next-tick@1.1.0 None 0 7.65 kB medikoo
npm/next@12.2.5 environment, filesystem, network, shell, unsafe +20 578 MB vercel-release-bot
npm/normalize-path@3.0.0 None 0 9.22 kB jonschlinkert
npm/object-inspect@1.12.2 None 0 93.6 kB ljharb
npm/object.assign@4.1.3 None 0 1.14 MB ljharb
npm/once@1.4.0 None +1 7.01 kB isaacs
npm/parse-asn1@5.1.7 Transitive: unsafe +1 71.4 kB ljharb
npm/pbkdf2@3.1.2 None 0 13.8 kB cwmma
npm/picomatch@2.3.1 None 0 90 kB mrmlnc
npm/prettier-plugin-svelte@2.9.0 environment 0 254 kB dummdidumm
npm/prettier@2.8.3 environment, filesystem, unsafe 0 11.7 MB prettier-bot
npm/randombytes@2.1.0 None 0 6.36 kB cwmma
npm/react-dom@18.2.0 environment +1 4.6 MB gnoff
npm/readable-stream@2.3.8 environment +5 147 kB matteo.collina
npm/regexp.prototype.flags@1.4.3 None +1 53.4 kB ljharb
npm/resolve@1.22.1 environment, filesystem +2 160 kB ljharb
npm/ripemd160@2.0.2 None 0 9.79 kB dcousens
npm/rollup-plugin-polyfill-node@0.12.0 None +3 1.52 MB fredkschott
npm/rollup@3.29.4 environment, filesystem +1 2.68 MB lukastaegert
npm/rxjs@7.8.0 None 0 4.49 MB blesh
npm/sade@1.8.1 None +1 44.8 kB lukeed
npm/safe-buffer@5.2.1 None 0 32.1 kB feross
npm/sha.js@2.4.11 None 0 31.1 kB dcousens
npm/stream-browserify@3.0.0 Transitive: environment +2 150 kB goto-bus-stop
npm/string-width@3.1.0 None +3 49.6 kB sindresorhus
npm/strip-ansi@6.0.1 None +1 9.64 kB sindresorhus
npm/strip-json-comments@3.1.1 None 0 6.96 kB sindresorhus
npm/svelte-check@3.0.3 Transitive: environment, filesystem +10 4.76 MB svelte-language-tools-deploy
npm/svelte-preprocess@5.0.1 environment, filesystem Transitive: eval +21 2.88 MB dummdidumm
npm/svelte@3.55.1 None 0 9.74 MB conduitry
npm/tslib@2.5.0 None 0 60 kB typescript-bot
npm/type-check@0.4.0 None +1 57.9 kB gkz
npm/typescript@4.9.5 None 0 66.8 MB typescript-bot
npm/uint8arrays@3.1.1 None +1 624 kB achingbrain
npm/util-deprecate@1.0.2 None 0 5.48 kB tootallnate
npm/vite@4.5.3 environment, eval, filesystem, network, shell, unsafe +29 213 MB vitebot
npm/which-typed-array@1.1.15 None +5 122 kB ljharb

🚮 Removed packages: npm/0xsequence@0.43.1, npm/@adraffy/ens-normalize@1.10.1, npm/@ampproject/remapping@2.2.1, npm/@apocentre/alias-sampling@0.5.3, npm/@arcana/auth@1.0.7, npm/@babel/code-frame@7.12.11, npm/@babel/compat-data@7.17.0, npm/@babel/core@7.23.2, npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-create-class-features-plugin@7.22.15, npm/@babel/helper-define-polyfill-provider@0.3.1, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-module-imports@7.22.15, npm/@babel/helper-plugin-utils@7.16.7, npm/@babel/helper-validator-option@7.22.15, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/plugin-syntax-typescript@7.22.5, npm/@babel/plugin-transform-modules-commonjs@7.23.0, npm/@babel/plugin-transform-runtime@7.17.0, npm/@babel/plugin-transform-typescript@7.22.15, npm/@babel/preset-typescript@7.23.2, npm/@babel/runtime@7.16.7, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@bitget-wallet/web3-sdk@0.0.8, npm/@blocto/dappauth@2.1.0, npm/@blocto/sdk@0.9.1, npm/@cedelabs/providers@1.5.0, npm/@celo/base@3.2.0, npm/@celo/utils@3.2.0, npm/@chainsafe/as-sha256@0.3.1, npm/@chainsafe/persistent-merkle-tree@0.4.2, npm/@chainsafe/ssz@0.9.4, npm/@chakra-ui/accordion@1.4.12, npm/@chakra-ui/alert@1.3.7, npm/@chakra-ui/anatomy@1.3.0, npm/@chakra-ui/avatar@1.3.11, npm/@chakra-ui/breadcrumb@1.3.6, npm/@chakra-ui/button@1.5.10, npm/@chakra-ui/checkbox@1.7.1, npm/@chakra-ui/clickable@1.2.6, npm/@chakra-ui/close-button@1.2.7, npm/@chakra-ui/color-mode@2.2.0, npm/@chakra-ui/control-box@1.1.6, npm/@chakra-ui/counter@1.2.10, npm/@chakra-ui/css-reset@1.1.3, npm/@chakra-ui/editable@1.4.2, npm/@chakra-ui/focus-lock@1.2.6, npm/@chakra-ui/icon@2.0.5, npm/@chakra-ui/icons@2.1.1, npm/@chakra-ui/input@1.4.6, npm/@chakra-ui/layout@1.8.0, npm/@chakra-ui/live-region@1.1.6, npm/@chakra-ui/media-query@2.0.4, npm/@chakra-ui/menu@1.8.12, npm/@chakra-ui/modal@1.11.1, npm/@chakra-ui/number-input@1.4.7, npm/@chakra-ui/pin-input@1.7.11, npm/@chakra-ui/popover@1.11.9, npm/@chakra-ui/progress@1.2.6, npm/@chakra-ui/provider@1.7.14, npm/@chakra-ui/radio@1.5.1, npm/@chakra-ui/react-utils@1.2.3, npm/@chakra-ui/react@1.8.9, npm/@chakra-ui/theme-tools@1.3.6, npm/@chakra-ui/utils@1.10.4, npm/@coinbase/wallet-sdk@3.7.2, npm/@cosmjs/amino@0.31.0, npm/@cosmjs/crypto@0.31.3, npm/@cosmjs/encoding@0.31.3, npm/@cosmjs/math@0.31.3, npm/@cosmjs/proto-signing@0.31.0, npm/@cosmjs/utils@0.31.3, npm/@cspotcode/source-map-consumer@0.8.0, npm/@cspotcode/source-map-support@0.7.0, npm/@discoveryjs/json-ext@0.5.6, npm/@emotion/is-prop-valid@1.2.2, npm/@emotion/react@11.11.4, npm/@emotion/serialize@1.1.4, npm/@emotion/styled@11.11.5, npm/@eslint/eslintrc@0.4.3, npm/@ethereumjs/common@2.5.0, npm/@ethereumjs/rlp@4.0.0, npm/@ethereumjs/tx@3.3.2, npm/@ethereumjs/util@8.0.2, npm/@ethersproject/abi@5.7.0, npm/@ethersproject/abstract-provider@5.7.0, npm/@ethersproject/abstract-signer@5.7.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/base64@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/constants@5.7.0, npm/@ethersproject/hash@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/networks@5.7.1, npm/@ethersproject/properties@5.7.0, npm/@ethersproject/rlp@5.7.0, npm/@ethersproject/signing-key@5.7.0, npm/@ethersproject/strings@5.7.0, npm/@ethersproject/transactions@5.7.0, npm/@ethersproject/web@5.7.1, npm/@findeth/abi@0.3.1, npm/@formatjs/ecma402-abstract@1.11.3, npm/@formatjs/icu-messageformat-parser@2.0.18, npm/@hapi/address@5.1.1, npm/@hapi/formula@3.0.2, npm/@hapi/hoek@11.0.2, npm/@hapi/pinpoint@2.0.1, npm/@hapi/tlds@1.0.1, npm/@humanwhocodes/config-array@0.5.0, npm/@infinitywallet/infinity-connector@1.0.6, npm/@ioredis/commands@1.2.0, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.19, npm/@keepkey/device-protocol@7.7.0, npm/@keystonehq/base-eth-keyring@0.6.4, npm/@keystonehq/eth-keyring@0.14.4, npm/@ledgerhq/connect-kit-loader@1.1.0, npm/@ledgerhq/connect-kit@1.1.12, npm/@lit-labs/ssr-dom-shim@1.1.0, npm/@magic-sdk/commons@4.1.0, npm/@magic-sdk/provider@28.0.2, npm/@magic-sdk/types@24.0.1, npm/@metamask/detect-provider@2.0.0, npm/@metamask/eth-json-rpc-middleware@11.0.0, npm/@metamask/eth-sig-util@5.1.0, npm/@metamask/json-rpc-engine@7.3.3, npm/@metamask/json-rpc-middleware-stream@6.0.2, npm/@metamask/object-multiplex@1.2.0, npm/@metamask/onboarding@1.0.1, npm/@metamask/providers@8.1.1, npm/@metamask/rpc-errors@6.2.1, npm/@metamask/safe-event-emitter@2.0.0, npm/@metamask/sdk-communication-layer@0.18.2, npm/@metamask/sdk-install-modal-web@0.17.0, npm/@metamask/sdk@0.18.3, npm/@metamask/utils@3.6.0, npm/@motionone/animation@10.17.0, npm/@motionone/dom@10.12.0, npm/@motionone/easing@10.17.0, npm/@motionone/generators@10.17.0, npm/@motionone/types@10.17.0, npm/@motionone/utils@10.17.0, npm/@myetherwallet/mewconnect-web-client@2.2.0-beta.16, npm/@ngraveio/bc-ur@1.1.6, npm/@niceties/logger@1.1.3, npm/@noble/curves@1.2.0, npm/@noble/ed25519@1.7.1, npm/@noble/hashes@1.3.2, npm/@noble/secp256k1@1.6.3, npm/@nothing-but/utils@0.3.2, npm/@parcel/watcher-android-arm64@2.3.0, npm/@parcel/watcher-darwin-arm64@2.3.0, npm/@parcel/watcher-darwin-x64@2.3.0, npm/@parcel/watcher-freebsd-x64@2.3.0, npm/@parcel/watcher-linux-arm-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-glibc@2.3.0, npm/@parcel/watcher-linux-arm64-musl@2.3.0, npm/@parcel/watcher-linux-x64-glibc@2.3.0, npm/@parcel/watcher-linux-x64-musl@2.3.0, npm/@parcel/watcher-wasm@2.3.0, npm/@parcel/watcher-win32-arm64@2.3.0, npm/@parcel/watcher-win32-ia32@2.3.0, npm/@parcel/watcher-win32-x64@2.3.0, npm/@parcel/watcher@2.3.0, npm/@particle-network/analytics@1.0.1, npm/@particle-network/auth@1.3.1, npm/@particle-network/provider@1.3.2, npm/@portis/web3@4.0.7, npm/@protobufjs/aspromise@1.1.2, npm/@ramp-network/ramp-instant-sdk@4.0.4, npm/@rollup-extras/plugin-copy@1.2.2, npm/@rollup/plugin-json@4.1.0, npm/@rollup/plugin-node-resolve@11.2.1, npm/@rollup/plugin-replace@5.0.5, npm/@rollup/plugin-typescript@8.3.0, npm/@safe-global/safe-apps-provider@0.17.1, npm/@safe-global/safe-apps-sdk@8.0.0, npm/@shapeshiftoss/bitcoinjs-lib@5.2.0-shapeshift.2, npm/@shapeshiftoss/hdwallet-core@1.18.4, npm/@shapeshiftoss/hdwallet-keepkey-webusb@1.18.4, npm/@shapeshiftoss/hdwallet-keepkey@1.18.4, npm/@solana/web3.js@1.78.5, npm/@solid-devtools/debugger@0.22.4, npm/@solid-primitives/event-listener@2.3.0, npm/@solid-primitives/rootless@1.4.2, npm/@solid-primitives/utils@6.2.1, npm/@tanstack/query-core@4.36.1, npm/@tanstack/query-persist-client-core@4.36.1, npm/@tanstack/query-sync-storage-persister@4.36.1, npm/@tanstack/react-query-persist-client@4.36.1, npm/@tanstack/react-query@4.36.1, npm/@toruslabs/base-controllers@2.8.0, npm/@toruslabs/http-helpers@3.3.0, npm/@toruslabs/openlogin-ed25519@3.2.0, npm/@toruslabs/openlogin-jrpc@3.2.0, npm/@toruslabs/openlogin-utils@3.0.0, npm/@toruslabs/openlogin@3.2.1, npm/@toruslabs/solana-embed@0.3.4, npm/@toruslabs/torus-embed@2.2.9, npm/@trezor/analytics@1.0.5, npm/@trezor/blockchain-link-types@1.0.4, npm/@trezor/blockchain-link-utils@1.0.5, npm/@trezor/blockchain-link@2.1.15, npm/@trezor/connect-analytics@1.0.4, npm/@trezor/connect-common@0.0.18, npm/@trezor/connect-web@9.1.1, npm/@tsconfig/node10@1.0.8, npm/@tsconfig/node12@1.0.9, npm/@tsconfig/node14@1.0.1, npm/@tsconfig/node16@1.0.2, npm/@tsconfig/svelte@2.0.1, npm/@types/body-parser@1.19.2, npm/@types/bonjour@3.5.10, npm/@types/connect-history-api-fallback@1.3.5, npm/@types/connect@3.4.35, npm/@types/eslint-scope@3.7.3, npm/@types/estree@1.0.5, npm/@types/express-serve-static-core@4.17.28, npm/@types/express@4.17.13, npm/@types/glob@7.2.0, npm/@types/http-proxy@1.17.8, npm/@types/istanbul-lib-coverage@2.0.4, npm/@types/js-cookie@2.2.7, npm/@types/json-schema@7.0.9, npm/@types/lodash.merge@4.6.6, npm/@types/lodash.partition@4.6.6, npm/@types/lodash.uniqby@4.7.6, npm/@types/lodash@4.14.178, npm/@types/node@18.15.13, npm/@types/prop-types@15.7.4, npm/@types/react@18.0.9, npm/@types/retry@0.12.1, npm/@types/secp256k1@4.0.3, npm/@types/serve-index@1.9.1, npm/@types/sockjs@0.3.33, npm/@types/use-sync-external-store@0.0.3, npm/@types/ws@7.4.7, npm/@typescript-eslint/eslint-plugin@4.33.0, npm/@typescript-eslint/parser@4.33.0, npm/@web3-onboard/coinbase@2.2.7, npm/@web3-onboard/walletconnect@2.5.4, npm/css-loader@6.11.0, npm/style-loader@3.3.4, npm/webpack-cli@5.1.4, npm/webpack-dev-server@4.15.2

View full report↗︎

Adamj1232
Adamj1232 reviewed Apr 11, 2024
View reviewed changes
docs/package.json Outdated Show resolved Hide resolved
mytangying and others added 3 commits April 12, 2024 09:07
@mytangying @Adamj1232
Update docs/package.json
f0965b0 
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
@mytangying @Adamj1232
Update packages/demo/package.json
1711a4d 
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
@mytangying @Adamj1232
Update packages/injected/package.json
85927dd 
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Adamj1232
Adamj1232 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you would like to work some promo up with the BN team please feel free to reach out

@Adamj1232 Adamj1232 merged commit 05a3868 into blocknative:develop Apr 12, 2024
2 of 3 checks passed
This was referenced Apr 15, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adamj1232 Adamj1232 Adamj1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mytangying @Adamj1232