Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent discovery of modules while scaffolding modules #4046

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jan 15, 2025

fixes #4039

watch can now be configured to only discover modules while it has acquisition of a file lock.
This allows coordination with ftl new so that half scaffolded modules are not detected too quickly, causing build errors.

@matt2e matt2e requested a review from alecthomas as a code owner January 15, 2025 02:46
@alecthomas alecthomas mentioned this pull request Jan 15, 2025
@matt2e matt2e force-pushed the matt2e/fix-new-while-watch branch from 006da04 to 2b53a50 Compare January 15, 2025 02:50
@matt2e matt2e force-pushed the matt2e/fix-new-while-watch branch from 2b53a50 to b83244b Compare January 15, 2025 02:53
@matt2e matt2e merged commit 35df745 into main Jan 15, 2025
63 checks passed
@matt2e matt2e deleted the matt2e/fix-new-while-watch branch January 15, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating go module with ftl dev we got an error about invalid version
1 participant