Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of run_inference_algorithm docstring. #624

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

junpenglao
Copy link
Member

@junpenglao junpenglao commented Dec 10, 2023

No description provided.

@reubenharry
Copy link
Contributor

I'm not totally convinced the * (dim - 1) is a bug. Let me think about this for a bit before this gets merged.

blackjax/mcmc/mclmc.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24a328f) 99.07% compared to head (d331668) 99.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   99.07%   99.07%   -0.01%     
==========================================
  Files          58       58              
  Lines        2600     2599       -1     
==========================================
- Hits         2576     2575       -1     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junpenglao junpenglao enabled auto-merge (squash) December 11, 2023 07:54
@junpenglao junpenglao disabled auto-merge December 11, 2023 09:04
@junpenglao junpenglao merged commit d8fd15a into blackjax-devs:main Dec 11, 2023
7 checks passed
@junpenglao junpenglao deleted the clean_up branch December 11, 2023 09:04
junpenglao added a commit that referenced this pull request Mar 12, 2024
* Clean up of `run_inference_algorithm` docstring.

Also fix a bug in MCLMC

* revert fix for further investigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants