Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MNIST example to use Flax #365

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Conversation

zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Sep 29, 2022

This updates the MNIST example to use Flax. Provides modest speed-ups.

Fixes #326

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #365 (d5f2991) into main (58d0076) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          45       45           
  Lines        2248     2248           
=======================================
  Hits         2018     2018           
  Misses        230      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rlouf
Copy link
Member

rlouf commented Sep 29, 2022

LGTM! Let's take out the predict_fn out it's not doing anything more than model.apply besides jitting. Then let's squash the commits and merge if CI passes.

SGHMC still needs to be added.

Oh yes and of course that.

@zaxtax
Copy link
Contributor Author

zaxtax commented Sep 29, 2022

LGTM! Let's take out the predict_fn out it's not doing anything more than model.apply besides jitting. Then let's squash the commits and merge if CI passes.

SGHMC still needs to be added.

Oh yes and of course that.

All changes made!

@rlouf rlouf merged commit bf15ed8 into blackjax-devs:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite the MNIST MLP example with Flax
2 participants