Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: renaming filteres #130

Closed
TaLoN1x opened this issue May 3, 2024 · 7 comments
Closed

Feature Request: renaming filteres #130

TaLoN1x opened this issue May 3, 2024 · 7 comments
Labels
enhancement New feature or request released

Comments

@TaLoN1x
Copy link
Contributor

TaLoN1x commented May 3, 2024

Support with search/replace for vc/ovirt Datacenter renames. The case if where in different systems admins used different names, aga:

ovirt: TestDC
vcenter: TESTDC

Currently it creates slug collision, would be good to being able to merge them by rewriting it for one of the sources.

@TaLoN1x
Copy link
Contributor Author

TaLoN1x commented May 3, 2024

filtering like with other would work

@bl4ko
Copy link
Owner

bl4ko commented May 3, 2024

So If I understand correctly, you get a slug collision when naming two datacenters the same way (but different case):

source:
  - name: TestDC
    type: ovirt
    ...
    
  - name: TESTDC
    type: vcenter
    ...

@bl4ko bl4ko added the enhancement New feature or request label May 3, 2024
@TaLoN1x
Copy link
Contributor Author

TaLoN1x commented May 3, 2024

Yes, it is correct. With some massive deployments resolving such problems in Hyperviaors might be 'complicated' and take time. A way to rename / remat ClusterGroups would ease onboarding

@bl4ko
Copy link
Owner

bl4ko commented May 4, 2024

Ok understandable, so I can add an option like this in config.yaml:

source:
  - name: TestDC
    type: ovirt
    datacenterRename:
      - TestDC = testdc_ov
    
  - name: TESTDC
    type: vcenter
    datacenterRename:
      - TESTDC = testdc_vc

Or do you suggest different approach?

@TaLoN1x
Copy link
Contributor Author

TaLoN1x commented May 4, 2024

I this this approach is good, thus I would call it consistently with other relation mappings, like:
datacenterClusterGroupRelations as in model we use Cluster Groups for that, or somehow similarly.

@bl4ko
Copy link
Owner

bl4ko commented May 4, 2024

Yeah I agree.

@bl4ko bl4ko closed this as completed in a33589d May 4, 2024
@bl4ko
Copy link
Owner

bl4ko commented May 4, 2024

🎉 This issue has been resolved in version 0.6.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bl4ko bl4ko added the released label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants