Fix package resolution when DocumentJS is run globally #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when DocumentJS was installed globally and run, it wouldn’t be able to find packages in the project where the user was running the command. This adds a fallback to using [resolve](https://www.npmjs.com/package/resolve)’s implementation of Node’s algorithm in the user’s current working directory. Fixes #275
|
I think a test would be too hard in this case and not worth the trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when DocumentJS was installed globally and run, it wouldn’t be able to find packages in the project where the user was running the command.
This adds a fallback to using resolve’s implementation of Node’s algorithm in the user’s current working directory.
I tested this by installing this fixed version globally and running the global command in a project that wasn’t working before. I would appreciate some help figuring out how I should write a test for this case!
Fixes #275