Fix travis Go version #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out all our released binaries are compiled with Go 1.14.0 because .travis.yaml contains the `1.14` version spec which doesn't imply "latest version of 1.14 branch" (I checked that on our released binaries following the instructions on https://dave.cheney.net/2017/06/20/how-to-find-out-which-go-version-built-your-binary) A user reported an issue (#411) that is likely caused by a toolchain bug (golang/go#37436) which is fixed in 1.14.1 (2020/03/19). Several sealed-secret releases happened after that and we didn't inherit the fix. Given the strong backwards compat guarantees the Go team commits to, I think it's a good idea to just build with the latest version of the toolchain. Closes #411
aruiz14
approved these changes
May 26, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out all our released binaries are compiled with Go 1.14.0 because .travis.yaml
contains the
1.14version spec which doesn't imply "latest version of 1.14 branch"(I checked that on our released binaries following the instructions on https://dave.cheney.net/2017/06/20/how-to-find-out-which-go-version-built-your-binary)
A user reported an issue (#411) that is likely caused by a toolchain bug (golang/go#37436)
which is fixed in 1.14.1 (2020/03/19).
Several sealed-secret releases happened after that and we didn't inherit the fix.
Given the strong backwards compat guarantees the Go team commits to,
I think it's a good idea to just build with the latest version of the toolchain.
Closes #411