Strip strategic merge patch annotations #228
Conversation
| } | ||
| keys := []string{ | ||
| "kubectl.kubernetes.io/last-applied-configuration", | ||
| "kubecfg.ksonnet.io/last-applied-configuration", |
There was a problem hiding this comment.
do you know any other tool that does something similar?
There was a problem hiding this comment.
Not that I know of.
Perhaps make a regex on *last-applied-configuration ?
There was a problem hiding this comment.
I suspect I'd regret that choice when somebody would report bewilderment at a stripped annotation with a similar name but with a different semantics.
There was a problem hiding this comment.
Perhaps check all annotations and strip anything that contains original plain text?
There was a problem hiding this comment.
that wouldn't work with "kubecfg.ksonnet.io/last-applied-configuration since it's gzip compressed
| } | ||
| keys := []string{ | ||
| "kubectl.kubernetes.io/last-applied-configuration", | ||
| "kubecfg.ksonnet.io/last-applied-configuration", |
There was a problem hiding this comment.
Perhaps check all annotations and strip anything that contains original plain text?
|
bors r+ |
Build succeeded |
Closes #227