Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sha1_* functions #172

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Deprecate sha1_* functions #172

merged 2 commits into from
Apr 1, 2023

Conversation

jelmer
Copy link
Member

@jelmer jelmer commented Feb 3, 2023

  • Migrate existing callers in bitlbee to directly use GChecksum
  • Mark functions as deprecated for external users

@jelmer jelmer merged commit a4ac9c4 into bitlbee:master Apr 1, 2023
arkamar added a commit to arkamar/bitlbee that referenced this pull request Feb 20, 2024
The jabber/conference.c module failed to compile due to the implicit use
of the sha1_random_uuid function following the deprecation of the sha1
lib. This patch reintroduces the sha1.h include to resolve compilation
errors encountered with GCC 14:

  error: implicit declaration of function ‘sha1_random_uuid’

Additionally, the patch corrects the type mismatch error when calling
sha1_random_uuid, aligning with the expected ‘GChecksum **’ type,
otherwise compilation fails with following error:

  error: passing argument 1 of ‘sha1_random_uuid’ from incompatible pointer type
  note: expected ‘GChecksum **’ {aka ‘struct _GChecksum **’} but argument is of type ‘GChecksum *’ {aka ‘struct _GChecksum *’}

Fixes: a4ac9c4 ("Deprecate sha1_* functions (bitlbee#172)")
jelmer pushed a commit that referenced this pull request May 8, 2024
The jabber/conference.c module failed to compile due to the implicit use
of the sha1_random_uuid function following the deprecation of the sha1
lib. This patch reintroduces the sha1.h include to resolve compilation
errors encountered with GCC 14:

  error: implicit declaration of function ‘sha1_random_uuid’

Additionally, the patch corrects the type mismatch error when calling
sha1_random_uuid, aligning with the expected ‘GChecksum **’ type,
otherwise compilation fails with following error:

  error: passing argument 1 of ‘sha1_random_uuid’ from incompatible pointer type
  note: expected ‘GChecksum **’ {aka ‘struct _GChecksum **’} but argument is of type ‘GChecksum *’ {aka ‘struct _GChecksum *’}

Fixes: a4ac9c4 ("Deprecate sha1_* functions (#172)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant