Fix regression & simplify tests #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case
|
Ah nicely spotted! And thanks for improving the integration tests too 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #246 (see #246 (comment)), by reverting the specific change, along with adding a test case.
I also took the opportunity to move the tests in
test_suiteback into the crate tests (instead of having a workspace with atest_suitecrate). AFAICT, this happened because it needed extra features that shouldn't leak, but that isn't the case anymore. This makes it easier to run the tests (justcargo testin the main directory).I also removed
appveyor.ymlfrom theexcludelist inCargo.toml, I'm not sure why it was there in the first place though.