Skip to content

doc: explain why we substract 4000 from `DEFAULT_BLOCK_MAX_WEIGHT`

Cirrus CI / lint failed Nov 27, 2024 in 1m 28s

Task Summary

Instruction lint failed in 00:35

Details

✅ 00:02 clone
✅ 00:11 merge_base
✅ 00:01 test_runner
✅ 00:05 python
✅ 00:30 unshallow
❌ 00:35 lint

[19:58:46.051] ++ git rev-list -1 HEAD
[19:58:46.054] ++ git rev-list -1 --merges HEAD
[19:58:46.057] + '[' ac34c3237e24c3df38c0ba377f0f7f6ceef30d30 '!=' ac34c3237e24c3df38c0ba377f0f7f6ceef30d30 ']'
[19:58:46.057] + export COMMIT_RANGE
[19:58:46.057] + echo
[19:58:46.057] 
[19:58:46.057] + git log --no-merges --oneline HEAD~..HEAD
[19:58:46.060] c8842c20b6 doc: explain why we substract 4000 from `DEFAULT_BLOCK_MAX_WEIGHT`
[19:58:46.060] 49b1e6d67d miner: bugfix: remove duplicate space reservation for coinbase tx
[19:58:46.060] + echo
[19:58:46.060] 
[19:58:46.060] + test/lint/commit-script-check.sh HEAD~..HEAD
[19:58:46.097] + RUST_BACKTRACE=1
[19:58:46.097] + /lint_test_runner/test_runner
[19:58:46.401] Args used        : 214
[19:58:46.401] Args documented  : 226
[19:58:46.401] Args undocumented: 0
[19:58:46.401] set()
[19:58:46.401] Args unknown     : 12
[19:58:46.401] {'-zmqpubhashtx', '-testdatadir', '-zmqpubhashtxhwm', '-includeconf', '-zmqpubsequence', '-zmqpubrawblock', '-zmqpubrawblockhwm', '-zmqpubhashblock', '-zmqpubsequencehwm', '-zmqpubrawtx', '-zmqpubhashblockhwm', '-zmqpubrawtxhwm'}
[19:58:50.358] All checks passed!
[19:58:50.542] src/crc32c in HEAD currently refers to tree 454691a9b89ee8b9e1f71a48a7398edba49c3805
[19:58:50.544] src/crc32c in HEAD was last updated in commit 5d45552fd4303f8d668ffbc50cce1053485aeead (tree 454691a9b89ee8b9e1f71a48a7398edba49c3805)
[19:58:50.544] GOOD
[19:58:50.987] src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
[19:58:50.993] src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
[19:58:50.993] GOOD
[19:58:51.116] src/leveldb in HEAD currently refers to tree cb176f0f0a9a93bcef89bdd70424cae01ad21629
[19:58:51.119] src/leveldb in HEAD was last updated in commit a37778d4d32b4ddeff96f68a130dc8da3a84b278 (tree cb176f0f0a9a93bcef89bdd70424cae01ad21629)
[19:58:51.119] GOOD
[19:58:51.165] src/minisketch in HEAD currently refers to tree 85cb93120ae68ef1f6fa597da30e18298848e0e9
[19:58:51.174] src/minisketch in HEAD was last updated in commit cb59af38e72ab189b052ec84e2d1027473235ba4 (tree 85cb93120ae68ef1f6fa597da30e18298848e0e9)
[19:58:51.174] GOOD
[19:58:51.197] src/secp256k1 in HEAD currently refers to tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1
[19:58:51.197] src/secp256k1 in HEAD was last updated in commit 2d46a89386d34d72edf93a24b67e44b82fe6e390 (tree a6dd5562b35bdbf5f959a18a8af51d526527b9b1)
[19:58:51.197] GOOD
[19:58:51.269] src/node/types.h:40:    
[19:58:51.270] src/policy/policy.h:22:/** Default value for -blockmaxweight, which controls the range of block weights the mining code will create. 
[19:58:51.425] 
[19:58:51.425] ^^^
[19:58:51.425] Trailing whitespace (including Windows line endings [CR LF]) is problematic, because git may warn
[19:58:51.425] about it, or editors may remove it by default, forcing developers in the future to either undo the
[19:58:51.425] changes manually or spend time on review.
[19:58:51.425] 
[19:58:51.425] Thus, it is best to remove the trailing space now.
[19:58:51.425] 
[19:58:51.425] Please add any false positives, such as subtrees, Windows-related files, patch files, or externally
[19:58:51.425] sourced files to the exclude list.
[19:58:51.425]             
[19:58:51.425] ^---- ⚠️ Failure generated from lint check 'trailing_whitespace'!
[19:58:51.425] Check for trailing whitespace
[19:58:54.869] src/txmempool.cpp:445: tranaction ==> transaction
[19:58:54.869] src/txmempool.h:813: transacion ==> transaction
[19:58:54.869] ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
[19:59:09.811] Success: no issues found in 303 source files
����