Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix test_random includes #9095

Merged
merged 1 commit into from
Nov 8, 2016
Merged

test: Fix test_random includes #9095

merged 1 commit into from
Nov 8, 2016

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 7, 2016 •
edited
Loading

Follow up of #8914 to fix gitian builds.

@jonasschnelli Can you try this and see what https://bitcoin.jonasschnelli.ch/pulls/9095 says?

@maflcko maflcko added the Tests label Nov 7, 2016
@maflcko
Copy link
Member Author

maflcko commented Nov 7, 2016

https://bitcoin.jonasschnelli.ch/pulls/9095/build-linux.log

test/coins_tests.cpp:10:30: fatal error: test/test_random.h: No such file or directory
 #include "test/test_random.h"
                              ^
compilation terminated.

😕

@jonasschnelli
Copy link
Contributor

Yes. This fixes my gitian issues present since oct 19th (nightly builds).
Tested ACK fa8278e

@fanquake
Copy link
Member

fanquake commented Nov 8, 2016

utACK fa8278e

@paveljanik
Copy link
Contributor

ACK fa8278e

@jonasschnelli jonasschnelli merged commit fa8278e into bitcoin:master Nov 8, 2016
jonasschnelli added a commit that referenced this pull request Nov 8, 2016
@jonasschnelli
Merge #9095: test: Fix test_random includes
b8f43e3 
fa8278e test: Fix test_random includes (MarcoFalke)
@maflcko maflcko deleted the Mf1611-testRand branch November 8, 2016 09:00
codablock pushed a commit to codablock/dash that referenced this pull request Jan 15, 2018
@jonasschnelli @codablock
Merge bitcoin#9095: test: Fix test_random includes
705057f 
fa8278e test: Fix test_random includes (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@jonasschnelli @andvgal
Merge bitcoin#9095: test: Fix test_random includes
e5f397a 
fa8278e test: Fix test_random includes (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 24, 2019
@jonasschnelli @CryptoCentric
Merge bitcoin#9095: test: Fix test_random includes
7b1d8f9 
fa8278e test: Fix test_random includes (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @jonasschnelli @fanquake @paveljanik