Add copyright/patent issues to possible NACK reasons #8915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btcdrak
reviewed
Oct 13, 2016
| @@ -178,7 +178,9 @@ language is used within pull-request comments: | |||
|
|
|||
| - ACK means "I have tested the code and I agree it should be merged"; | |||
| - NACK means "I disagree this should be merged", and must be accompanied by | |||
| sound technical justification. NACKs without accompanying reasoning may be disregarded; | |||
| sound technical justification (or in certain cases of copyright/patent | |||
There was a problem hiding this comment.
add /licensing because patches may also be unable to be included if the licensing is incompatible with the project.
Adding in response to a Slack discussion where someone was unclear on the fact that a NACK may be justified if code can't be accepted due to copyright/patent issues. For example, it would be reasonable and prudent to NACK a contribution of AGPL-licensed consensus code on the basis that the license terms are incompatible with the MIT license used by the rest of the codebase.
petertodd
force-pushed
the
2016-10-13-sound-legal-justification
branch
from
591bf24 to
36f60a5
Compare
|
utACK |
2 similar comments
|
utACK |
|
utACK |
maflcko
pushed a commit
that referenced
this pull request
Oct 14, 2016
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 12, 2018
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in response to a Slack discussion where someone was unclear on the fact that a NACK may be justified if code can't be accepted due to copyright/patent issues. For example, it would be reasonable and prudent to NACK a contribution of AGPL-licensed consensus code on the basis that the license terms are incompatible with the MIT license used by the rest of the codebase.