Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: Mention not to open several pulls #8771

Merged
merged 1 commit into from
Sep 25, 2016

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Sep 21, 2016

No description provided.

@@ -87,6 +87,15 @@ before it will be merged. The basic squashing workflow is shown below.
# save and quit
git push -f # (force push to GitHub)

If you need help with squashing (or other workflows with `git`), you can
alternatively enable "Allow edits from maintainers" in the right GitHub
sidebar and ask for help in the pull request.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is something we want to encourage...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not in general, but we want to encourage it for people that don't know how to use git. I'd prefer people to learn how to do it themselves, of course, but personally tutoring everyone how to use git (especially those that use the web interface :( ) is a lot of work.

alternatively enable "Allow edits from maintainers" in the right GitHub
sidebar and ask for help in the pull request.

Please refrain from creating several pull request for the same topic.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"same change"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "several pull requests"?

@maflcko maflcko force-pushed the Mf1609-ContributeDoc branch from fa09f34 to fa1bcfd Compare September 21, 2016 09:45
@maflcko maflcko added the Docs label Sep 21, 2016
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed feedback

Copy link
Member Author

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@maflcko maflcko force-pushed the Mf1609-ContributeDoc branch from fa1bcfd to fabe57a Compare September 21, 2016 12:56
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gmaxwell
Copy link
Contributor

Seems reasonable, though the minor "Fix 0.13 release notes attribution mistake" commit seems unrelated.

@maflcko maflcko force-pushed the Mf1609-ContributeDoc branch from fabe57a to faa91bc Compare September 22, 2016 22:42
@laanwj laanwj merged commit faa91bc into bitcoin:master Sep 25, 2016
laanwj added a commit that referenced this pull request Sep 25, 2016
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
@maflcko maflcko deleted the Mf1609-ContributeDoc branch September 25, 2016 13:13
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants