-
Notifications
You must be signed in to change notification settings - Fork 36.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING: Mention not to open several pulls #8771
Conversation
@@ -87,6 +87,15 @@ before it will be merged. The basic squashing workflow is shown below. | |||
# save and quit | |||
git push -f # (force push to GitHub) | |||
|
|||
If you need help with squashing (or other workflows with `git`), you can | |||
alternatively enable "Allow edits from maintainers" in the right GitHub | |||
sidebar and ask for help in the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is something we want to encourage...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not in general, but we want to encourage it for people that don't know how to use git. I'd prefer people to learn how to do it themselves, of course, but personally tutoring everyone how to use git (especially those that use the web interface :( ) is a lot of work.
alternatively enable "Allow edits from maintainers" in the right GitHub | ||
sidebar and ask for help in the pull request. | ||
|
||
Please refrain from creating several pull request for the same topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"same change"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "several pull requests"?
fa09f34
to
fa1bcfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
fa1bcfd
to
fabe57a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Seems reasonable, though the minor "Fix 0.13 release notes attribution mistake" commit seems unrelated. |
fabe57a
to
faa91bc
Compare
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
faa91bc CONTRIBUTING: Mention not to open several pulls (MarcoFalke)
No description provided.