-
Notifications
You must be signed in to change notification settings - Fork 36.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mempool] Fix relaypriority calculation error #8357
Conversation
I‘m so sorry ! for this pull request, I try three times. |
No worries. There is always bitcoin-core-dev on freenode. We are happy to help with git issues. |
@MarcoFalke thanks, and how can i delete the two closed pull request i created before? |
Only github admins can delete pull requests, but don't worry about them. |
@laanwj Thank you for your reply. |
@maiiz You can still try to adjust the commit message locally (with git)
|
@MarcoFalke i change the commit message as you teached! |
utACK 11d7cd5 |
utACK |
... although this has nothing to do with the wallet? Commit message should probably be fixed. |
@luke-jr should i change the commit message again?
|
@maiiz Sorry for the confusion: I think the mempool, miner and wallet use this logic, but each have the code copied and this bug can only be found in one of the instances... You can remove the tag altogether from the commit message just to be safe. |
11d7cd5
to
98030c3
Compare
98030c3
to
94a34a5
Compare
utACK |
utACK 94a34a5 |
94a34a5 Fix relaypriority calculation error (maiiz)
Github-Pull: bitcoin#8357 Rebased-From: 94a34a5
Github-Pull: bitcoin#8357 Rebased-From: 94a34a5
94a34a5 Fix relaypriority calculation error (maiiz)
94a34a5 Fix relaypriority calculation error (maiiz)
[mempool] Fix relaypriority calculation error
Fixes #8334