Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mempool] Fix relaypriority calculation error #8357

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

maiiz
Copy link
Contributor

@maiiz maiiz commented Jul 18, 2016

[mempool] Fix relaypriority calculation error

Fixes #8334

@maflcko maflcko changed the title Update coins.cpp [Wallet] Fix relaypriority calculation error Jul 18, 2016
@maflcko maflcko added the Wallet label Jul 18, 2016
@maiiz
Copy link
Contributor Author

maiiz commented Jul 18, 2016

I‘m so sorry ! for this pull request, I try three times.

@maflcko
Copy link
Member

maflcko commented Jul 18, 2016

No worries. There is always bitcoin-core-dev on freenode. We are happy to help with git issues.

@maiiz
Copy link
Contributor Author

maiiz commented Jul 18, 2016

@MarcoFalke thanks, and how can i delete the two closed pull request i created before?

@laanwj
Copy link
Member

laanwj commented Jul 18, 2016

and how can i delete the two closed pull request i created before?

Only github admins can delete pull requests, but don't worry about them.

@maiiz
Copy link
Contributor Author

maiiz commented Jul 18, 2016

@laanwj Thank you for your reply.

@maflcko
Copy link
Member

maflcko commented Aug 3, 2016

@maiiz You can still try to adjust the commit message locally (with git)

git clone $yourrepo
cd $yourrepo
git checkout maiiz-patch-1
git commit --amend
git push origin maiiz-patch-1 -f

@maiiz
Copy link
Contributor Author

maiiz commented Aug 29, 2016

@MarcoFalke i change the commit message as you teached!

@maflcko
Copy link
Member

maflcko commented Aug 29, 2016

utACK 11d7cd5

@luke-jr
Copy link
Member

luke-jr commented Sep 10, 2016

utACK

@luke-jr
Copy link
Member

luke-jr commented Sep 10, 2016

... although this has nothing to do with the wallet? Commit message should probably be fixed.

@maflcko maflcko added Mempool and removed Wallet labels Sep 11, 2016
@maflcko maflcko changed the title [Wallet] Fix relaypriority calculation error [CCoinsViewCache] Fix relaypriority calculation error Sep 11, 2016
@maflcko maflcko changed the title [CCoinsViewCache] Fix relaypriority calculation error [mempool] Fix relaypriority calculation error Sep 11, 2016
@maiiz
Copy link
Contributor Author

maiiz commented Sep 13, 2016

@luke-jr should i change the commit message again?
change like this?

[wallet] Fix relaypriority calculation error -> [mempool] Fix relaypriority calculation error 

@maflcko
Copy link
Member

maflcko commented Sep 13, 2016

@maiiz Sorry for the confusion: I think the mempool, miner and wallet use this logic, but each have the code copied and this bug can only be found in one of the instances... You can remove the tag altogether from the commit message just to be safe.

@gmaxwell
Copy link
Contributor

utACK

@maflcko
Copy link
Member

maflcko commented Sep 27, 2016

utACK 94a34a5

@laanwj laanwj merged commit 94a34a5 into bitcoin:master Sep 27, 2016
laanwj added a commit that referenced this pull request Sep 27, 2016
94a34a5 Fix relaypriority calculation error (maiiz)
@luke-jr luke-jr mentioned this pull request Oct 25, 2016
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018
94a34a5 Fix relaypriority calculation error (maiiz)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
94a34a5 Fix relaypriority calculation error (maiiz)
@maiiz maiiz deleted the maiiz-patch-1 branch December 16, 2019 08:46
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relaypriority calculation error
5 participants