Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed rpc-tests.sh to rpc-tests.py in README.md #6752

Closed
wants to merge 1 commit into from
Closed

Changed rpc-tests.sh to rpc-tests.py in README.md #6752

wants to merge 1 commit into from

Conversation

ptschip
Copy link
Contributor

@ptschip ptschip commented Oct 3, 2015

No description provided.

@paveljanik
Copy link
Contributor

Is the UTF BOM at the beginning of the file needed?

@ptschip
Copy link
Contributor Author

ptschip commented Oct 3, 2015

i don't know, but i don't see it as related to this pull request...

On 03/10/2015 8:28 AM, paveljanik wrote:

Is the UTF BOM at the beginning of the file needed?

—
Reply to this email directly or view it on GitHub
#6752 (comment).

@paveljanik
Copy link
Contributor

You added it in the commit in this PR, so it is related ;-)
Or maybe your editor added it without you even knowing...

@laanwj laanwj added the Docs label Oct 5, 2015
@laanwj
Copy link
Member

laanwj commented Oct 5, 2015

heh, UTF-8 should not require BOMs

@jonasschnelli
Copy link
Contributor

ACK

laanwj pushed a commit that referenced this pull request Oct 5, 2015
@ptschip @laanwj
Changed rpc-tests.sh to rpc-tests.py in README.md
5f34a25 
Github-Pull: #6752
@laanwj
Copy link
Member

laanwj commented Oct 5, 2015

Merged as 5f34a25 without BOM

@laanwj laanwj closed this Oct 5, 2015
@paveljanik
Copy link
Contributor

BOM in the master:

bitcoin-master pavel$ hexdump -C README.md | head -1
00000000  ef bb bf 42 69 74 63 6f  69 6e 20 43 6f 72 65 20  |...Bitcoin Core |
bitcoin-master pavel$

@laanwj
Copy link
Member

laanwj commented Oct 5, 2015

Yes, editorfail, these things are harder to get rid of than viruses.

Never mind, it's bullshit but I guess it doesn't get in the way of anything.

@maflcko
Copy link
Member

maflcko commented Oct 5, 2015

Let's just append it to the next trivial PR.

@paveljanik
Copy link
Contributor

No problem for me. The diff looked weird in the GitHub PR 8)

@ptschip ptschip deleted the readme branch October 17, 2015 01:30
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ptschip @paveljanik @laanwj @jonasschnelli @maflcko