Bugfix: getmemorypool "bits" should be a hex-string #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly-ACK. I agree that this is "purer," though it makes packing and unpacking more complex. Most people will just convert it back to an integer so they can do the bitshift-trick to decompress it. |
gavinandresen
added a commit
that referenced
this pull request
Oct 9, 2011
Bugfix: getmemorypool "bits" should be a hex-string
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Bugfix: getmemorypool "bits" should be a hex-string
fjahr
pushed a commit
to fjahr/bitcoin
that referenced
this pull request
Jul 24, 2019
Before this commit secp256k1_context_randomize called illegal_callback when called on a context not initialized for signing. This is not documented. Moreover, it is not desirable because non-signing contexts may use randomization in the future. This commit makes secp256k1_context_randomize a noop in this case. This is safe because the context cannot be used for signing anyway. This fixes bitcoin#573 and it fixes rust-bitcoin/rust-secp256k1#82.
fjahr
pushed a commit
to fjahr/bitcoin
that referenced
this pull request
Jul 24, 2019
6198375 Make randomization of a non-signing context a noop (Tim Ruffing) Pull request description: Before this commit secp256k1_context_randomize called illegal_callback when called on a context not initialized for signing. This is not documented. Moreover, it is not desirable because non-signing contexts may use randomization in the future. This commit makes secp256k1_context_randomize a noop in this case. This is safe because the context cannot be used for signing anyway. This fixes bitcoin#573 and it fixes rust-bitcoin/rust-secp256k1#82. Tree-SHA512: 34ddfeb004d9da8f4a77c739fa2110544c28939378e779226da52f410a0e36b3aacb3ebd2e3f3918832a9027684c161789cfdc27a133f2f0e0f1c47e8363029c
kallewoof
pushed a commit
to kallewoof/bitcoin
that referenced
this pull request
Oct 4, 2019
…oS rules d70367b Add broken python serialization to always give issuance input, test for decode failure (Gregory Sanders) 2cb47d1 Disallow coinbase output witness data, since outputs are explicit anyways (Gregory Sanders) 8b2e885 Test for block-blinding by txinwit-overstuffed block (Gregory Sanders) 789d4b9 Disallow output witness data in coinbase transactions (Gregory Sanders) e64324e Test coinbase witness data consensus rules (Gregory Sanders) ac98ca4 python test support for issuance and peg-in serialization and data (Gregory Sanders) 8140a87 Reject unneeded pegin witness by policy (Gregory Sanders) 97356e8 test_framework: Fix CTxInWitness.is_null with pegin_witness (Gregory Sanders) 2309508 feature_fedpeg.py: change sidechain's parent bech32 prefix to match (Gregory Sanders) Pull request description: resolves ElementsProject/elements#530 Tree-SHA512: 89d78bfe512ba573304e0033798ed1de27decfbdbda78ed158ce1ee205e9f57054bb3c53d7e1e8aba9da2b865c33b9852551b0d4cc1c3c807a0b8dbae130ee86
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
Punctuation (missing full stop).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: "bits" should be a hex-string, not a number (that just doesn't make sense)
(suggest waiting for ACK from original getmemorypool author)