Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add historical release notes for 26.0 #29023

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Dec 7, 2023

Bins are now up, used for GH release etc.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 7, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK willcl-ark, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Dec 7, 2023
@willcl-ark
Copy link
Member

We might want to add a release note for -deprecatedrpc=create_bdb as per : #28597 (comment)

@fanquake
Copy link
Member Author

fanquake commented Dec 7, 2023

Hmm. Looks like a few things missed out on being added. Generally we don't change the release notes after they've been finalized, and any updates we make here, wont be reflected on the website, in the 26.x branch, on the mailing list etc, but it might still be worth doing.

doc/release-process.md Outdated Show resolved Hide resolved
@fanquake
Copy link
Member Author

fanquake commented Dec 7, 2023

I've pinged a few people about writing up notes. I'll incorporate them here.

@willcl-ark
Copy link
Member

Here's one for #28507:

Notable changes
===============

Contrib
-------

- Bash completion files have been renamed from `bitcoin*.bash-completion` to
  `bitcoin*.bash`. This means completions can be automatically loaded on demand
  based on invoked commands' names when they are put into the completion
  directory (found with `pkg-config --variable=completionsdir
  bash-completion`) without requiring renaming.

@darosior
Copy link
Member

darosior commented Dec 7, 2023

#28587 rules out usage of hybrid public keys in output descriptors. Hybrid public keys are an exotic public key encoding not supported by output descriptors (as specified in BIP380 and documented in doc/descriptors.md). Bitcoin Core would previously incorrectly accept descriptors containing such hybrid keys. This PR fixed that.

@willcl-ark
Copy link
Member

#28597

Wallet or RPCs?
-------

- The `createwallet` RPC will no longer create legacy (BDB) wallets when
  setting `descriptors=false` without also providing the
  `-deprecatedrpc=create_bdb` option. This is because the legacy wallet is
  being deprecated in a future release.

@fanquake
Copy link
Member Author

fanquake commented Dec 7, 2023

Thanks @willcl-ark & @darosior. I've incorporated those changes in an additional commit, which can also be backported to 26.x in #29011.

@willcl-ark
Copy link
Member

ACK ca59375

fanquake added a commit to fanquake/bitcoincore.org that referenced this pull request Dec 7, 2023
Mirrors what is being done in bitcoin/bitcoin#29023.
Not for merge before that PR.
@achow101
Copy link
Member

achow101 commented Dec 7, 2023

ACK ca59375

@achow101 achow101 merged commit 1d9da8d into bitcoin:master Dec 7, 2023
16 checks passed
achow101 added a commit to bitcoin-core/bitcoincore.org that referenced this pull request Dec 7, 2023
71c08ba 26.0: add missing release note fragments. (fanquake)

Pull request description:

  Mirrors what is being done in bitcoin/bitcoin#29023. Not for merge before that PR.

ACKs for top commit:
  achow101:
    ACK 71c08ba

Tree-SHA512: 7413cc40a3621d21f2db92f289b7d0a4911167c0573da9f5b75f6013eb145124cbe1ff93b47394a04cacc4183767278a01b3569104bb006f6af330891a09006a
@fanquake fanquake deleted the add_26_0_rel_notes branch December 8, 2023 09:03
fanquake added a commit to fanquake/bitcoin that referenced this pull request Dec 8, 2023
fanquake added a commit to fanquake/bitcoin that referenced this pull request Dec 8, 2023
@fanquake fanquake mentioned this pull request Dec 8, 2023
glozow added a commit that referenced this pull request Jan 9, 2024
7b79e54 doc: update release notes for 26.x (fanquake)
ccf00b1 wallet: Fix use-after-free in WalletBatch::EraseRecords (MarcoFalke)
40252e1 ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid failures (Hennadii Stepanov)
b06b14e rpc: getwalletinfo, return wallet 'birthtime' (furszy)
1283401 test: coverage for wallet birth time interaction with -reindex (furszy)
0fa47e2 wallet: fix legacy spkm default birth time (furszy)
84f4a6c wallet: birth time update during tx scanning (furszy)
074296d refactor: rename FirstKeyTimeChanged to MaybeUpdateBirthTime (furszy)
35039ac fuzz: disable BnB when SFFO is enabled (furszy)
903b462 test: add coverage for BnB-SFFO restriction (furszy)
05d0576 wallet: create tx, log resulting coin selection info (furszy)
5493ebb wallet: skip BnB when SFFO is active (Murch)
b15e2e2 test: add regression test for the getrawtransaction segfault (Martin Zumsande)
5097bb3 rpc: fix getrawtransaction segfault (Martin Zumsande)
81e744a ci: Use Ubuntu 24.04 Noble for asan (MarcoFalke)
69e53d1 ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz (MarcoFalke)
d2c80b6 doc: Missing additions to 26.0 release notes (fanquake)
8dc2c75 doc: add historical release notes for 26.0 (fanquake)

Pull request description:

  Backports for `26.x`. Currently:
  * #28920
  * #28992
  * #28994
  * #29003
  * #29023
  * #29080
  * #29176

ACKs for top commit:
  TheCharlatan:
    ACK 7b79e54
  glozow:
    ACK 7b79e54, matches mine

Tree-SHA512: 898aec76ed3ad35e0edd0980af5bcc21bd60003bbf69e0b4f473ed2aa38c4e3b360b930bc3747cf798195906a8f9fe66417524f5e5ef40fa68f1c1aaceebdeb0
@bitcoin bitcoin locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants