-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guix: Update python-lief
package to 0.13.2
#27813
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Guix build:
|
The only requirement to have LIEF 0.13.1 installed, is if you want to run the Python linter, which is not a reason to bump packages in our release environment. Outside of that, I don't think LIEF is used for anything in developer environments. |
"and drops the patch that was upstreamed." |
Guix hashes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK - Given that with LIEF 0.13.1, it looks like the Guix package is going to move to using external deps, rather than the bundled ones (https://lists.gnu.org/archive/html/guix-patches/2023-05/msg01302.html), we probably want to continue using our own package indefinitely, to keep the build simpler, and allow for easier updating.
I also think the PR description needs updating, because LIEF in Guix is not related to developer environments, where LIEF would only be installed for access to type stubs during linting.
I've been testing this PR as part of some other changes.
0.13.2 is now also out: https://github.com/lief-project/LIEF/releases/tag/0.13.2. |
python-lief
package to 0.13.1python-lief
package to 0.13.2
Addressed @fanquake's comments. Removed dependency on
Thanks! Done. |
Guix builds:
|
NACK. Why is that an improvement? |
Ok. Reverted back.
I saw no reasons to use |
Would be better to use Guix upstream's lief if possible. Unbundled deps is better, not worse. If upstream is broken at present, concept ACK for now. |
Guix builds:
|
Guix Build: 018716ffdc0c60b1dfa27f95d1fb4e03d0e37f50cfc325ee35d200039b3f419e guix-build-529c92e837b2/output/aarch64-linux-gnu/SHA256SUMS.part
bb6e74d4806879560e7b6e50bce4b47b383ed5d763e6d25feac64b0c944cc036 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu-debug.tar.gz
2e6fc404211c94bc9a0265a783fabcd3c0bfddb9a87322b612185489ef6264d9 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu.tar.gz
b0f0d9e2e4466cc301c3e96c9d4e4a8b916a18bf1300610b63e6cfae262a3dee guix-build-529c92e837b2/output/arm-linux-gnueabihf/SHA256SUMS.part
e7a81c9b54fc998ed744acac906854c8a0927de04398798393893f8e46cb9a70 guix-build-529c92e837b2/output/arm-linux-gnueabihf/bitcoin-529c92e837b2-arm-linux-gnueabihf-debug.tar.gz
6e12d04f048e809f04748aa0ddb309331084314a06d7983cff27833ec2fc129d guix-build-529c92e837b2/output/arm-linux-gnueabihf/bitcoin-529c92e837b2-arm-linux-gnueabihf.tar.gz
41bbdb3c678c777d001f8e0b4193e332b919ea73a0b601ac909df1acaa747a09 guix-build-529c92e837b2/output/arm64-apple-darwin/SHA256SUMS.part
8878aa364dd091e1e90ec505df9d01813c9944dac828fc659e66ade239e2a872 guix-build-529c92e837b2/output/arm64-apple-darwin/bitcoin-529c92e837b2-arm64-apple-darwin-unsigned.dmg
83ec8b9b06985502711924465a2456403c82c2450195bdb15547ce4c0ba98c0c guix-build-529c92e837b2/output/arm64-apple-darwin/bitcoin-529c92e837b2-arm64-apple-darwin-unsigned.tar.gz
05f1400892ad82c8619bfbb4bd492f22c20a8b6de89d1315925502d3e6e29d01 guix-build-529c92e837b2/output/arm64-apple-darwin/bitcoin-529c92e837b2-arm64-apple-darwin.tar.gz
85bb1b32ccdd0b3dc05079b72db7b2f11098098458f4e54f75e0f8738ba2648b guix-build-529c92e837b2/output/dist-archive/bitcoin-529c92e837b2.tar.gz
ca44eaeafc0b8e8df455afc18a5b7006e3826c602ebdc50bd7e2bba1a40cd48f guix-build-529c92e837b2/output/powerpc64-linux-gnu/SHA256SUMS.part
37f8b3b4822cbd2b47ca9b3dbe070f1bde70c47876d03dfa0158357e72685b2d guix-build-529c92e837b2/output/powerpc64-linux-gnu/bitcoin-529c92e837b2-powerpc64-linux-gnu-debug.tar.gz
289d8db2e12f5c4d7627b1739e55efba76e87f0cdb3605de9f533eaade641ca7 guix-build-529c92e837b2/output/powerpc64-linux-gnu/bitcoin-529c92e837b2-powerpc64-linux-gnu.tar.gz
43ea0c5bfdb79482cd308d34f41b1597abae8cc08e1430a7340ff466a34743e7 guix-build-529c92e837b2/output/powerpc64le-linux-gnu/SHA256SUMS.part
9537a4eb031f6d486c5db9aa0de68c6a5969ff53186efa7248394dcc88a7098c guix-build-529c92e837b2/output/powerpc64le-linux-gnu/bitcoin-529c92e837b2-powerpc64le-linux-gnu-debug.tar.gz
08a7596b710cb8a2009778adf25471e7e9cc0e9c577cc91694bc237e34dd7552 guix-build-529c92e837b2/output/powerpc64le-linux-gnu/bitcoin-529c92e837b2-powerpc64le-linux-gnu.tar.gz
680401083fa241110f08fb5224a49b20c21861a51d2e326d777234a7082350e5 guix-build-529c92e837b2/output/riscv64-linux-gnu/SHA256SUMS.part
364eb0b4960b1cac1430d2bcbe9f354c7d0457209d8022a9e164689b8adc1e65 guix-build-529c92e837b2/output/riscv64-linux-gnu/bitcoin-529c92e837b2-riscv64-linux-gnu-debug.tar.gz
36d5dffca5602ec1b1a4de61ff95f8970724575fbcbb40159f1c34638e42392b guix-build-529c92e837b2/output/riscv64-linux-gnu/bitcoin-529c92e837b2-riscv64-linux-gnu.tar.gz
1474b9d4a377344a17a8c19958d7eaea482e42f1c083c8a6110a8c82815fed7b guix-build-529c92e837b2/output/x86_64-apple-darwin/SHA256SUMS.part
6db103ff5f0a47f9b2ee70976b08e9f521704cfc6733300686988c72efb08ca5 guix-build-529c92e837b2/output/x86_64-apple-darwin/bitcoin-529c92e837b2-x86_64-apple-darwin-unsigned.dmg
c8d7c3f38fbbd770c4e3f950914fab0567fd116a6399c6b6ed25f7428bdcf48a guix-build-529c92e837b2/output/x86_64-apple-darwin/bitcoin-529c92e837b2-x86_64-apple-darwin-unsigned.tar.gz
e385cf8740be4ea5916809547beff7b91682b2488ea6aea689ce65f68650c94a guix-build-529c92e837b2/output/x86_64-apple-darwin/bitcoin-529c92e837b2-x86_64-apple-darwin.tar.gz
b3998a9d1cb6cfd463b1f23800d49d7a97e8108335be22661df22e7531c8a220 guix-build-529c92e837b2/output/x86_64-linux-gnu/SHA256SUMS.part
48177acf4a31c1edd25b2783fe60b49d903890aa04225dd5ed7e96390728584d guix-build-529c92e837b2/output/x86_64-linux-gnu/bitcoin-529c92e837b2-x86_64-linux-gnu-debug.tar.gz
53f5873bbbd6b39a9dfbf77765a28b1f34b402d53999498aee6ae405e81acdf4 guix-build-529c92e837b2/output/x86_64-linux-gnu/bitcoin-529c92e837b2-x86_64-linux-gnu.tar.gz
b97ade8531d51582747c0f5c5ef129d2cecd2d2cfcdcddfe0aec5754c63fcf2b guix-build-529c92e837b2/output/x86_64-w64-mingw32/SHA256SUMS.part
8a12efc03fb02be9285795b50624621d7935c71f85c23116e903108de0536943 guix-build-529c92e837b2/output/x86_64-w64-mingw32/bitcoin-529c92e837b2-win64-debug.zip
3eab525239e6fd95477938fb819da77941e7fd3762e25f72b2c149e0146a6d7e guix-build-529c92e837b2/output/x86_64-w64-mingw32/bitcoin-529c92e837b2-win64-setup-unsigned.exe
4e0eb66abcb5d155f3e68a5abf292bb55b52851d71dc826e5cb48d018143bc9b guix-build-529c92e837b2/output/x86_64-w64-mingw32/bitcoin-529c92e837b2-win64-unsigned.tar.gz
d9f3cd5e83756fc3bb6c2d94472331e137ca67ce7e47988d1b3190d9a2b8a241 guix-build-529c92e837b2/output/x86_64-w64-mingw32/bitcoin-529c92e837b2-win64.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 529c92e
529c92e guix: Update `python-lief` package to 0.13.2 (Hennadii Stepanov) Pull request description: The Guix's `python-lief` package is going to move to using external deps, rather than the bundled ones (https://lists.gnu.org/archive/html/guix-patches/2023-05/msg01302.html). We want to continue using our own package indefinitely, to keep the build simpler, and allow for easier updating. Changes in `contrib/devtools/security-check.py` are caused by lief-project/LIEF@6357c63. Also see: bitcoin#27507. ACKs for top commit: fanquake: ACK 529c92e Tree-SHA512: ad81111b090a39b380fe25bb27b54a339e78a158f462c7adda25d5ee55f0d654107b1486b29b9687ad0808e27b01e04f53a0e8ffc6600b79103d6bd0dfec64ef
Summary: Updates to version 0.13.2. The Guix's python-lief package is going to move to using external deps, rather than the bundled ones (https://lists.gnu.org/archive/html/guix-patches/2023-05/msg01302.html). We want to continue using our own package indefinitely, to keep the build simpler, and allow for easier updating. This is a backport of [[bitcoin/bitcoin#27296 | core#27296]] and [[bitcoin/bitcoin#27813 | core#27813]] Depends on D15326 Test Plan: `contrib/guix/guix-build` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D15327
The Guix's
python-lief
package is going to move to using external deps, rather than the bundled ones (https://lists.gnu.org/archive/html/guix-patches/2023-05/msg01302.html). We want to continue using our own package indefinitely, to keep the build simpler, and allow for easier updating.Changes in
contrib/devtools/security-check.py
are caused by lief-project/LIEF@6357c63.Also see: #27507.