doc: various developer notes updates #25092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
along with a few miscellaneous touch-ups.
laanwj
reviewed
May 9, 2022
|
Looks good to me. |
jonatack
force-pushed
the
developer-notes-updates-may-2022
branch
from
968a67b to
91d6d4a
Compare
w0xlt
approved these changes
May 9, 2022
laanwj
reviewed
May 10, 2022
laanwj
reviewed
May 10, 2022
jonatack
force-pushed
the
developer-notes-updates-may-2022
branch
from
91d6d4a to
8d9ca1f
Compare
laanwj
reviewed
May 10, 2022
Credit for some parts to the Google C++ Style Guide "Inputs and Outputs" section at https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs Co-authored-by: laanwj <126646+laanwj@users.noreply.github.com>
jonatack
force-pushed
the
developer-notes-updates-may-2022
branch
from
8d9ca1f to
e66b321
Compare
|
ACK 6542842 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
6542842 Add clang lifetimebound section to developer notes (Jon Atack) e66b321 Add C++ functions and methods section to developer notes (Jon Atack) 5fca70f Link in developer notes style to internal interface exception (Jon Atack) fc4cb85 Prefer Python for scripts in developer notes (Jon Atack) 370120e Remove obsolete BDB ENABLE_WALLET section in developer notes (Jon Atack) Pull request description: A few updates noticed while working on a lifetimebound section. - Remove obsolete BDB ENABLE_WALLET section (only one file, src/wallet/bdb.h, still has a `db_cxx.h` BDB header) - Prefer Python for scripts in developer notes (and a few miscellaneous touch-ups) - In the code style section, add a link to the internal interface exception so that people are aware of it - Add a "C++ functions and methods" section - Add a Clang `lifetimebound` attribute section ACKs for top commit: laanwj: ACK 6542842 jarolrod: code review ACK bitcoin@6542842 Tree-SHA512: d2ae335cac899451d5c7bdc8e94fd82053a5f44ac1ba444bdde71abaaa24a519713c1078f3a8f07ec8466b181788a613fd3c68061e54b3fdc8cd6f3e3f9791ec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates noticed while working on a lifetimebound section.
db_cxx.hBDB header)lifetimeboundattribute section