build: header-only Boost #24301

fanquake · 2022-02-09T18:28:16Z

This PR converts our Boost usage to header only. We switch from using our last remaining Boost lib (unit test), to using it's header-only implementation (see https://www.boost.org/doc/libs/1_78_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html).

Also related to #24291.

Guix build:

maflcko · 2022-02-09T18:33:45Z

Didn't know that boost unit test is also header-only.

Concept ACK, I guess 🚀

hebasto · 2022-02-09T18:37:58Z

Concept ACK.

maflcko · 2022-02-09T18:41:00Z

Does this bump the minimum req. boost version?

laanwj · 2022-02-09T19:44:53Z

Concept ACK, this is a nice cleanup to configure.ac.

laanwj · 2022-02-09T19:46:05Z

depends/packages/boost.mk


 define $(package)_stage_cmds
-  b2 -d0 -j4 --prefix=$($(package)_staging_prefix_dir) $($(package)_config_opts) toolset=$($(package)_toolset_$(host_os)) --no-cmake-config install
+  mkdir -p $($(package)_staging_prefix_dir)/include && \
+  cp -r boost $($(package)_staging_prefix_dir)/include


configure.ac

fanquake · 2022-02-09T21:30:46Z

Updated to fix the linter, added a commit to use Boost 1.78.0, and removed the Boost Unit Test macro.

Does this bump the minimum req. boost version?

I'll need to double check this.

TSAN failure from previous change:

==================
WARNING: ThreadSanitizer: data race (pid=90566)
  Read of size 4 at 0x7fcbd5a62f40 by thread T4 (mutexes: write M1909):
    #0 std::__1::ios_base::flags() const /usr/lib/llvm-13/bin/../include/c++/v1/ios:461:12 (test_bitcoin+0x2192b8)
    #1 std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::__put_character_sequence<char, std::__1::char_traits<char> >(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, char const*, unsigned long) /usr/lib/llvm-13/bin/../include/c++/v1/ostream:720:40 (test_bitcoin+0x2192b8)
    #2 std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::operator<<<char, std::__1::char_traits<char>, std::__1::allocator<char> >(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/ostream:1041:12 (test_bitcoin+0x1d94d7)
    #3 $_0::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const src/test/main.cpp:28:15 (test_bitcoin+0x1d94d7)
    #4 decltype(static_cast<$_0&>(fp)(static_cast<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>(fp0))) std::__1::__invoke<$_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>($_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x1d94d7)
    #5 void std::__1::__invoke_void_return_wrapper<void, true>::__call<$_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>($_0&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x1d94d7)
    #6 std::__1::__function::__alloc_func<$_0, std::__1::allocator<$_0>, void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x1d94d7)
    #7 std::__1::__function::__func<$_0, std::__1::allocator<$_0>, void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x1d94d7)
    #8 std::__1::__function::__value_func<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe8104b)
    #9 std::__1::function<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe8104b)
    #10 BCLog::Logger::LogPrintStr(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) src/logging.cpp:279:9 (test_bitcoin+0xe8104b)
    #11 void LogPrintf_<char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, char const*, char const* const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) src/./logging.h:184:23 (test_bitcoin+0xd7ec50)
    #12 CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7::operator()() const src/validationinterface.cpp:215:5 (test_bitcoin+0xd84022)
    #13 decltype(static_cast<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(fp)()) std::__1::__invoke<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xd84022)
    #14 void std::__1::__invoke_void_return_wrapper<void, true>::__call<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&>(CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0xd84022)
    #15 std::__1::__function::__alloc_func<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7, std::__1::allocator<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0xd84022)
    #16 std::__1::__function::__func<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7, std::__1::allocator<CMainSignals::TransactionRemovedFromMempool(std::__1::shared_ptr<CTransaction const> const&, MemPoolRemovalReason, unsigned long)::$_7>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0xd84022)
    #17 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe2a2b1)
    #18 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe2a2b1)
    #19 SingleThreadedSchedulerClient::ProcessQueue() src/scheduler.cpp:177:5 (test_bitcoin+0xe2a2b1)
    #20 decltype(*(static_cast<SingleThreadedSchedulerClient*&>(fp0)).*fp()) std::__1::__invoke<void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&, void>(void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3859:1 (test_bitcoin+0xe2c7ea)
    #21 std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, 0ul, std::__1::tuple<> >(void (SingleThreadedSchedulerClient::*&)(), std::__1::tuple<SingleThreadedSchedulerClient*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/bind.h:257:12 (test_bitcoin+0xe2c7ea)
    #22 std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>::operator()<>() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/bind.h:292:20 (test_bitcoin+0xe2c7ea)
    #23 decltype(static_cast<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(fp)()) std::__1::__invoke<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xe2c7ea)
    #24 void std::__1::__invoke_void_return_wrapper<void, true>::__call<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0xe2c7ea)
    #25 std::__1::__function::__alloc_func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0xe2c7ea)
    #26 std::__1::__function::__func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0xe2c7ea)
    #27 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xe292bc)
    #28 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xe292bc)
    #29 CScheduler::serviceQueue() src/scheduler.cpp:64:17 (test_bitcoin+0xe292bc)
    #30 ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0::operator()() const src/test/util/setup_common.cpp:156:110 (test_bitcoin+0x9bdaa8)
    #31 decltype(static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(fp)()) std::__1::__invoke<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x9bdaa8)
    #32 void std::__1::__invoke_void_return_wrapper<void, true>::__call<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x9bdaa8)
    #33 std::__1::__function::__alloc_func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x9bdaa8)
    #34 std::__1::__function::__func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x9bdaa8)
    #35 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0xebff6f)
    #36 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0xebff6f)
    #37 util::TraceThread(char const*, std::__1::function<void ()>) src/util/thread.cpp:18:9 (test_bitcoin+0xebff6f)
    #38 decltype(static_cast<void (*>(fp)(static_cast<char const*>(fp0), static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(fp0))) std::__1::__invoke<void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(void (*&&)(char const*, std::__1::function<void ()>), char const*&&, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x9bd6a1)
    #39 void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, 2ul, 3ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>&, std::__1::__tuple_indices<2ul, 3ul>) /usr/lib/llvm-13/bin/../include/c++/v1/thread:280:5 (test_bitcoin+0x9bd6a1)
    #40 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0> >(void*) /usr/lib/llvm-13/bin/../include/c++/v1/thread:291:5 (test_bitcoin+0x9bd6a1)

theuni · 2022-02-09T22:03:01Z

Nice! Concept ACK.

maflcko · 2022-02-10T07:41:27Z

TSAN failure from previous change:

I haven't checked in detail, but this looks like a known bug. Maybe adjust the suppressions for now?

fanquake · 2022-02-10T07:58:28Z

Added a suppression, removed a suppression, pruned out BOOST_LIBS.

fanquake · 2022-02-10T10:59:11Z

Removed the Boost bump (no need to do that here, and it may have other issues), and have marked this as ready for review. The failure in the ARM CI looks unrelated. Updated the PR description as well.

Sjors · 2022-02-10T18:23:52Z

Nice!

Tested 52bc718 on macOS 12.2 with and without depends... (Boost 1.76.0, glad we don't need 1.78 since it's not on Homebrew yet #91224). Still compiles and tests seem happy.

maflcko · 2022-02-10T19:03:36Z

The docs were put up in 1.69: https://www.boost.org/doc/libs/1_69_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html

Our minimum is 1.64

Bionic has 1.65: https://packages.ubuntu.com/bionic/libboost-dev

Bionic seems to pass with CXX='clang++-8 -stdlib=libc++' CC=clang-8 ./configure --disable-wallet --disable-external-signer && make -j $(nproc) on this pull. So I guess this doesn't change the minimum required.

DrahtBot · 2022-02-11T12:13:08Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24322 ([kernel 1/n] Introduce initial libbitcoinkernel by dongcarl)
#23955 (build: add support for NetBSD in depends by fanquake)
#23340 (build: upgrade to boost 1.77 to fix c++20 compilation by PastaPastaPasta)
#23203 ([POC] build: static musl libc based bitcoind (with LTO) by fanquake)
#22380 (build: add and use C_STANDARD and CXX_STANDARD in depends by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2022-02-11T15:08:53Z

So I guess this doesn't change the minimum required.

Thanks for taking a look.

Guix build added to PR description.

theStack · 2022-02-11T19:08:42Z

Concept ACK

sipa · 2022-02-11T19:09:52Z

Concept ACK!

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

…7301) * bitcoin-core: remove no-longer needed Boost CXXFLAGS Since bitcoin/bitcoin#24301 our Boost usage is header-only. * bitcoin-core: enable sqlite in our dependency builder

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

Something similar was initially suggested in bitcoin#24301.

fanquake added the Build system label Feb 9, 2022

laanwj reviewed Feb 9, 2022

View reviewed changes

configure.ac Show resolved Hide resolved

laanwj mentioned this pull request Feb 9, 2022

build: Remove negated --enable-fuzz checks from build system #24291

Merged

fanquake force-pushed the boost_test_header_only branch from 9c0cf03 to 00a4757 Compare February 9, 2022 21:28

fanquake force-pushed the boost_test_header_only branch from 00a4757 to c83e659 Compare February 10, 2022 07:54

fanquake force-pushed the boost_test_header_only branch from c83e659 to 52bc718 Compare February 10, 2022 08:37

fanquake changed the title ~~[POC] build: header-only Boost~~ build: header-only Boost Feb 10, 2022

fanquake marked this pull request as ready for review February 10, 2022 10:57

DrahtBot mentioned this pull request Feb 11, 2022

[kernel 0/n] Introduce bitcoin-chainstate #24304

Merged

fanquake force-pushed the boost_test_header_only branch from 52bc718 to 8a74edb Compare February 11, 2022 21:25

This was referenced Feb 12, 2022

build: support OpenBSD in depends #23998

Merged

build: add support for NetBSD in depends #23955

Merged

maflcko added the DrahtBot Guix build requested label Feb 12, 2022

DrahtBot mentioned this pull request Feb 12, 2022

build: upgrade to boost 1.77 to fix c++20 compilation #23340

Closed

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

0255ef5

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

b59af8b

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

0d7e3cc

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

2116d57

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

e4c20db

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

44e3a47

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

d76a392

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

f121d92

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

245a455

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 8, 2022

build: only copy used Boost headers in depends

8b06e01

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 9, 2022

build: only copy used Boost headers in depends

b58baa4

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 26, 2022

build: only copy used Boost headers in depends

a6125d1

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request May 19, 2022

build: only copy used Boost headers in depends

6078c1c

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 1, 2022

build: only copy used Boost headers in depends

cc31190

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 10, 2022

build: only copy used Boost headers in depends

40e2cd3

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Jul 5, 2022

build: only copy used Boost headers in depends

987e3e7

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Jul 17, 2022

build: only copy used Boost headers in depends

8a5cfc0

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 1, 2022

build: only copy used Boost headers in depends

9e41207

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 13, 2022

build: only copy used Boost headers in depends

749fea2

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 16, 2022

build: only copy used Boost headers in depends

9e02f96

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

fanquake added a commit to fanquake/bitcoin that referenced this pull request Aug 23, 2022

build: only copy used Boost headers in depends

ac8a2c9

Something similar was initially suggested in bitcoin#24301. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

hebasto mentioned this pull request Sep 2, 2022

test, build: Separate read_json function into its own module #25974

Merged

fanquake added a commit to fanquake/bitcoin that referenced this pull request Sep 21, 2022

build: only copy used Boost headers in depends

456c016

Something similar was initially suggested in bitcoin#24301.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Sep 21, 2022

build: only copy used Boost headers in depends

23b379e

Something similar was initially suggested in bitcoin#24301.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 30, 2022

build: only copy used Boost headers in depends

cf80289

Something similar was initially suggested in bitcoin#24301.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Dec 8, 2022

build: only copy used Boost headers in depends

0d02524

Something similar was initially suggested in bitcoin#24301.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Jan 13, 2023

build: only copy used Boost headers in depends

800a4e9

Something similar was initially suggested in bitcoin#24301.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Feb 2, 2023

build: only copy used Boost headers in depends

c08c0a7

Something similar was initially suggested in bitcoin#24301.

bitcoin locked and limited conversation to collaborators Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: header-only Boost #24301

build: header-only Boost #24301

fanquake commented Feb 9, 2022 •

edited

Loading

maflcko commented Feb 9, 2022

hebasto commented Feb 9, 2022

maflcko commented Feb 9, 2022

laanwj commented Feb 9, 2022

laanwj Feb 9, 2022

fanquake commented Feb 9, 2022

theuni commented Feb 9, 2022

maflcko commented Feb 10, 2022

fanquake commented Feb 10, 2022

fanquake commented Feb 10, 2022

Sjors commented Feb 10, 2022 •

edited

Loading

maflcko commented Feb 10, 2022

DrahtBot commented Feb 11, 2022 •

edited

Loading

fanquake commented Feb 11, 2022

theStack commented Feb 11, 2022

sipa commented Feb 11, 2022

build: header-only Boost #24301

build: header-only Boost #24301

Conversation

fanquake commented Feb 9, 2022 • edited Loading

maflcko commented Feb 9, 2022

hebasto commented Feb 9, 2022

maflcko commented Feb 9, 2022

laanwj commented Feb 9, 2022

laanwj Feb 9, 2022

Choose a reason for hiding this comment

fanquake commented Feb 9, 2022

theuni commented Feb 9, 2022

maflcko commented Feb 10, 2022

fanquake commented Feb 10, 2022

fanquake commented Feb 10, 2022

Sjors commented Feb 10, 2022 • edited Loading

maflcko commented Feb 10, 2022

DrahtBot commented Feb 11, 2022 • edited Loading

Conflicts

fanquake commented Feb 11, 2022

theStack commented Feb 11, 2022

sipa commented Feb 11, 2022

fanquake commented Feb 9, 2022 •

edited

Loading

Sjors commented Feb 10, 2022 •

edited

Loading

DrahtBot commented Feb 11, 2022 •

edited

Loading