Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build, qt: Fix typo in QtInputSupport check #22820

Merged
merged 1 commit into from
Aug 28, 2021
Merged

build, qt: Fix typo in QtInputSupport check #22820

merged 1 commit into from
Aug 28, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 27, 2021

This typo slipped in fecb372 (#21565).

I apologize for that as a reviewer of #21565.

@hebasto hebasto requested a review from fanquake August 27, 2021 15:00
@fanquake
Copy link
Member

Guix builds:

a81b862851d2a6c4cbaea50d5513cd0c73f2f420f7b06bd57725e74d79dc11df  guix-build-e251726affe9/output/aarch64-linux-gnu/SHA256SUMS.part
778efb1df1b48e7abfdb01257f864631e2d3ecc7974684d317bb06e640a4e126  guix-build-e251726affe9/output/aarch64-linux-gnu/bitcoin-e251726affe9-aarch64-linux-gnu-debug.tar.gz
584c335e9b114ddb52cbf39323d12d24f94227463d4024c2c9dcc31494842e12  guix-build-e251726affe9/output/aarch64-linux-gnu/bitcoin-e251726affe9-aarch64-linux-gnu.tar.gz
d4e61d4f4714b44d60c224f98ae06ad4f2dac58c935c479b8f0e5dfa9a1db7b2  guix-build-e251726affe9/output/arm-linux-gnueabihf/SHA256SUMS.part
e8f6083f41df3f8f02e9adb5d2e045301fa2d06c531d6c8e5a20227bca4c6282  guix-build-e251726affe9/output/arm-linux-gnueabihf/bitcoin-e251726affe9-arm-linux-gnueabihf-debug.tar.gz
6a59f8cddc25e81ca9255142c9daaf1c0e403d0f913b699062adec5f7719a95f  guix-build-e251726affe9/output/arm-linux-gnueabihf/bitcoin-e251726affe9-arm-linux-gnueabihf.tar.gz
2dcc19a7e4ff1c82293128ed9b01f4846a85f49598f51a773a64da20067431f2  guix-build-e251726affe9/output/dist-archive/bitcoin-e251726affe9.tar.gz
838d607ebb4d89a5669a4836691c87dd043249ef303cc02ba10dad5fe010a692  guix-build-e251726affe9/output/powerpc64-linux-gnu/SHA256SUMS.part
4c1544374f7330dc345502ec286f0ca4ba309f4454824842379794f4aff7e5d5  guix-build-e251726affe9/output/powerpc64-linux-gnu/bitcoin-e251726affe9-powerpc64-linux-gnu-debug.tar.gz
7cbaa7670a11d86c60a44721f5d1cc17715a6c83f3c4d25386f514fe5236e72e  guix-build-e251726affe9/output/powerpc64-linux-gnu/bitcoin-e251726affe9-powerpc64-linux-gnu.tar.gz
0045c40af8cdbf29c6e05dcf743c0d8f3ae0427f905a4d3fad6b653c87f098cc  guix-build-e251726affe9/output/powerpc64le-linux-gnu/SHA256SUMS.part
793ad9abbe1c125a5d14ad5c27d479a88f317963a20b5c67281a308a7ba1cde0  guix-build-e251726affe9/output/powerpc64le-linux-gnu/bitcoin-e251726affe9-powerpc64le-linux-gnu-debug.tar.gz
341f9c7811ee940aad4b7be0fa1281dda9c5c0ca855d69648f945f72702519cf  guix-build-e251726affe9/output/powerpc64le-linux-gnu/bitcoin-e251726affe9-powerpc64le-linux-gnu.tar.gz
cfb7fb4a540108df28ab1a8d9f74fa04fc581223fbe4f47db3060387eceb603a  guix-build-e251726affe9/output/riscv64-linux-gnu/SHA256SUMS.part
fd8dea24ed1c9da2898dbbefb672599757705936dcc346e8cf12bb4d1ce61617  guix-build-e251726affe9/output/riscv64-linux-gnu/bitcoin-e251726affe9-riscv64-linux-gnu-debug.tar.gz
2dae9a9b40dbf54dc1d1be494d14d4da03d34fa80691279125fdcf4d83a7f84d  guix-build-e251726affe9/output/riscv64-linux-gnu/bitcoin-e251726affe9-riscv64-linux-gnu.tar.gz
d114492877d2bcb4f80c42f8c100d1775c59f27626d9bd15e5e4da449ae3cc2d  guix-build-e251726affe9/output/x86_64-apple-darwin18/SHA256SUMS.part
116317849d89d2bc94008fd9c5b5a60ced7c4081bb37a6bb72b9c354ec30c4e2  guix-build-e251726affe9/output/x86_64-apple-darwin18/bitcoin-e251726affe9-osx-unsigned.dmg
c663d8d4ef6d654129b4f101fce905b6d33dad6747c6e9a4c54fbb80578230f4  guix-build-e251726affe9/output/x86_64-apple-darwin18/bitcoin-e251726affe9-osx-unsigned.tar.gz
a729a4fb3f3457e89a9736fb7fc725a4c375437553bad881efbb923f411db541  guix-build-e251726affe9/output/x86_64-apple-darwin18/bitcoin-e251726affe9-osx64.tar.gz
b250c0aa78d3786b8b4ee6472856137700ff82964b8a5210183d6ded58c73ebb  guix-build-e251726affe9/output/x86_64-linux-gnu/SHA256SUMS.part
9bec3a9a7841ab874b39117d102331a1441efb927a77a7dc55730621e10788a7  guix-build-e251726affe9/output/x86_64-linux-gnu/bitcoin-e251726affe9-x86_64-linux-gnu-debug.tar.gz
5641672e31aa50ef36eb80ed0feb2a3a8724e0bb8df946ddc598a4f21ea01513  guix-build-e251726affe9/output/x86_64-linux-gnu/bitcoin-e251726affe9-x86_64-linux-gnu.tar.gz
895a715c3c57ff7a2f301c8fa30aef61873c0901ea3530a1ef7eef36c0e885ff  guix-build-e251726affe9/output/x86_64-w64-mingw32/SHA256SUMS.part
76843ae9e2b22b0eb79ee48658e9bb565176ea307685b9a1c25ac088f1c3d6df  guix-build-e251726affe9/output/x86_64-w64-mingw32/bitcoin-e251726affe9-win-unsigned.tar.gz
a0c914e7f3c129a1b074b535d0c6977e82ca4c202220526d97e68e59c027f980  guix-build-e251726affe9/output/x86_64-w64-mingw32/bitcoin-e251726affe9-win64-debug.zip
92ef452f9a8e36c3bff7e726057a92b115d8f852f33cbce98c71177894c773e4  guix-build-e251726affe9/output/x86_64-w64-mingw32/bitcoin-e251726affe9-win64-setup-unsigned.exe
7bd538388e5104ebcd3a27c2b0595a65a84576479ac5588a93f0c70e0275d5ad  guix-build-e251726affe9/output/x86_64-w64-mingw32/bitcoin-e251726affe9-win64.zip

fanquake
fanquake approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e251726

@fanquake fanquake merged commit 83daf47 into bitcoin:master Aug 28, 2021
@hebasto hebasto deleted the 210827-input branch August 28, 2021 09:14
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 28, 2021
@fanquake
Merge bitcoin#22820: build, qt: Fix typo in QtInputSupport check
cb0da94 
e251726 build, qt: Fix typo in QtInputSupport check (Hennadii Stepanov)

Pull request description:

  This typo slipped in fecb372 (bitcoin#21565).

  I apologize for that as a reviewer of bitcoin#21565.

ACKs for top commit:
  fanquake:
    ACK e251726

Tree-SHA512: c14d603ed5a9b7e4b6503bfb93e66b800d5a107f21a8375c6f98465ef937e3e55b9c4fc160407c7e3ee402b495c5820ebb35ec6cb92956c1ee4092415635b915
@barton2526 barton2526 mentioned this pull request Aug 30, 2021
Merged
luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Oct 10, 2021
@hebasto @luke-jr
build, qt: Fix typo in QtInputSupport check
b89de53 
Github-Pull: bitcoin#22820
Rebased-From: e251726
@luke-jr luke-jr mentioned this pull request Oct 16, 2021
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 20, 2021
@hebasto @fanquake
build, qt: Fix typo in QtInputSupport check
62e0b6c 
Github-Pull: bitcoin#22820
Rebased-From: e251726
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 21, 2021
@hebasto @fanquake
build, qt: Fix typo in QtInputSupport check
fa6917f 
Github-Pull: bitcoin#22820
Rebased-From: e251726
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 14, 2022
@hebasto @fanquake
build, qt: Fix typo in QtInputSupport check
2ac41fd 
Github-Pull: bitcoin#22820
Rebased-From: e251726
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Feb 15, 2022
@hebasto @fanquake
build, qt: Fix typo in QtInputSupport check
a5a1538 
Github-Pull: bitcoin#22820
Rebased-From: e251726
fanquake added a commit that referenced this pull request Mar 1, 2022
@fanquake
Merge #23276: [22.x] Backports for 22.x
9b5f674 
269553f test: Call ceildiv helper with integer (Martin Zumsande)
2f60fc6 ci: Replace soon EOL hirsute with jammy (MarcoFalke)
801b0f0 build: patch qt to explicitly define previously implicit header include (Kittywhiskers Van Gogh)
c768bfa tests: Calculate fees more similarly to CFeeRate::GetFee (Andrew Chow)
f66bc42 tests: Test for assertion when feerate is rounded down (Andrew Chow)
bd7e08e fees: Always round up fee calculated from a feerate (Andrew Chow)
227ae65 wallet: fix segfault by avoiding invalid default-ctored `external_spk_managers` entry (Sebastian Falbesoner)
282863a refactor: include a missing <limits> header in fs.cpp (Joan Karadimov)
7febe4f consensus: don't call GetBlockPos in ReadBlockFromDisk without lock (Jon Atack)
c671c6f the result of CWallet::IsHDEnabled() was initialized with true. (Saibato)
a5a1538 build, qt: Fix typo in QtInputSupport check (Hennadii Stepanov)
c95b188 system: skip trying to set the locale on NetBSD (fanquake)
c1cdedd guix: Fix powerpc64(le) dynamic linker name (Carl Dong)
92d44ff doc: Add 23061 release notes (MarcoFalke)
db76db7 Fix (inverse) meaning of -persistmempool (MarcoFalke)
85c78e0 build: Restrict check for CRC32C intrinsic to aarch64 (W. J. van der Laan)

Pull request description:

  Collecting backports for the 22.1 release. Currently:
  * #23045
  * #23061
  * #23148
  * #22390
  * #22820
  * #22781
  * #22895
  * #23335
  * #23333
  * #22949
  * #23580
  * #23504
  * #24239

ACKs for top commit:
  achow101:
    ACK 269553f

Tree-SHA512: b3a57ea241be7a83488eeb032276f4cf82a0987aada906a82f94a20c4acf9f2397708249dcecbe1c7575e70d09c60b835233d4718af4013c7bc58896c618274c
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 28, 2022
@fanquake @PastaPastaPasta
Merge bitcoin#22820: build, qt: Fix typo in QtInputSupport check
0a1a882 
e251726 build, qt: Fix typo in QtInputSupport check (Hennadii Stepanov)

Pull request description:

  This typo slipped in fecb372 (bitcoin#21565).

  I apologize for that as a reviewer of bitcoin#21565.

ACKs for top commit:
  fanquake:
    ACK e251726

Tree-SHA512: c14d603ed5a9b7e4b6503bfb93e66b800d5a107f21a8375c6f98465ef937e3e55b9c4fc160407c7e3ee402b495c5820ebb35ec6cb92956c1ee4092415635b915
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 28, 2022
@fanquake @PastaPastaPasta
Merge bitcoin#22820: build, qt: Fix typo in QtInputSupport check
ce1ab9e 
e251726 build, qt: Fix typo in QtInputSupport check (Hennadii Stepanov)

Pull request description:

  This typo slipped in fecb372 (bitcoin#21565).

  I apologize for that as a reviewer of bitcoin#21565.

ACKs for top commit:
  fanquake:
    ACK e251726

Tree-SHA512: c14d603ed5a9b7e4b6503bfb93e66b800d5a107f21a8375c6f98465ef937e3e55b9c4fc160407c7e3ee402b495c5820ebb35ec6cb92956c1ee4092415635b915
@reddink reddink mentioned this pull request May 26, 2022
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @fanquake @maflcko