Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hasher cleanup (follow-up to 19935) #22772

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

mzumsande
Copy link
Contributor

Small follow-ups to #19935:

  • Removal of unused KeyIDHasher class (comment in 19935)
  • Removal of an outdated comment, which referred to an old problem with the no longer supported Boost 1.46 and boost::unordered_map, now replaced by std::unordered_map. (comment in 19935)

No longer relevant because Boost 1.46 is no longer supported and
std::unordered_map is used instead of boost::unordered_map in CCoinsMap.
Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c69571

LGTM, agree, no need keeping the unused KeyIDHasher (esp. after 281fd1a) and the out of date comment in src/util/hasher.h.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4c69571 🆗

Verified via git grep KeyIDHasher that the removed class is indeed not used anywhere and also checked that the comment is outdated.

@Saviour1001
Copy link

Tested ACK 4c69571

@fanquake fanquake merged commit b20ad0e into bitcoin:master Aug 24, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 24, 2021
4c69571 doc: remove outdated comment (Martin Zumsande)
16652a9 refactor: Remove unused KeyIDHasher (Martin Zumsande)

Pull request description:

  Small follow-ups to  bitcoin#19935:

  - Removal of unused `KeyIDHasher`  class ([comment in 19935](bitcoin#19935 (comment)))
  - Removal of an outdated comment, which referred to an old problem with the no longer supported Boost 1.46 and `boost::unordered_map`, now replaced by `std::unordered_map`. ([comment in 19935](bitcoin#19935 (comment)))

ACKs for top commit:
  Saviour1001:
    Tested ACK <code>[4c69571](https://github.com/bitcoin/bitcoin/commit/4c69571e6eeae2c03d59045ea102baa5fd1c3816)</code>
  Zero-1729:
    ACK 4c69571
  theStack:
    ACK 4c69571 🆗

Tree-SHA512: 243fda2120bfac6c40a268ca2c0f34482ce27e71fbc50005c0d13c2ad5db9ee72a037f9937c37cc50ed0f9f6f11ee6afee4ac50e5031d6876ec942f41f38dadf
@mzumsande mzumsande deleted the 202108_hasher_cleanup branch August 27, 2021 16:07
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants