build: Use XLIFF file to provide more context to Transifex translators #21694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hoping on "22.0" milestone assigned to this PR :) |
laanwj
reviewed
Apr 15, 2021
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
CI is green now :) |
Guix builds:Gitian builds:
|
|
I verified that |
laanwj
reviewed
Apr 20, 2021
.gitignore
Outdated
| @@ -56,6 +56,8 @@ src/qt/bitcoin-qt.creator | |||
| src/qt/bitcoin-qt.creator.user | |||
| src/qt/bitcoin-qt.files | |||
| src/qt/bitcoin-qt.includes | |||
| # An intermediate XLIFF translation file. | |||
| src/qt/locale/bitcoin_en.xlf | |||
There was a problem hiding this comment.
Transifex auto-updates from the branch. If you want transifex to pick this file up instead of the .ts it needs to be checked in, not added to .gitignore.
The goal is to see the way the Transifex presents the added items to translators using an intermediate XLIFF translation file.
As the bitcoin_en.xlf file is created by the `make -C src translate` command, other translation-related files are also updated.
|
Updated 347a45d -> 35d5239 (pr21694.04 -> pr21694.05, diff):
|
|
The pr description is updated with an example of a translatable string presentation in the |
|
ACK 35d5239 |
|
The actual results are presented in bitcoin-core/gui#287. |
hebasto
added a commit
that referenced
this pull request
May 27, 2021
…lator comments 8b77133 qt: Replace disambiguation strings with translator comments (Hennadii Stepanov) Pull request description: Since #21694 is merged, translator comments is the right way to pass context to translators. This PR fixes changes were made: - in #220 before #21694 - in #21694 on testing purpose - in #125 Closes #288. ACKs for top commit: jarolrod: ACK 8b77133 Tree-SHA512: 466ade35f4969a41fbf3196780b1ae9fa810bab5d2f09077f8631604636cc63b24a901c719f6b5797366d2aa307993d0aa419ce35200c8d0a741a3d81cad3e6b
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2021
…lator comments 8b77133 qt: Replace disambiguation strings with translator comments (Hennadii Stepanov) Pull request description: Since bitcoin#21694 is merged, translator comments is the right way to pass context to translators. This PR fixes changes were made: - in #220 before bitcoin#21694 - in bitcoin#21694 on testing purpose - in #125 Closes #288. ACKs for top commit: jarolrod: ACK 8b77133 Tree-SHA512: 466ade35f4969a41fbf3196780b1ae9fa810bab5d2f09077f8631604636cc63b24a901c719f6b5797366d2aa307993d0aa419ce35200c8d0a741a3d81cad3e6b
laanwj
added a commit
that referenced
this pull request
Feb 4, 2022
985d85e Follow Transifex docs to prepare XLIFF source (Hennadii Stepanov) Pull request description: This PR is a #21694 follow up. From the Transifex [docs](https://docs.transifex.com/formats/xliff#how-to-distinguish-between-a-source-file-and-a-translation-file): > A source file is different than a translation file. The translation file contains \<Target> references, whereas a source file does not. This PR makes the `qt/locale/bitcoin_en.xlf` source file according to the docs. ACKs for top commit: laanwj: ACK 985d85e Tree-SHA512: 537ef78f39a12f094b17fc902c5b59c7ae4d27e5fa35fbf6b33386843e4521236dac3275ba26ff2d1c435e53e8942284644d5de67b0b3543cec96cbcd4351607
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 17, 2022
…sifex translators Excludes 35d5239
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Feb 18, 2022
…sifex translators Excludes 35d5239
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
…sifex translators Excludes 35d5239
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
…sifex translators Excludes 35d5239
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
…sifex translators Excludes 35d5239
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
…sifex translators Excludes 35d5239
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 13, 2022
backport: bitcoin#21694 (Use XLIFF file to provide more context to Transifex)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only a class name is provided to the Transifex translators as a context. Neither
disambiguationparameter of thetr()function nor translator comments, being included as XML elements to*.tstranslation files, are not parsed by the Transifex due to its limited support of such files.This PR makes possible to provide all of the context details via an intermediate XLIFF translation file.
With this PR
make -C src translateproduces thesrc/qt/locale/bitcoin_en.xlffile which must be provided to the Transifex as a translation source instead ofsrc/qt/locale/bitcoin_en.ts.Closes #21465.
An example translatable string with additional
<context>and<note>XML elements:bitcoin/src/qt/locale/bitcoin_en.xlf
Lines 126 to 132 in 35d5239