build: Cleanups and follow ups after bumping Qt to 5.12.10 #21423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The existence of each subdir is not guaranteed for all platforms.
The removed flag has been already linked with Qt5XcbQpa.
There is no "share" directory in the staging one.
Qt version is bumped to 5.12.10 in bitcoin#21376.
|
Gitian builds: Guix builds: |
jarolrod
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Contributing GUIX build hashes, my macOS hashes do not match @hebasto's
find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
51a9b19b223936c2dda51a1e74b76804d593326cc2d85e429e092b690a9f0d3e output/bitcoin-e67c0122a4e8-aarch64-linux-gnu-debug.tar.gz
f4329af75711a6ec466e745c24c14a3f98e4fa58503663c92d6c1df35e3fa34a output/bitcoin-e67c0122a4e8-aarch64-linux-gnu.tar.gz
80c14cdd09f33bd9d8d898af8fed2726488289fa54eb9f985b7919c99b3dfbec output/bitcoin-e67c0122a4e8-arm-linux-gnueabihf-debug.tar.gz
4771a454c4ea412cbd63183561fb2b2be8beec9657fd01a2e0edb00f3c1f66dc output/bitcoin-e67c0122a4e8-arm-linux-gnueabihf.tar.gz
ee3d4d4fc619b0d3c13b55ad97df02a572a16a649faddf73f8fd8f5f7d72da87 output/bitcoin-e67c0122a4e8-osx-unsigned.dmg
6dd39014363f12574cebafbc25ba33e1b2e84d194433b6fdbb97d833dcf9bf00 output/bitcoin-e67c0122a4e8-osx-unsigned.tar.gz
dce24659cd3e5a28d5be83f5aa9c0ff1fb7b24551b16765a7e0657ed25fe8f29 output/bitcoin-e67c0122a4e8-osx64.tar.gz
628966b51e865f8d1acd2b95c04d28067f07ed504654c7a1a243e04f02aed37d output/bitcoin-e67c0122a4e8-powerpc64-linux-gnu-debug.tar.gz
bf27bc8f21afc8c3fea69ad78af180a48e78b2003df027868d29babcba7ba5a1 output/bitcoin-e67c0122a4e8-powerpc64-linux-gnu.tar.gz
a2ba7b6dbf4f635c7331da742b1520c0aa6f05c57ca721b4df8e7e1a452d8bab output/bitcoin-e67c0122a4e8-powerpc64le-linux-gnu-debug.tar.gz
e316f009515114561e98448781a07e824ce789bf8a6f0fe55843d79073c2dae1 output/bitcoin-e67c0122a4e8-powerpc64le-linux-gnu.tar.gz
c3f1c9a465b9cce7cc5d9ade0136a12e507dd156892aae390ff1c2ad568ceb8b output/bitcoin-e67c0122a4e8-riscv64-linux-gnu-debug.tar.gz
29719d5908dd1d9f7e12e45a12952745cd18dd797b1b68ff2041973697a0d4cf output/bitcoin-e67c0122a4e8-riscv64-linux-gnu.tar.gz
c995b01a4314a2a292edcf15bad5e4b358155be15670e35c1910778c0802a355 output/bitcoin-e67c0122a4e8-win-unsigned.tar.gz
0b1a5663354389ff62f8041933a04c91e18afdcdfa35c38efe9a935a42ba8f9d output/bitcoin-e67c0122a4e8-win64-debug.zip
e02a257b709c6b98cc02d6823697da9db661062616b97c23e1c1e0f1f851eddd output/bitcoin-e67c0122a4e8-win64-setup-unsigned.exe
7761dc695a6c9ab6cef6aed622b0dc5cdbe370d7cf4ebe747e9603f9bc92ef4b output/bitcoin-e67c0122a4e8-win64.zip
3b2b1ce8bed71f695dfef737d7c5b061dcb204e65e617acb9d176ec7783b3832 output/bitcoin-e67c0122a4e8-x86_64-linux-gnu-debug.tar.gz
c5c08f5d66658b580bedbb219c9ec6046bb6fcbf97d9f16e8809d11eb986d491 output/bitcoin-e67c0122a4e8-x86_64-linux-gnu.tar.gz
cb1b0e449d92dffa71b5b5578971e17275664b522790861a94a6a043e7712a10 output/src/bitcoin-e67c0122a4e8.tar.gz
|
So we have a determinism issue for macOS builds: -3b09cae14e47cd08452c4ee10c4d1d3dfb0ec7535cc1f947e0e41f75d9b3dc90 output/bitcoin-e67c0122a4e8-osx-unsigned.dmg
-5fbf0c535d3a6e0ebeb42e931105330874a02a1a5ba03b9a717d312145de46b5 output/bitcoin-e67c0122a4e8-osx-unsigned.tar.gz
-0d8512db38dfca6a34ab866facfe3e68e144b5d684a4d7e5a329a02d7ac16334 output/bitcoin-e67c0122a4e8-osx64.tar.gz
+ee3d4d4fc619b0d3c13b55ad97df02a572a16a649faddf73f8fd8f5f7d72da87 output/bitcoin-e67c0122a4e8-osx-unsigned.dmg
+6dd39014363f12574cebafbc25ba33e1b2e84d194433b6fdbb97d833dcf9bf00 output/bitcoin-e67c0122a4e8-osx-unsigned.tar.gz
+dce24659cd3e5a28d5be83f5aa9c0ff1fb7b24551b16765a7e0657ed25fe8f29 output/bitcoin-e67c0122a4e8-osx64.tar.gz |
|
Concept ACK |
fanquake
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
ACK e67c012
Gitian:
macOS
2c59ded3ff71cac0400967d61dd72a54123834e01f3b4bca42949981bb263f32 bitcoin-e67c0122a4e8-osx-unsigned.dmg
0b4bd5300c12ed2c47ae9d8fa14368981b792a5f9168239eb70c4612dff3e68d bitcoin-e67c0122a4e8-osx-unsigned.tar.gz
7a1deb780ea3d9e5eb2278d55124c2461a44099e1760e23b2d1e720fa2d82a52 bitcoin-e67c0122a4e8-osx64.tar.gz
cb1b0e449d92dffa71b5b5578971e17275664b522790861a94a6a043e7712a10 src/bitcoin-e67c0122a4e8.tar.gz
9d4af815104c551655e1ebaadf3d345ae7dd05a64122f8bcbee6f72b418a9468 bitcoin-core-osx-22-res.yml
win
ee15010d89e56665317f7c40cfdb2338c0b6780214035790114841fc71e36b11 bitcoin-e67c0122a4e8-win-unsigned.tar.gz
97768d29abb0e348418d19df9d9dd027c8ea408f30d6c6c37c5d905c4ae1452a bitcoin-e67c0122a4e8-win64-debug.zip
0a9a13503d548535ddb641cdf78b37c1e9ea9da0cd1d14257fa3b5bc370ad27a bitcoin-e67c0122a4e8-win64-setup-unsigned.exe
6d967291087c7b9466da57823895199ce6a26da92be5e99c70985436c75512c8 bitcoin-e67c0122a4e8-win64.zip
cb1b0e449d92dffa71b5b5578971e17275664b522790861a94a6a043e7712a10 src/bitcoin-e67c0122a4e8.tar.gz
49666d8cac743000efb10a5af4397b81bd7e00a68b7e156ab08a48400066ece5 bitcoin-core-win-22-res.yml
linux
d20dff44ad0ce765030fda64f64eab12a1733f541afdf47dbde7dbc55dced2f5 bitcoin-e67c0122a4e8-aarch64-linux-gnu-debug.tar.gz
227c7379b8a2ac1e9731ec0edffbb7fa813db51ec11bc627a247838fa03a3ef5 bitcoin-e67c0122a4e8-aarch64-linux-gnu.tar.gz
5ac433619d16ccfd4870e56fe344f2230e4defb4d8e92cf1d7d71d3118f1fef3 bitcoin-e67c0122a4e8-arm-linux-gnueabihf-debug.tar.gz
c9eedfc1cd0866059b0e076db9ac640af251b7b6dffef5a8771bb324e9538226 bitcoin-e67c0122a4e8-arm-linux-gnueabihf.tar.gz
78c77569da090d08b9fabee74afc80e0c14a6619621cecea8ccaa768564debdd bitcoin-e67c0122a4e8-powerpc64-linux-gnu-debug.tar.gz
9139f1fee876486258e49fe5cb07e5ff39fd1823e9c856461471637e2295297f bitcoin-e67c0122a4e8-powerpc64-linux-gnu.tar.gz
df15cd01131981cecaf03ea9ded160749bc22f492051de09bc4c785f2f99daae bitcoin-e67c0122a4e8-powerpc64le-linux-gnu-debug.tar.gz
cb81be7192593e477d3c6f6ffd47aae98eea45ebce0c081bc47c4da2275cf6c9 bitcoin-e67c0122a4e8-powerpc64le-linux-gnu.tar.gz
20c63b3b6398ef4d7f652e4f3a0c2308c6942a2e1dbc6746c709626df97336b0 bitcoin-e67c0122a4e8-riscv64-linux-gnu-debug.tar.gz
d9915a6704dd455796b0116b8e080229db91de556994018ae0dfc56ae4b1b040 bitcoin-e67c0122a4e8-riscv64-linux-gnu.tar.gz
78eb26b802c4a855139c7307d18b7622973896a6212c92905e5903d73d2fbdb1 bitcoin-e67c0122a4e8-x86_64-linux-gnu-debug.tar.gz
5d70fc3f0fa58a5dfac7b7902862ab5c1d19d7bd248e146715204e25bac7bcab bitcoin-e67c0122a4e8-x86_64-linux-gnu.tar.gz
cb1b0e449d92dffa71b5b5578971e17275664b522790861a94a6a043e7712a10 src/bitcoin-e67c0122a4e8.tar.gz
1c604861988a80d4da8e4dd4dd498570de687563c77159e3b6a577c3b1625e4d bitcoin-core-linux-22-res.ymlGuix:
51a9b19b223936c2dda51a1e74b76804d593326cc2d85e429e092b690a9f0d3e output/bitcoin-e67c0122a4e8-aarch64-linux-gnu-debug.tar.gz
f4329af75711a6ec466e745c24c14a3f98e4fa58503663c92d6c1df35e3fa34a output/bitcoin-e67c0122a4e8-aarch64-linux-gnu.tar.gz
80c14cdd09f33bd9d8d898af8fed2726488289fa54eb9f985b7919c99b3dfbec output/bitcoin-e67c0122a4e8-arm-linux-gnueabihf-debug.tar.gz
4771a454c4ea412cbd63183561fb2b2be8beec9657fd01a2e0edb00f3c1f66dc output/bitcoin-e67c0122a4e8-arm-linux-gnueabihf.tar.gz
ee3d4d4fc619b0d3c13b55ad97df02a572a16a649faddf73f8fd8f5f7d72da87 output/bitcoin-e67c0122a4e8-osx-unsigned.dmg
6dd39014363f12574cebafbc25ba33e1b2e84d194433b6fdbb97d833dcf9bf00 output/bitcoin-e67c0122a4e8-osx-unsigned.tar.gz
dce24659cd3e5a28d5be83f5aa9c0ff1fb7b24551b16765a7e0657ed25fe8f29 output/bitcoin-e67c0122a4e8-osx64.tar.gz
628966b51e865f8d1acd2b95c04d28067f07ed504654c7a1a243e04f02aed37d output/bitcoin-e67c0122a4e8-powerpc64-linux-gnu-debug.tar.gz
bf27bc8f21afc8c3fea69ad78af180a48e78b2003df027868d29babcba7ba5a1 output/bitcoin-e67c0122a4e8-powerpc64-linux-gnu.tar.gz
a2ba7b6dbf4f635c7331da742b1520c0aa6f05c57ca721b4df8e7e1a452d8bab output/bitcoin-e67c0122a4e8-powerpc64le-linux-gnu-debug.tar.gz
e316f009515114561e98448781a07e824ce789bf8a6f0fe55843d79073c2dae1 output/bitcoin-e67c0122a4e8-powerpc64le-linux-gnu.tar.gz
c3f1c9a465b9cce7cc5d9ade0136a12e507dd156892aae390ff1c2ad568ceb8b output/bitcoin-e67c0122a4e8-riscv64-linux-gnu-debug.tar.gz
29719d5908dd1d9f7e12e45a12952745cd18dd797b1b68ff2041973697a0d4cf output/bitcoin-e67c0122a4e8-riscv64-linux-gnu.tar.gz
c995b01a4314a2a292edcf15bad5e4b358155be15670e35c1910778c0802a355 output/bitcoin-e67c0122a4e8-win-unsigned.tar.gz
0b1a5663354389ff62f8041933a04c91e18afdcdfa35c38efe9a935a42ba8f9d output/bitcoin-e67c0122a4e8-win64-debug.zip
e02a257b709c6b98cc02d6823697da9db661062616b97c23e1c1e0f1f851eddd output/bitcoin-e67c0122a4e8-win64-setup-unsigned.exe
7761dc695a6c9ab6cef6aed622b0dc5cdbe370d7cf4ebe747e9603f9bc92ef4b output/bitcoin-e67c0122a4e8-win64.zip
3b2b1ce8bed71f695dfef737d7c5b061dcb204e65e617acb9d176ec7783b3832 output/bitcoin-e67c0122a4e8-x86_64-linux-gnu-debug.tar.gz
c5c08f5d66658b580bedbb219c9ec6046bb6fcbf97d9f16e8809d11eb986d491 output/bitcoin-e67c0122a4e8-x86_64-linux-gnu.tar.gz
cb1b0e449d92dffa71b5b5578971e17275664b522790861a94a6a043e7712a10 output/src/bitcoin-e67c0122a4e8.tar.gz
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 19, 2021
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Apr 25, 2022
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins/subdirbefore adding to search paths as the existence of each subdir is not guaranteed for all platforms:-lxcb-staticflag as it has been already linked withQt5XcbQpa:libxkbcommon_postprocess_cmdsas there is noshare/directory in the staging one:dependencies.md