Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run script_assets_test even if built --with-libs=no #20245

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Oct 26, 2020

script_assets_test doesn't call libbitcoinconsensus, so it seems confusing to require it

@DrahtBot DrahtBot added the Tests label Oct 26, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 26, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa3967e - looks ok to me.

@maflcko maflcko merged commit 88776c2 into bitcoin:master Nov 4, 2020
@maflcko maflcko deleted the 2010-testAssetTestlibconsensus branch November 4, 2020 07:56
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 4, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants