rpc: Improve invalid vout value rpc error message #19956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
from
cf6befe to
9dce22b
Compare
|
Concept ACK -- "positive" means greater than zero by definition, so the error message was incorrect I think you should squash those commits. Welcome as new contributor by the way! 🎉 |
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
from
19b7996 to
89860a8
Compare
THANKS @theStack |
|
ACK 89860a8. Agree with the concept, changes are no-risk. |
theStack
approved these changes
Sep 16, 2020
|
Concept ACK -- This error also appears some other places. Here are the first two I found from Lines 599 to 600 in d052f5e bitcoin/src/rpc/rawtransaction_util.cpp Lines 177 to 179 in ffaac6e |
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
from
89860a8 to
4be8380
Compare
Addressed. @adaminsky |
|
ACK 4be8380. |
|
Could be a scripted diff to show the replacement is complete? |
|
I was not familiar with scripted diff, I will replace my commit with with script diff enabled. @MarcoFalke |
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
2 times, most recently
from
ea57639 to
f56bff4
Compare
|
Please insert an empty line in your commit message between the title of the commit and the body, otherwise it appears like this in one-line summary format: The change itself looks good to me. |
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
from
f56bff4 to
43bfec8
Compare
|
Addressed @laanwj |
|
Instead of hardcoding the file names, you can use |
n1rna
force-pushed
the
rpc-invalid-vout-message
branch
from
43bfec8 to
f471a3b
Compare
|
Yes, much better now. Thanks for the suggestoin @MarcoFalke |
-BEGIN VERIFY SCRIPT-
r() { sed -i 's/vout must be positive/vout cannot be negative/g' $1 }
r $(git grep -l 'vout must be positive')
-END VERIFY SCRIPT-
promag
reviewed
Oct 1, 2020
fanquake
approved these changes
Oct 3, 2020
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 3, 2021
Summary: Since the vout value can start at 0, the error message for negative values can be improved to something like: vout cannot be negative. This is a backport of [[bitcoin/bitcoin#19956 | core#19956]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D10423
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
f471a3b scripted diff: Improve invalid vout value rpc error message (Nima Yazdanmehr) Pull request description: Since the `vout` value can start at `0`, the error message for *negative* values can be improved to something like: `vout cannot be negative`. ACKs for top commit: fanquake: ACK f471a3b promag: Code review ACK f471a3b. Tree-SHA512: fbdee3d0ddd5b58eb93934a1217b44e125a9ad39e672b1f35c7609c6c5fcf45ae1b731d3d6135b7225d98792dbfc34a50907b8c41274a5b029d7b5c59f886560
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
f471a3b scripted diff: Improve invalid vout value rpc error message (Nima Yazdanmehr) Pull request description: Since the `vout` value can start at `0`, the error message for *negative* values can be improved to something like: `vout cannot be negative`. ACKs for top commit: fanquake: ACK f471a3b promag: Code review ACK f471a3b. Tree-SHA512: fbdee3d0ddd5b58eb93934a1217b44e125a9ad39e672b1f35c7609c6c5fcf45ae1b731d3d6135b7225d98792dbfc34a50907b8c41274a5b029d7b5c59f886560
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 22, 2021
f471a3b scripted diff: Improve invalid vout value rpc error message (Nima Yazdanmehr) Pull request description: Since the `vout` value can start at `0`, the error message for *negative* values can be improved to something like: `vout cannot be negative`. ACKs for top commit: fanquake: ACK f471a3b promag: Code review ACK f471a3b. Tree-SHA512: fbdee3d0ddd5b58eb93934a1217b44e125a9ad39e672b1f35c7609c6c5fcf45ae1b731d3d6135b7225d98792dbfc34a50907b8c41274a5b029d7b5c59f886560
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 28, 2021
f471a3b scripted diff: Improve invalid vout value rpc error message (Nima Yazdanmehr) Pull request description: Since the `vout` value can start at `0`, the error message for *negative* values can be improved to something like: `vout cannot be negative`. ACKs for top commit: fanquake: ACK f471a3b promag: Code review ACK f471a3b. Tree-SHA512: fbdee3d0ddd5b58eb93934a1217b44e125a9ad39e672b1f35c7609c6c5fcf45ae1b731d3d6135b7225d98792dbfc34a50907b8c41274a5b029d7b5c59f886560
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
voutvalue can start at0, the error message for negative values can be improved to something like:vout cannot be negative.