refactor: Make CCheckQueue RAII-styled #18731

hebasto · 2020-04-22T00:33:08Z

This PR:

makes CCheckQueue RAII-styled
gets rid of two global variables:
- scriptcheckqueue
- g_parallel_script_checks

This PR is based on #18710, therefore only the last two commits should be considered.

DrahtBot · 2020-04-22T10:12:23Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) #20487 (draft: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift)
tests: Create or use existing properly initialized NodeContexts #20323 (tests: Create or use existing properly initialized NodeContexts by dongcarl)
addrman: Make addrman a top-level component #20228 (addrman: Make addrman a top-level component by jnewbery)
Move SaltedHashers to separate file and add some new ones #19935 (Move SaltedHashers to separate file and add some new ones by achow101)
wallet: Migrate legacy wallets to descriptor wallets #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)
Introduce deploymentstatus #19438 (Introduce deploymentstatus by ajtowns)
[WIP DONOTMERGE] Replace boost with C++17 (std::shared_mutex) #19183 ([WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

promag

Concept ACK RAII style.

Need to fix test/fuzz/checkqueue.cpp in lines 41 and 42.

hebasto · 2020-04-28T19:31:11Z

Rebased ba61343 -> 3553bde (pr18731.01 -> pr18731.02) ~~and ready for review.~~

hebasto · 2020-05-01T03:43:26Z

Updated 3553bde -> 01be64d (pr18731.02 -> pr18731.04, diff):

copy constructor and copy assignment are disabled

And this PR is ready for review, finally.

Also this commits gets rid of scriptcheckqueue global variable.

hebasto · 2020-09-24T04:00:04Z

Rebased e5a82de -> 56d40da (pr18731.14 -> pr18731.15) due to the conflict with #19927.

DrahtBot · 2020-12-09T11:14:00Z

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

DrahtBot · 2021-12-15T11:21:59Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

DrahtBot · 2022-03-21T13:07:28Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

jonatack · 2022-03-21T13:18:16Z

#18710 was merged, so this could be rebased and brought out of draft if you are still working on this.

hebasto · 2022-04-22T14:31:40Z

I won't be able to focus on this stuff in the near future.

So closing up for grabs.

hebasto · 2022-12-28T13:18:13Z

I won't be able to focus on this stuff in the near future.

So closing up for grabs.

#26762.

5b3ea5f refactor: Move `{MAX,DEFAULT}_SCRIPTCHECK_THREADS` constants (Hennadii Stepanov) 6e17b31 refactor: Make `CCheckQueue` non-copyable and non-movable explicitly (Hennadii Stepanov) 8111e74 refactor: Drop unneeded declaration (Hennadii Stepanov) 9cf89f7 refactor: Make `CCheckQueue` constructor start worker threads (Hennadii Stepanov) d03eaac Make `CCheckQueue` destructor stop worker threads (Hennadii Stepanov) be4ff30 Move global `scriptcheckqueue` into `ChainstateManager` class (Hennadii Stepanov) Pull request description: This PR: - makes `CCheckQueue` RAII-styled - gets rid of the global `scriptcheckqueue` - fixes #25448 The previous attempt was in #18731. ACKs for top commit: martinus: ACK 5b3ea5f achow101: ACK 5b3ea5f TheCharlatan: ACK 5b3ea5f Tree-SHA512: 45cca846e7ed107e3930149f0b616ddbaf2648d6cde381f815331b861b5d67ab39e154883ae174b8abb1dae485bc904318c50c51e5d6b46923d89de51c5eadb0

fanquake added the Refactoring label Apr 22, 2020

hebasto mentioned this pull request Apr 22, 2020

Add local thread pool to CCheckQueue #18710

Merged

This was referenced Apr 22, 2020

Make g_chainman internal to validation #18698

Merged

Prevent consecutive ::cs_main locks #18639

Closed

coins: allow cache resize after init #18637

Merged

bench: Remove requirement that all benches use same testing setup #18575

Merged

DrahtBot added the Needs rebase label Apr 22, 2020

hebasto marked this pull request as draft April 25, 2020 00:33

hebasto changed the title ~~refactor: Make CCheckQueue RAII-styled~~ [WIP] refactor: Make CCheckQueue RAII-styled Apr 25, 2020

promag reviewed Apr 26, 2020

View reviewed changes

hebasto force-pushed the 200421-queue-raii branch from ba61343 to 3553bde Compare April 28, 2020 18:48

hebasto changed the title ~~[WIP] refactor: Make CCheckQueue RAII-styled~~ refactor: Make CCheckQueue RAII-styled Apr 28, 2020

hebasto marked this pull request as ready for review April 28, 2020 19:26

DrahtBot mentioned this pull request Apr 28, 2020

Remove unused boost/thread #18758

Merged

DrahtBot removed the Needs rebase label Apr 28, 2020

hebasto marked this pull request as draft April 28, 2020 23:47

hebasto changed the title ~~refactor: Make CCheckQueue RAII-styled~~ [WIP] refactor: Make CCheckQueue RAII-styled Apr 28, 2020

hebasto force-pushed the 200421-queue-raii branch 2 times, most recently from ac16422 to 01be64d Compare May 1, 2020 02:39

hebasto marked this pull request as ready for review May 1, 2020 03:43

hebasto changed the title ~~[WIP] refactor: Make CCheckQueue RAII-styled~~ refactor: Make CCheckQueue RAII-styled May 1, 2020

This was referenced May 2, 2020

The Zero Allocations project #18849

Closed

More thread safety annotation coverage #16127

Merged

assumeutxo #15606

Closed

DrahtBot mentioned this pull request May 14, 2020

wallet: Refactor the classes in wallet/db.{cpp/h} #18971

Closed

8 tasks

DrahtBot added the Needs rebase label May 23, 2020

hebasto force-pushed the 200421-queue-raii branch from 01be64d to 3fa8587 Compare May 26, 2020 17:42

hebasto added 3 commits September 24, 2020 06:55

refactor: Drop boost::thread stuff in CCheckQueue

bb6fcc7

refactor: Make CCheckQueue RAII-styled

8e78a41

Also this commits gets rid of scriptcheckqueue global variable.

refactor: Drop g_parallel_script_checks global

56d40da

hebasto force-pushed the 200421-queue-raii branch from e5a82de to 56d40da Compare September 24, 2020 03:58

DrahtBot removed the Needs rebase label Sep 24, 2020

This was referenced Sep 28, 2020

validation: Remove useless call to mempool->clear() #20030

Closed

Move SaltedHashers to separate file and add some new ones #19935

Merged

wallet: Migrate legacy wallets to descriptor wallets #19602

Merged

DrahtBot mentioned this pull request Oct 15, 2020

tree-wide: De-globalize ChainstateManager #20158

Closed

12 tasks

This was referenced Oct 23, 2020

addrman: Make addrman a top-level component #20228

Merged

addrman: Make consistency checks a runtime option #20233

Closed

DrahtBot mentioned this pull request Nov 25, 2020

Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) #20487

Merged

DrahtBot mentioned this pull request Dec 5, 2020

tests: Create or use existing properly initialized NodeContexts #20323

Merged

DrahtBot added the Needs rebase label Dec 9, 2020

hebasto marked this pull request as draft December 19, 2020 17:33

hebasto closed this Apr 22, 2022

hebasto added the Up for grabs label Apr 22, 2022

maflcko mentioned this pull request Jun 23, 2022

~CCheckQueue assertion failure during unclean exits #25448

Closed

hebasto mentioned this pull request Dec 28, 2022

bugfix: Make CCheckQueue RAII-styled (attempt 2) #26762

Merged

hebasto removed the Up for grabs label Dec 28, 2022

hebasto deleted the 200421-queue-raii branch December 28, 2022 13:18

bitcoin locked and limited conversation to collaborators Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Make CCheckQueue RAII-styled #18731

refactor: Make CCheckQueue RAII-styled #18731

hebasto commented Apr 22, 2020

DrahtBot commented Apr 22, 2020 •

edited

Loading

promag left a comment

hebasto commented Apr 28, 2020 •

edited

Loading

hebasto commented May 1, 2020

hebasto commented Sep 24, 2020

DrahtBot commented Dec 9, 2020

DrahtBot commented Dec 15, 2021

DrahtBot commented Mar 21, 2022

jonatack commented Mar 21, 2022

hebasto commented Apr 22, 2022

hebasto commented Dec 28, 2022

refactor: Make CCheckQueue RAII-styled #18731

refactor: Make CCheckQueue RAII-styled #18731

Conversation

hebasto commented Apr 22, 2020

DrahtBot commented Apr 22, 2020 • edited Loading

Conflicts

promag left a comment

Choose a reason for hiding this comment

hebasto commented Apr 28, 2020 • edited Loading

hebasto commented May 1, 2020

hebasto commented Sep 24, 2020

DrahtBot commented Dec 9, 2020

DrahtBot commented Dec 15, 2021

DrahtBot commented Mar 21, 2022

jonatack commented Mar 21, 2022

hebasto commented Apr 22, 2022

hebasto commented Dec 28, 2022

DrahtBot commented Apr 22, 2020 •

edited

Loading

hebasto commented Apr 28, 2020 •

edited

Loading