qt: Fix Window -> Minimize menu item #18549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @promag |
Closed
|
Has this ever worked? When did it break? |
|
Tested ACK 56fe839 on bionic with qt 5.9.5. |
|
@MarcoFalke I don't know, it was added in #14573, maybe it never worked right on linux. |
|
@MarcoFalke I confirm that the problem always existed since it was introduced in 95a5a9f. |
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 9, 2020
- rpc/wallet: initialize nFeeRequired to avoid using garbage value on failure bitcoin#18274 - httpserver: use own HTTP status codes bitcoin#18168 - tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions bitcoin#17229 - util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests. bitcoin#17753 - util: Fail to parse empty string in ParseMoney bitcoin#18225 - util: Fail to parse whitespace-only strings in ParseMoney(...) (instead of parsing as zero) bitcoin#18270 - Replace the LogPrint function with a macro bitcoin#17218 - Fix wallet unload race condition bitcoin#18338 - qt: Fix Window -> Minimize menu item bitcoin#18549 - windows: Enable heap terminate-on-corruption bitcoin#17916
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 13, 2020
Summary: On linux, the "Minimize" menu icon worked with using the `Ctrl + M` shortcut, but not with a click on the action in the menu. This fixes it. Backport of [[bitcoin/bitcoin#18549 | PR18549]] Depends on D7894 Test Plan: `ninja && ninja check` Run `src/qt/bitcoin-qt` and check that the `Window -> Minimize` menu action works on linux, both via the keyboard shortcut and with a click in the menu. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7895
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Apr 14, 2021
Summary: On linux, the "Minimize" menu icon worked with using the `Ctrl + M` shortcut, but not with a click on the action in the menu. This fixes it. Backport of [[bitcoin/bitcoin#18549 | PR18549]] Depends on D7894 Test Plan: `ninja && ninja check` Run `src/qt/bitcoin-qt` and check that the `Window -> Minimize` menu action works on linux, both via the keyboard shortcut and with a click in the menu. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7895
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 17, 2021
56fe839 qt: Fix Window -> Minimize menu item (Hennadii Stepanov) Pull request description: Now Window -> Minimize menu item is broken on Linux. Steps to reproduce: 1. start `bitcoin-qt` 2. activate Window -> Minimize menu item with a keyboard (not by a shortcut) or a mouse **Expected behavior** The main window gets minimized. **Actual behavior** The main window still unchanged. Even worse: the menu widget becomes a separate window:  This PR does not touch the macOS specific code as `qApp->focusWindow()` seems work on macOS flawlessly. ACKs for top commit: promag: Tested ACK 56fe839 on bionic with qt 5.9.5. Tree-SHA512: 3582e44ba181d859f5994b9cddc6ce1b60aa1db520a31dd3a0684336c79d558d7410ce7a1ab5b0860c6431b54d8acc3aa16e399717b4c70839861e6b6c4290c0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 17, 2021
56fe839 qt: Fix Window -> Minimize menu item (Hennadii Stepanov) Pull request description: Now Window -> Minimize menu item is broken on Linux. Steps to reproduce: 1. start `bitcoin-qt` 2. activate Window -> Minimize menu item with a keyboard (not by a shortcut) or a mouse **Expected behavior** The main window gets minimized. **Actual behavior** The main window still unchanged. Even worse: the menu widget becomes a separate window:  This PR does not touch the macOS specific code as `qApp->focusWindow()` seems work on macOS flawlessly. ACKs for top commit: promag: Tested ACK 56fe839 on bionic with qt 5.9.5. Tree-SHA512: 3582e44ba181d859f5994b9cddc6ce1b60aa1db520a31dd3a0684336c79d558d7410ce7a1ab5b0860c6431b54d8acc3aa16e399717b4c70839861e6b6c4290c0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 18, 2021
56fe839 qt: Fix Window -> Minimize menu item (Hennadii Stepanov) Pull request description: Now Window -> Minimize menu item is broken on Linux. Steps to reproduce: 1. start `bitcoin-qt` 2. activate Window -> Minimize menu item with a keyboard (not by a shortcut) or a mouse **Expected behavior** The main window gets minimized. **Actual behavior** The main window still unchanged. Even worse: the menu widget becomes a separate window:  This PR does not touch the macOS specific code as `qApp->focusWindow()` seems work on macOS flawlessly. ACKs for top commit: promag: Tested ACK 56fe839 on bionic with qt 5.9.5. Tree-SHA512: 3582e44ba181d859f5994b9cddc6ce1b60aa1db520a31dd3a0684336c79d558d7410ce7a1ab5b0860c6431b54d8acc3aa16e399717b4c70839861e6b6c4290c0
thelazier
pushed a commit
to thelazier/dash
that referenced
this pull request
Sep 25, 2021
56fe839 qt: Fix Window -> Minimize menu item (Hennadii Stepanov) Pull request description: Now Window -> Minimize menu item is broken on Linux. Steps to reproduce: 1. start `bitcoin-qt` 2. activate Window -> Minimize menu item with a keyboard (not by a shortcut) or a mouse **Expected behavior** The main window gets minimized. **Actual behavior** The main window still unchanged. Even worse: the menu widget becomes a separate window:  This PR does not touch the macOS specific code as `qApp->focusWindow()` seems work on macOS flawlessly. ACKs for top commit: promag: Tested ACK 56fe839 on bionic with qt 5.9.5. Tree-SHA512: 3582e44ba181d859f5994b9cddc6ce1b60aa1db520a31dd3a0684336c79d558d7410ce7a1ab5b0860c6431b54d8acc3aa16e399717b4c70839861e6b6c4290c0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Window -> Minimize menu item is broken on Linux.
Steps to reproduce:
bitcoin-qtExpected behavior
The main window gets minimized.
Actual behavior
The main window still unchanged. Even worse: the menu widget becomes a separate window:
This PR does not touch the macOS specific code as
qApp->focusWindow()seems work on macOS flawlessly.