Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use fs namespace in dbwrapper unicodepath test #18371

Merged
merged 1 commit into from
Mar 18, 2020
Merged

test: use fs namespace in dbwrapper unicodepath test #18371

merged 1 commit into from
Mar 18, 2020

Conversation

fanquake
Copy link
Member

Use our fs namespace rather than boost::filesystem. Test was added in #17641.

@fanquake fanquake added the Tests label Mar 18, 2020
@fanquake fanquake requested a review from sipsorcery March 18, 2020 03:12
@sipsorcery
Copy link
Contributor

ACK 6afaf2f.

@maflcko maflcko merged commit 3a8d250 into bitcoin:master Mar 18, 2020
@fanquake fanquake deleted the dbwrapper_use_fs_namespace branch March 18, 2020 13:52
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2020
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
1c3c0f8 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
glowang pushed a commit to glowang/bitcoin that referenced this pull request Mar 29, 2020
@glowang
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
9afdc56 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 5, 2020
@fanquake @PiRK
test: use fs namespace in dbwrapper unicodepath test
0779723 
Summary:
This is a backport of Core [[bitcoin/bitcoin#18371 | PR18371]]

Depends on D8285

Test Plan: `ninja && ninja check`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8284
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
3eb1a5c 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
17e5d31 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
c7a4979 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
cab837c 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
4e1b450 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
2ee36d8 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 22, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
0520527 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 22, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
e0b3f21 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 22, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
3c729a2 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 28, 2021
@PastaPastaPasta
Merge bitcoin#18371: test: use fs namespace in dbwrapper unicodepath …
be1f098 
…test

6afaf2f test: use fs namespace in dbwrapper unicodepath test (fanquake)

Pull request description:

  Use our `fs` namespace rather than `boost::filesystem`. Test was added in bitcoin#17641.

ACKs for top commit:
  sipsorcery:
    ACK 6afaf2f.

Tree-SHA512: 5ee024a6d90183b6c344f6a94cfbcacb006973f1f6d98cc421c1c6ef08c09b590d31c78b70b86d855e825241ffea25989cfc40d1bdd53e38a75cda0718ac4489
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sipsorcery sipsorcery sipsorcery approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanquake @sipsorcery @maflcko