ci: Add valgrind run #17725
ci: Add valgrind run #17725
Conversation
|
A failing travis build was https://travis-ci.org/bitcoin/bitcoin/builds/623456054 |
| export TEST_RUNNER_EXTRA="p2p_segwit.py" # Only run one test for now. TODO enable all and bump timeouts | ||
| export RUN_FUNCTIONAL_TESTS=true | ||
| export GOAL="install" | ||
| export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++" # TODO enable GUI |
There was a problem hiding this comment.
Should we be testing with this flag --with-incompatible-bdb set to true? Is there are reason that we can't use the correct version of berkleydb here?
There was a problem hiding this comment.
We can use the bdb package from depends or from the Ubuntu package manager. The package manager doesn't come with the bdb version we want, so --with-incompatible-bdb is needed. Switching to ./depends is possible, but shouldn't matter, as we ignore leaks and memory issues in dependencies anyway. They need to be dealt with upstream.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Anything left to do here? |
|
ACK facb416 Very nice! |
|
concept ACK! |
facb416 ci: Add valgrind run (MarcoFalke) Pull request description: Fixes bitcoin#17460 ACKs for top commit: practicalswift: ACK facb416 Tree-SHA512: 55396e548a76f976d7b7170b68bc5f93cfd44656162267172f66db7eb549699a2a22d3b1bb0d5f180fe0697931939e652c8cdb86b435e81e7ce572485798009d
facb416 ci: Add valgrind run (MarcoFalke) Pull request description: Fixes bitcoin#17460 ACKs for top commit: practicalswift: ACK facb416 Tree-SHA512: 55396e548a76f976d7b7170b68bc5f93cfd44656162267172f66db7eb549699a2a22d3b1bb0d5f180fe0697931939e652c8cdb86b435e81e7ce572485798009d
Fixes #17460