Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Link to python style guidelines from developer notes #13717

Merged
merged 1 commit into from
Aug 7, 2018
Merged

docs: Link to python style guidelines from developer notes #13717

merged 1 commit into from
Aug 7, 2018

Conversation

masonicboom
Copy link

Initially I moved the python style guidelines from the functional test README, but some of the python rules are test-specific, and most of the developer notes doc is C++ centric, so just dropping a link seemed better.

@practicalswift
Copy link
Contributor

Concept ACK

@@ -5,8 +5,10 @@ Developer Notes
**Table of Contents**

- [Developer Notes](#developer-notes)
- [Coding Style](#coding-style)
- [Coding Style (General)](#coding-style-general)
- [Coding Style (C++)](#coding-style-c)
- [Doxygen comments](#doxygen-comments)
Copy link
Contributor

@Empact Empact Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If I’m not mistaken we’re only using doxygen for C++, how about making this a sub-point of the previous, ala "Compiling for debugging", here and below? That involves lead the heading with ### instead of underlined with dashes.

@fanquake fanquake added the Docs label Jul 19, 2018
@laanwj
Copy link
Member

laanwj commented Aug 7, 2018

utACK a9e898a

@laanwj laanwj merged commit a9e898a into bitcoin:master Aug 7, 2018
laanwj added a commit that referenced this pull request Aug 7, 2018
a9e898a docs: Link to python style guidelines from developer notes (Mason Simon)

Pull request description:

  Initially I moved the python style guidelines from the functional test README, but some of the python rules are test-specific, and most of the developer notes doc is C++ centric, so just dropping a link seemed better.

Tree-SHA512: 9d4d5cc45526319a118595d90fcfad2c9aced22007aa096d8af04ba1b963312822804f4c15b0b227d66af49565034437691b7760e7ff6d1e3f8b10b898906362
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 17, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#13717 | PR13717]]

Test Plan: Proof-reading

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8431
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 2, 2021
…oper notes

a9e898a docs: Link to python style guidelines from developer notes (Mason Simon)

Pull request description:

  Initially I moved the python style guidelines from the functional test README, but some of the python rules are test-specific, and most of the developer notes doc is C++ centric, so just dropping a link seemed better.

Tree-SHA512: 9d4d5cc45526319a118595d90fcfad2c9aced22007aa096d8af04ba1b963312822804f4c15b0b227d66af49565034437691b7760e7ff6d1e3f8b10b898906362
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 3, 2021
…oper notes

a9e898a docs: Link to python style guidelines from developer notes (Mason Simon)

Pull request description:

  Initially I moved the python style guidelines from the functional test README, but some of the python rules are test-specific, and most of the developer notes doc is C++ centric, so just dropping a link seemed better.

Tree-SHA512: 9d4d5cc45526319a118595d90fcfad2c9aced22007aa096d8af04ba1b963312822804f4c15b0b227d66af49565034437691b7760e7ff6d1e3f8b10b898906362
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 4, 2021
…oper notes

a9e898a docs: Link to python style guidelines from developer notes (Mason Simon)

Pull request description:

  Initially I moved the python style guidelines from the functional test README, but some of the python rules are test-specific, and most of the developer notes doc is C++ centric, so just dropping a link seemed better.

Tree-SHA512: 9d4d5cc45526319a118595d90fcfad2c9aced22007aa096d8af04ba1b963312822804f4c15b0b227d66af49565034437691b7760e7ff6d1e3f8b10b898906362
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants