travis: Enable qt for all jobs #13515

ken2812221 · 2018-06-21T04:10:47Z

If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build.
Enable Qt build for Windows and 32-bit Linux
Enable wallet for depends x86-64 Linux
Disable gui tests for Windows since they are not supported

This would be helpful for upgrading Qt (#12971) and protobuf (#13513)

maflcko · 2018-06-21T12:07:06Z

.travis.yml

 # Win64
-    - HOST=x86_64-w64-mingw32 DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
+    - HOST=x86_64-w64-mingw32 PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests"


Might as well change "install" to "deploy", so we get the setup.exe as well?

maflcko · 2018-06-21T12:31:53Z

Would be nicer if travis natively supported multi-job-multi-stage builds, but yeah, maybe this hack is required.

DrahtBot · 2018-06-30T11:43:22Z

Reviewers, this pull request conflicts with the following ones:

travis: Save cache even when build or test fail #14231 (travis: Save cache even when build or test fail by ken2812221)
[WIP] depends: Add native_nsis to support unicode #13827 ([WIP] depends: Add native_nsis to support unicode by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ken2812221 · 2018-07-18T00:09:37Z

Update: Enable qt for arm

maflcko · 2018-07-18T00:40:43Z

.travis.yml

-    - if [ "$RUN_TESTS" = "true" ]; then DOCKER_EXEC LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib make $MAKEJOBS check VERBOSE=1; fi
-    - if [ "$TRAVIS_EVENT_TYPE" = "cron" ]; then extended="--extended --exclude feature_pruning,feature_dbcrash"; fi
-    - if [ "$RUN_TESTS" = "true" ]; then DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast ${extended}; fi
+    # Skip Bitcoin Core build if depends build take more than 20 mins.


hmm. Not sure about that. We'd have to manually reset travis on all pull requests that are affected by this.

We'd have to manually reset travis on all pull requests that are affected by this.

We can clear the cache of all PRs to solve this just like what we do after migrate tests to docker.

What I mean is that a early exit should not make travis green. Maybe add an echo "Travis early exit to cache current state" && false somewhere?

It does not make travis green. If test $SECONDS -lt 1200 has failed, travis would turn out red. But it's a good idea to add error message.

Ah thanks for the clarification. I missed that.

scravy · 2018-08-01T14:48:08Z

.travis.yml

-    - if [ "$RUN_TESTS" = "true" ]; then BEGIN_FOLD functional-tests; DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast ${extended}; END_FOLD; fi
+    # Skip Bitcoin Core build if depends build take more than 20 mins.
+    - |
+      ( test $SECONDS -lt 1200 || ( echo Travis early exit to cache current state && false ) ) && (


This could simply be its own line in the script section.

I really like the rest of the script to be joined into a single block using the | YAML goodness, but putting this check on an individual line (- ...) would spare the ) && ( LOTSOFLINES ) awkwardness.

As I learned in #13863 – if you split the script like that then the exit codes of the commands in each line will not make the script fail, i.e. if the unit tests fail the build will not fail.

Thanks, I'll work on this after #13836 merged.

ken2812221 · 2018-08-03T15:39:55Z

It's time to make Mac build work on master again.

scravy · 2018-08-03T17:47:41Z

.travis.yml

-    - if [ "$RUN_TESTS" = "true" ]; then BEGIN_FOLD functional-tests; DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast ${extended}; END_FOLD; fi
+    # Skip Bitcoin Core build if depends build take more than 20 mins.
+    - |
+      ( test $SECONDS -lt 1200 || ( echo Travis early exit to cache current state && false ) ) && (


As I learned in #13863 – if you split the script like that then the exit codes of the commands in each line will not make the script fail, i.e. if the unit tests fail the build will not fail.

scravy · 2018-08-03T17:50:07Z

.travis.yml

@@ -123,12 +123,11 @@ jobs:
        RUN_TESTS=true
        GOAL="install"
        BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --enable-glibc-back-compat --enable-reduce-exports --with-gui=qt5 CPPFLAGS=-DDEBUG_LOCKORDER"
-# x86_64 Linux, No wallet
+# x86_64 Linux


Is this change intentional? I find it very handy to have a NO_WALLET build available. It has happened to me before that I changed something in a way which required the wallet in a place which does not require a wallet overall. This particular travis build caught that.

Sorry, I just noticed your description does mention that. So it is intentional. My comment still stands though, I find it beneficial to have a no-wallet build available. In a perfect world a build would build all possible combinations of build flags, in this imperfect world it can at least check the no-wallet case.

Indeed, will undo this.

ken2812221 · 2018-09-01T17:00:02Z

This is ready for review. Thanks for #13863, I don't have to do a lot of line changes.

maflcko · 2018-09-04T19:56:37Z

As this is effectively reverting a33b7c9, could the GOALs be changed to deploy?

ken2812221 · 2018-09-05T09:29:50Z

@MarcoFalke Changed goals to deploy, also revert 3d69853 because of cf01fd6

.travis.yml

Sjors

Concept ACK

Sjors · 2018-10-26T03:49:51Z

.travis.yml

@@ -34,7 +34,7 @@ install:
 before_script:
  - set -o errexit; source .travis/test_05_before_script.sh
 script:
-  - set -o errexit; source .travis/test_06_script.sh
+  - if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; source .travis/test_06_script.sh; fi


Should this be in the before_script?

before_script does the depends build, which should be cached, so no?

I didn't know chache was discared during a premature exit. If so, then this makes sense.

3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee) Pull request description: - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build. - Enable Qt build for Windows and 32-bit Linux - Enable wallet for depends x86-64 Linux - Disable gui tests for Windows since they are not supported This would be helpful for upgrading Qt (#12971) and protobuf (#13513) Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9

3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee) Pull request description: - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build. - Enable Qt build for Windows and 32-bit Linux - Enable wallet for depends x86-64 Linux - Disable gui tests for Windows since they are not supported This would be helpful for upgrading Qt (bitcoin#12971) and protobuf (bitcoin#13513) Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9

fanquake added the Tests label Jun 21, 2018

maflcko reviewed Jun 21, 2018

View reviewed changes

laanwj requested a review from theuni June 24, 2018 14:49

DrahtBot mentioned this pull request Jun 30, 2018

travis: Switch back to trusty for now #13562

Closed

ken2812221 changed the title ~~travis: Enable Qt build for Windows and 32-bit Linux~~ travis: Enable Qt build for Windows , i686 and arm Linux Jul 18, 2018

maflcko reviewed Jul 18, 2018

View reviewed changes

DrahtBot mentioned this pull request Jul 27, 2018

travis: improve readability of travis.yml and log outputs #13779

Merged

DrahtBot added Needs rebase and removed Needs rebase labels Jul 30, 2018

This was referenced Aug 1, 2018

travis: WIP - build and run tests on os: osx #13816

Closed

travis: Run bench_bitcoin once #13811

Merged

[WIP] depends: Add native_nsis to support unicode #13827

Closed

scravy reviewed Aug 1, 2018

View reviewed changes

DrahtBot added the Needs rebase label Aug 2, 2018

ken2812221 changed the title ~~travis: Enable Qt build for Windows , i686 and arm Linux~~ travis: avoid timeout without saving caches, also enable all qt Aug 3, 2018

DrahtBot removed the Needs rebase label Aug 3, 2018

DrahtBot mentioned this pull request Aug 3, 2018

travis: move script sections to files in .travis/ subject to shellcheck #13863

Merged

scravy suggested changes Aug 3, 2018

View reviewed changes

DrahtBot mentioned this pull request Aug 5, 2018

Test for Windows encoding issue #13787

Merged

DrahtBot mentioned this pull request Aug 14, 2018

~~Correctly~~ terminate HTTP server #13501

Closed

DrahtBot mentioned this pull request Aug 23, 2018

travis: Run unit tests --with-sanitizers=undefined #14036

Merged

DrahtBot added Needs rebase and removed Needs rebase labels Aug 27, 2018

ken2812221 closed this Aug 30, 2018

ken2812221 deleted the travis_qt branch August 30, 2018 13:04

ken2812221 restored the travis_qt branch August 30, 2018 17:50

ken2812221 reopened this Aug 30, 2018

ken2812221 changed the title ~~travis: avoid timeout without saving caches, also enable all qt~~ travis: Avoid being timeout without saving caches, also enable qt builds for all jobs if available Sep 1, 2018

maflcko reviewed Sep 5, 2018

View reviewed changes

.travis.yml Show resolved Hide resolved

DrahtBot mentioned this pull request Sep 8, 2018

travis: Run property based testing #14171

Closed

travis: avoid timeout without saving caches, also enable all qt

3387bb0

DrahtBot mentioned this pull request Sep 16, 2018

travis: Save cache even when build or test fail #14231

Merged

ken2812221 changed the title ~~travis: Avoid being timeout without saving caches, also enable qt builds for all jobs if available~~ travis: Avoid timeout without saving caches, also enable qt builds for all jobs if available Sep 30, 2018

ken2812221 changed the title ~~travis: Avoid timeout without saving caches, also enable qt builds for all jobs if available~~ travis: Enable qt for all jobs Oct 11, 2018

ken2812221 mentioned this pull request Oct 25, 2018

Add BIP70 deprecation warning and allow building GUI without BIP70 support #14451

Merged

Sjors reviewed Oct 26, 2018

View reviewed changes

maflcko merged commit 3387bb0 into bitcoin:master Oct 26, 2018

ken2812221 deleted the travis_qt branch October 27, 2018 07:47

sickpig mentioned this pull request Jan 18, 2019

Improve travis caching BitcoinUnlimited/BitcoinUnlimited#1559

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

travis: Enable qt for all jobs #13515

travis: Enable qt for all jobs #13515

ken2812221 commented Jun 21, 2018 •

edited

Loading

maflcko Jun 21, 2018

ken2812221 Jun 21, 2018

maflcko commented Jun 21, 2018

DrahtBot commented Jun 30, 2018 •

edited

Loading

ken2812221 commented Jul 18, 2018

maflcko Jul 18, 2018

ken2812221 Jul 18, 2018

maflcko Jul 18, 2018

ken2812221 Jul 18, 2018

maflcko Jul 18, 2018

scravy Aug 1, 2018 •

edited

Loading

scravy Aug 3, 2018

ken2812221 Aug 6, 2018

ken2812221 commented Aug 3, 2018

scravy Aug 3, 2018

scravy Aug 3, 2018

scravy Aug 3, 2018

ken2812221 Aug 6, 2018

ken2812221 commented Sep 1, 2018

maflcko commented Sep 4, 2018

ken2812221 commented Sep 5, 2018

Sjors left a comment

Sjors Oct 26, 2018

maflcko Oct 26, 2018

Sjors Oct 27, 2018

travis: Enable qt for all jobs #13515

travis: Enable qt for all jobs #13515

Conversation

ken2812221 commented Jun 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maflcko commented Jun 21, 2018

DrahtBot commented Jun 30, 2018 • edited Loading

ken2812221 commented Jul 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scravy Aug 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ken2812221 commented Aug 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ken2812221 commented Sep 1, 2018

maflcko commented Sep 4, 2018

ken2812221 commented Sep 5, 2018

Sjors left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ken2812221 commented Jun 21, 2018 •

edited

Loading

DrahtBot commented Jun 30, 2018 •

edited

Loading

scravy Aug 1, 2018 •

edited

Loading