depends: Upgrade Qt to 5.9.6 #12971

TheCharlatan · 2018-04-13T00:07:25Z

With the introduction of Ubuntu 18.04 (Bionic Beaver) modern versions of gcc and mingw that allow cross compilation of versions of Qt greater than 5.8 are now readily available. This pull requests upgrades the Qt depends recipe from Qt 5.7.1 to Qt 5.9.6. Qt 5.9.x is the current LTS version and should be supported by Qt until 2020.

maflcko · 2018-04-13T00:56:40Z

According to https://doc.qt.io/qt-5.10/supported-platforms-and-configurations.html#qt-5-9 gcc4.8 is supported. Also, I could build your receipt on ubuntu trusty, which comes with gcc4.8. I think you can get rid of the optional flag to compile qt5.9?

Edit: I didn't try windows or mac cross builds, so those might be causing issues ... ?

fanquake · 2018-04-13T01:23:43Z

The plan is to just move depends to Qt 5.9+ quite soon, I have been delayed doing that work.
I don't think we want to want to have support for 5.7 and 5.9 in depends at the same time.
Would you be interested in turning this work into a Qt 5.7 -> 5.9 upgrade?

TheCharlatan · 2018-04-13T07:37:02Z

@MarcoFalke The compiler version for linux native compilation is not a problem. It is though as soon as you are trying to cross compile to windows (which requires Mingw5.3).
I originally did not want to open the pr for this reason, since it would mean that the current travis tests would be broken because of the windows build requirement. I heard though that @theuni is working on getting the entire toolchain on depends, so I decided to publish the patch nevertheless to prevent duplicate work and enable other developers to already compile bitcoin static with a modern Qt version.

The macos build needs some further investigation. It fails upon creating qmake and the current qmake patch does not seem to work. Upon some investigation, I saw that multiple people had to do some manual property setting on xcode to make the build work. I am not sure if this is related though.

maflcko · 2018-04-13T13:35:14Z

cross compile to windows (which requires Mingw5.3)

Hmm. Imo we could drop support for cross-compile to windows on trusty and just require xenial or above.

maflcko · 2018-04-15T15:51:56Z

Could do a rebase since #12946 is merged?

TheCharlatan · 2018-04-15T16:40:23Z

Rebased.

fanquake · 2018-04-16T02:10:43Z

@TheCharlatan Thanks for the work so far, however did you see my comment above? I think this would be better as a straight 5.7 -> 5.9 upgrade, instead of adding an additional version of Qt to depends. We would like to use Qt 5.9+ to build the next release anyways.

Regardless of the that this needs a few fixes.

There are currently whitespace linting errors.

A linux Travis build is currently failing:
linux-raw-log.txt

configure: error: Package requirements (Qt5PlatformSupport) were not met:
No package 'Qt5PlatformSupport' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables QTPLATFORM_CFLAGS
and QTPLATFORM_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
It was created by Bitcoin Core configure 0.16.99, which was
generated by GNU Autoconf 2.69.  Invocation command line was
  $ ../configure --cache-file=config.cache --disable-dependency-tracking --prefix=/home/travis/build/bitcoin/bitcoin/depends/x86_64-unknown-linux-gnu --bindir=/home/travis/build/bitcoin/bitcoin/out/12971/27461.7-x86_64-unknown-linux-gnu/bin --libdir=/home/travis/build/bitcoin/bitcoin/out/12971/27461.7-x86_64-unknown-linux-gnu/lib --enable-glibc-back-compat --enable-reduce-exports

The macOS build would also need to be fixed/updated:
macOS-raw-log.txt

Configuring qt59...
Creating qmake...
make[1]: Entering directory `/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/qt59/5.9.4-01715d30425/qtbase/qmake'
make[1]: Leaving directory `/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/qt59/5.9.4-01715d30425/qtbase/qmake'
Info: creating cache file /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/qt59/5.9.4-01715d30425/qtbase/.qmake.cache
Command line: -bindir /home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/native/bin -c++std c++11 -confirm-license -dbus-runtime -hostprefix /home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/native -no-cups -no-egl -no-eglfs -no-freetype -no-gif -no-glib -no-icu -no-iconv -no-kms -no-linuxfb -no-libudev -no-mtdev -no-openvg -no-reduce-relocations -no-qml-debug -no-sql-db2 -no-sql-ibase -no-sql-oci -no-sql-tds -no-sql-mysql -no-sql-odbc -no-sql-psql -no-sql-sqlite -no-sql-sqlite2 -no-use-gold-linker -nomake examples -nomake tests -opensource -openssl-linked -optimized-qmake -pch -pkg-config -prefix /home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11 -qt-libpng -qt-libjpeg -qt-pcre -system-zlib -static -silent -v -release -xplatform macx-clang-linux -device-option MAC_SDK_PATH=/home/travis/build/bitcoin/bitcoin/depends/SDKs/MacOSX10.11.sdk -device-option MAC_SDK_VERSION=10.11 -device-option CROSS_COMPILE=x86_64-apple-darwin11- -device-option MAC_MIN_VERSION=10.8 -device-option MAC_TARGET=x86_64-apple-darwin11 -device-option MAC_LD64_VERSION=253.9
Project ERROR: Could not resolve SDK --show-sdk-path for 'macosx'
make: *** [/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-apple-darwin11/qt59/5.9.4-01715d30425/qtbase/.stamp_configured] Error 3
make: Leaving directory `/home/travis/build/bitcoin/bitcoin/depends'

fanquake · 2018-04-16T02:13:36Z

depends/packages/packages.mk

 qt_i686_linux_packages:=$(qt_x86_64_linux_packages)

-qt_darwin_packages=qt


This looks like it's building QT 5.9 in either case?

TheCharlatan · 2018-04-16T06:55:47Z

@fanquake thanks for the review.
If I were to change this to a straight upgrade, how would travis, or gitian windows builds be done?

maflcko · 2018-04-16T12:39:52Z

Our gitian descriptors will be switched to bionic soon: #12511. Similarly, we can switch travis to xenial. Those will happen in separate pull request, so don't worry about them.

laanwj · 2018-05-14T13:19:51Z

Travis fails on linux 64 bit with:

checking for QTPLATFORM... no
configure: error: Package requirements (Qt5PlatformSupport) were not met:
No package 'Qt5PlatformSupport' found

And OSX:

Project ERROR: Could not resolve SDK --show-sdk-path for 'macosx'

maflcko · 2018-05-14T13:25:18Z

See also #13215

TheCharlatan · 2018-05-16T00:20:54Z

Removed the optional flags, Qt5.9.4 is now the new default. The build still fails on MacOS.

fanquake · 2018-05-16T00:58:02Z

@TheCharlatan Can you fixup any trailing whitespace so that Travis will run: https://travis-ci.org/bitcoin/bitcoin/jobs/379496754

maflcko · 2018-05-16T02:20:48Z

depends/README.md

@@ -12,6 +12,10 @@ For example:

    make HOST=x86_64-w64-mingw32 -j4

+To build the more recent Qt5.9.4, you can build depends with
+
+  make HOST=host-platform-triple QT_59=1


Can remove this hunk and all other references to qt 5.9?

maflcko · 2018-05-17T12:54:13Z

depends/packages/qt.mk

@@ -75,12 +64,10 @@ $(package)_config_opts += -qt-libpng
 $(package)_config_opts += -qt-libjpeg
 $(package)_config_opts += -qt-pcre
 $(package)_config_opts += -system-zlib
-$(package)_config_opts += -reduce-exports
+#$(package)_config_opts += -reduce-exports


nit: Either remove or replace with proper comment/reasoning.

maflcko · 2018-05-17T12:55:45Z

doc/build-windows.md

+    ./autogen.sh # not required when building from tarball
+    CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure --prefix=/ --enable-qt59
+    make
+


This whole section is added in #13246, so feel free to remove this to avoid merge conflicts.

ken2812221 · 2018-05-17T15:37:09Z

This should fix the problem. Patch from QTBUG-67286
[removed]

ken2812221 · 2018-05-18T09:34:37Z

This additional patch should fix all Mac and Windows build:
[removed]

ken2812221 · 2018-05-18T10:51:15Z

You committed the wrong patch, it's not fix-cocoahelpers-macos.patch but fix_no_printer.patch

Sjors

Tested 77fd4f8 on macOS 10.13.5 (did a make clean-all first). Also ran the tests.

@fanquake wrote:

this will likely bump the minimum required macOS version to 10.10. Which probably requires further discussion.

macOS 10.10 Yosemite indeed: https://doc-snapshots.qt.io/qt5-5.9/osx.html

See #13362 for discussion.

Sjors · 2018-07-06T11:00:15Z

build-aux/m4/bitcoin_qt.m4

+
+
+dnl Internal. Check if the linked version of Qt was built as static libs.
+dnl Requires: Qt5. This check cannot determine if Qt4 is static.


Nit: no need to reference Qt4 anymore

Sjors · 2018-07-06T11:03:02Z

depends/packages/qt.mk

 $(package)_file_name=qtbase-$($(package)_suffix)
-$(package)_sha256_hash=95f83e532d23b3ddbde7973f380ecae1bac13230340557276f75f2e37984e410
+$(package)_sha256_hash=eed620cb268b199bd83b3fc6a471c51d51e1dc2dbb5374fc97a0cc75facbe36f


Can confirm eed620cb268b199bd83b3fc6a471c51d51e1dc2dbb5374fc97a0cc75facbe36f matches https://download.qt.io/archive/qt/5.9/5.9.6/submodules/qtbase-opensource-src-5.9.6.tar.xz.mirrorlist

Sjors · 2018-07-06T11:03:19Z

depends/packages/qt.mk

-$(package)_download_path=https://download.qt.io/archive/qt/5.7/$($(package)_version)/submodules
-$(package)_suffix=opensource-src-$($(package)_version).tar.gz
+$(package)_version=5.9.6
+$(package)_download_path=http://download.qt.io/official_releases/qt/5.9/$($(package)_version)/submodules


Why the http downgrade?

Thanks, missed this during rebase.

Sjors · 2018-07-06T11:05:11Z

depends/packages/qt.mk

@@ -29,25 +27,18 @@ $(package)_config_opts += -c++std c++11
 $(package)_config_opts += -confirm-license
 $(package)_config_opts += -dbus-runtime
 $(package)_config_opts += -hostprefix $(build_prefix)
-$(package)_config_opts += -no-alsa


Is the reason we can drop these lines that these options been removed from QT?

The config_opts lines I removed are no longer supported by qt's configure.

Sjors · 2018-07-06T11:06:15Z

depends/packages/qt.mk

 $(package)_config_opts_linux += -fontconfig
 $(package)_config_opts_linux += -no-opengl
 $(package)_config_opts_arm_linux  = -platform linux-g++ -xplatform $(host)
 $(package)_config_opts_i686_linux  = -xplatform linux-g++-32
+$(package)_config_opts_x86_64_linux = -xplatform linux-g++-64


I can try building these depends on an arm64 device soon.

cd depends && make doesn't build QT when run from a aarch64 host, so nvm :-)

laanwj · 2018-07-09T15:55:08Z

utACK 800dea8

800dea8 Upgrade Qt depends to 5.9.6 (Sebastian Kung) 70afa65 Fix depends Qt5.9.4 mac build (Ken Lee) 28482ef Ugrade Qt depends to Qt5.9.4 (Sebastian Kung) Pull request description: With the introduction of Ubuntu 18.04 (Bionic Beaver) modern versions of gcc and mingw that allow cross compilation of versions of Qt greater than 5.8 are now readily available. This pull requests upgrades the Qt depends recipe from Qt 5.7.1 to Qt 5.9.6. Qt 5.9.x is the current LTS version and should be supported by Qt until 2020. Tree-SHA512: 439295d594ff8954a5ba5e348a0452713721c805485be2edcb9f8603ee59e96db5a61e1c684bdff36bbfd643a79cd35c289817257af88f489d2890e7843460bf

3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee) Pull request description: - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build. - Enable Qt build for Windows and 32-bit Linux - Enable wallet for depends x86-64 Linux - Disable gui tests for Windows since they are not supported This would be helpful for upgrading Qt (#12971) and protobuf (#13513) Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9

800dea8 Upgrade Qt depends to 5.9.6 (Sebastian Kung) 70afa65 Fix depends Qt5.9.4 mac build (Ken Lee) 28482ef Ugrade Qt depends to Qt5.9.4 (Sebastian Kung) Pull request description: With the introduction of Ubuntu 18.04 (Bionic Beaver) modern versions of gcc and mingw that allow cross compilation of versions of Qt greater than 5.8 are now readily available. This pull requests upgrades the Qt depends recipe from Qt 5.7.1 to Qt 5.9.6. Qt 5.9.x is the current LTS version and should be supported by Qt until 2020. Tree-SHA512: 439295d594ff8954a5ba5e348a0452713721c805485be2edcb9f8603ee59e96db5a61e1c684bdff36bbfd643a79cd35c289817257af88f489d2890e7843460bf

Ugrade Qt depends to Qt5.9.4 Depends can now be built with Qt5.9.4 , which is Qt's new long term support version. Fix depends Qt5.9.4 mac build Apply patch from QTBUG-67286 Upgrade Qt depends to 5.9.6

A fix for QTBUG-34748 was introduced in bitcoin#5915 (v0.11.0, Qt 5.2.1). QTBUG-34748 was fixed in version 5.3.0. The separated patch file, provided by bitcoin#5915, was dropped in bitcoin#12971 while bumping Qt to 5.9.4 (5.9.6). But libxcb.mk remained unchanged. This change reverts bitcoin#5915 for libxcb.mk.

173ef89 build: Small libxcb.mk improvements (Hennadii Stepanov) 5129b36 build: Clean remnants of QTBUG-34748 fix (Hennadii Stepanov) Pull request description: Hope, this PR will make [transit](#21376) to Qt 5.12.10 neater. A fix for [QTBUG-34748](https://bugreports.qt.io/browse/QTBUG-34748) was introduced in #5915 (v0.11.0, Qt 5.2.1). [QTBUG-34748](https://bugreports.qt.io/browse/QTBUG-34748) was [fixed](qt/qtbase@b19b080) in Qt 5.3.0. The separated [`fix-xcb-include-order.patch`](https://github.com/theuni/bitcoin/blob/bb44d9e7546e6118cd91db5bbe471a3ce2ee7fcd/depends/patches/qt/fix-xcb-include-order.patch), provided by #5915, was dropped in #12971 while bumping Qt to 5.9.4 (5.9.6). But `libxcb.mk` remained unchanged. This PR reverts #5915 for `libxcb.mk` as well. ACKs for top commit: practicalswift: cr ACK 173ef89: patch looks correct fanquake: ACK 173ef89 Tree-SHA512: 9815a7e532ff4aa08f9623ded8d5708eca1c9c73ac7a2684419a18c125da7627b44ac3191f2e7978946942c8d0580e73b1a93df624986fb2a13791a68ce1e025

173ef89 build: Small libxcb.mk improvements (Hennadii Stepanov) 5129b36 build: Clean remnants of QTBUG-34748 fix (Hennadii Stepanov) Pull request description: Hope, this PR will make [transit](bitcoin#21376) to Qt 5.12.10 neater. A fix for [QTBUG-34748](https://bugreports.qt.io/browse/QTBUG-34748) was introduced in bitcoin#5915 (v0.11.0, Qt 5.2.1). [QTBUG-34748](https://bugreports.qt.io/browse/QTBUG-34748) was [fixed](qt/qtbase@b19b080) in Qt 5.3.0. The separated [`fix-xcb-include-order.patch`](https://github.com/theuni/bitcoin/blob/bb44d9e7546e6118cd91db5bbe471a3ce2ee7fcd/depends/patches/qt/fix-xcb-include-order.patch), provided by bitcoin#5915, was dropped in bitcoin#12971 while bumping Qt to 5.9.4 (5.9.6). But `libxcb.mk` remained unchanged. This PR reverts bitcoin#5915 for `libxcb.mk` as well. ACKs for top commit: practicalswift: cr ACK 173ef89: patch looks correct fanquake: ACK 173ef89 Tree-SHA512: 9815a7e532ff4aa08f9623ded8d5708eca1c9c73ac7a2684419a18c125da7627b44ac3191f2e7978946942c8d0580e73b1a93df624986fb2a13791a68ce1e025

Ugrade Qt depends to Qt5.9.4 Depends can now be built with Qt5.9.4 , which is Qt's new long term support version. Fix depends Qt5.9.4 mac build Apply patch from QTBUG-67286 Upgrade Qt depends to 5.9.6

3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee) Pull request description: - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build. - Enable Qt build for Windows and 32-bit Linux - Enable wallet for depends x86-64 Linux - Disable gui tests for Windows since they are not supported This would be helpful for upgrading Qt (bitcoin#12971) and protobuf (bitcoin#13513) Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9

fanquake added the Build system label Apr 13, 2018

fanquake requested a review from theuni April 13, 2018 01:23

TheCharlatan force-pushed the Qt59 branch from a1724f5 to f870067 Compare April 15, 2018 16:39

fanquake reviewed Apr 16, 2018

View reviewed changes

TheCharlatan force-pushed the Qt59 branch from f870067 to c54068f Compare May 16, 2018 00:19

TheCharlatan force-pushed the Qt59 branch from c54068f to 0ebfcbc Compare May 16, 2018 00:47

TheCharlatan force-pushed the Qt59 branch from 0ebfcbc to cc557dc Compare May 16, 2018 00:59

maflcko reviewed May 16, 2018

View reviewed changes

maflcko reviewed May 17, 2018

View reviewed changes

TheCharlatan force-pushed the Qt59 branch from cc557dc to 39d208f Compare May 17, 2018 16:23

TheCharlatan force-pushed the Qt59 branch from 39d208f to e809ee0 Compare May 18, 2018 10:33

TheCharlatan force-pushed the Qt59 branch 2 times, most recently from 7ba4aac to 51a5430 Compare May 18, 2018 11:57

Sjors approved these changes Jul 6, 2018

View reviewed changes

Upgrade Qt depends to 5.9.6

800dea8

TheCharlatan force-pushed the Qt59 branch from 77fd4f8 to 800dea8 Compare July 6, 2018 13:04

TheCharlatan mentioned this pull request Jul 6, 2018

Add depends 32-bit arm support for bitcoin-qt #13604

Merged

laanwj merged commit 800dea8 into bitcoin:master Jul 9, 2018

Sjors mentioned this pull request Jul 10, 2018

[RFC] gui: Minimum required Qt5 #13478

Closed

Bushstar mentioned this pull request Jul 13, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#354

Merged

Fuzzbawls mentioned this pull request Jul 21, 2018

Gitian builds no longer deterministic #13731

Closed

This was referenced Sep 21, 2018

Bump to Qt5.9.6 & remove Qt4 Support dustinengle/Bulwark#6

Closed

Bump to Qt5.9.6 & remove Qt4 Support dustinengle/Bulwark#7

Merged

fanquake mentioned this pull request Jul 24, 2019

depends: disable unused Qt features #16386

Merged

jonasschnelli mentioned this pull request Nov 12, 2019

Add TheCharlatan's pgp key #17436

Merged

hebasto mentioned this pull request Mar 7, 2021

build: Clean remnants of QTBUG-34748 fix #21382

Merged

hebasto mentioned this pull request Apr 3, 2021

build, qt: Native Qt builds in depends do not work #21588

Closed

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

depends: Upgrade Qt to 5.9.6 #12971

depends: Upgrade Qt to 5.9.6 #12971

TheCharlatan commented Apr 13, 2018 •

edited

Loading

maflcko commented Apr 13, 2018 •

edited

Loading

fanquake commented Apr 13, 2018 •

edited

Loading

TheCharlatan commented Apr 13, 2018

maflcko commented Apr 13, 2018

maflcko commented Apr 15, 2018

TheCharlatan commented Apr 15, 2018

fanquake commented Apr 16, 2018

fanquake Apr 16, 2018

TheCharlatan commented Apr 16, 2018

maflcko commented Apr 16, 2018

laanwj commented May 14, 2018

maflcko commented May 14, 2018

TheCharlatan commented May 16, 2018

fanquake commented May 16, 2018

maflcko May 16, 2018

maflcko May 17, 2018

maflcko May 17, 2018

ken2812221 commented May 17, 2018 •

edited

Loading

ken2812221 commented May 18, 2018 •

edited

Loading

ken2812221 commented May 18, 2018

Sjors left a comment

Sjors Jul 6, 2018

Sjors Jul 6, 2018

Sjors Jul 6, 2018

TheCharlatan Jul 6, 2018

Sjors Jul 6, 2018

TheCharlatan Jul 6, 2018

Sjors Jul 6, 2018

Sjors Jul 12, 2018

laanwj commented Jul 9, 2018

		qt_i686_linux_packages:=$(qt_x86_64_linux_packages)

		qt_darwin_packages=qt



		dnl Internal. Check if the linked version of Qt was built as static libs.
		dnl Requires: Qt5. This check cannot determine if Qt4 is static.

depends: Upgrade Qt to 5.9.6 #12971

depends: Upgrade Qt to 5.9.6 #12971

Conversation

TheCharlatan commented Apr 13, 2018 • edited Loading

maflcko commented Apr 13, 2018 • edited Loading

fanquake commented Apr 13, 2018 • edited Loading

TheCharlatan commented Apr 13, 2018

maflcko commented Apr 13, 2018

maflcko commented Apr 15, 2018

TheCharlatan commented Apr 15, 2018

fanquake commented Apr 16, 2018

Choose a reason for hiding this comment

TheCharlatan commented Apr 16, 2018

maflcko commented Apr 16, 2018

laanwj commented May 14, 2018

maflcko commented May 14, 2018

TheCharlatan commented May 16, 2018

fanquake commented May 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ken2812221 commented May 17, 2018 • edited Loading

ken2812221 commented May 18, 2018 • edited Loading

ken2812221 commented May 18, 2018

Sjors left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laanwj commented Jul 9, 2018

TheCharlatan commented Apr 13, 2018 •

edited

Loading

maflcko commented Apr 13, 2018 •

edited

Loading

fanquake commented Apr 13, 2018 •

edited

Loading

ken2812221 commented May 17, 2018 •

edited

Loading

ken2812221 commented May 18, 2018 •

edited

Loading