Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dicoogle3] Fix DICOM storage priority by AE title #495

Merged
merged 1 commit into from
Aug 11, 2021
Merged

[Dicoogle3] Fix DICOM storage priority by AE title #495

merged 1 commit into from
Aug 11, 2021

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Aug 11, 2021

  • invert order for priority AE title
    • its presence should represent a HIGHER priority rather than a lower one
  • move priority implementation to static method so it does not depend on a storage service instance
  • add test to prove that this bug was fixed

@Enet4
Fix DICOM storage priority by AE title
a113277 
(for Dicoogle 3)
- invert order for priority AE title
   - its presence should represent a HIGHER priority rather than a lower one
- move priority implementation to static method so it does not depend on a storage service instance
- add test to prove that this bug was fixed
@Enet4 Enet4 requested a review from bastiao August 11, 2021 15:02
@bastiao bastiao merged commit 00c8a57 into dev Aug 11, 2021
@Enet4 Enet4 deleted the bug/dicoogle3_storagepriority_flip branch August 11, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiao bastiao

Assignees
No one assigned
Labels
bug dicoogle-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enet4 @bastiao