Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc | first-steps/post-deployment: add procedure to add new aws accounts. #168

Merged
merged 10 commits into from
Apr 13, 2023
Merged

Doc | first-steps/post-deployment: add procedure to add new aws accounts. #168

merged 10 commits into from
Apr 13, 2023

Conversation

rodriguez-matias
Copy link
Contributor

What?

  • Add a new section "add new aws accounts" in the post-deployment page.

Why?

  • So that users have a closer and clearer procedure, of How to create and add new aws accounts after finishing the Leverage first landing.

References

@rodriguez-matias rodriguez-matias requested a review from a team as a code owner April 10, 2023 13:28
@rodriguez-matias rodriguez-matias self-assigned this Apr 10, 2023
@rodriguez-matias rodriguez-matias added the documentation Improvements or additions to documentation label Apr 10, 2023
angelofenoglio
angelofenoglio reviewed Apr 10, 2023
View reviewed changes
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
diego-ojeda-binbash and others added 4 commits April 10, 2023 11:52
@diego-ojeda-binbash @angelofenoglio
Update docs/first-steps/post-deployment.md
4fc0587 
Co-authored-by: Angelo Fenoglio <angelofenoglio@gmail.com>
@diego-ojeda-binbash @angelofenoglio
Update docs/first-steps/post-deployment.md
5f21406 
Co-authored-by: Angelo Fenoglio <angelofenoglio@gmail.com>
@diego-ojeda-binbash @angelofenoglio
Update docs/first-steps/post-deployment.md
e259780 
Co-authored-by: Angelo Fenoglio <angelofenoglio@gmail.com>
@diego-ojeda-binbash @angelofenoglio
Update docs/first-steps/post-deployment.md
139cf5f 
Co-authored-by: Angelo Fenoglio <angelofenoglio@gmail.com>
angelofenoglio
angelofenoglio reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@angelofenoglio angelofenoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, this, alongside the unresolved suggestion should make a full change.

docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
@rodriguez-matias
Copy link
Contributor Author

Hello everyone! With the commit of @juanmatias, all the proposed changes have been resolved.
If you agree, I think we are ready to merge this PR, right?

@rodriguez-matias rodriguez-matias merged commit 00e3ec3 into master Apr 13, 2023
@rodriguez-matias rodriguez-matias deleted the ISSUE-158/doc/add-new-account branch April 13, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-ojeda-binbash diego-ojeda-binbash diego-ojeda-binbash approved these changes

@exequielrafaela exequielrafaela exequielrafaela approved these changes

@Franr Franr Awaiting requested review from Franr

@angelofenoglio angelofenoglio Awaiting requested review from angelofenoglio

Assignees

@rodriguez-matias rodriguez-matias

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement | Document how to add a new account after creating the landing zone
5 participants
@rodriguez-matias @exequielrafaela @angelofenoglio @diego-ojeda-binbash @juanmatias