feat: redesign app #491
Merged
feat: redesign app #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update safe-react-components and use the new theme to redesign the app. This requires an update of MUI to v5 and removes styled-components. All wrapped MUI components were removed meaning that we have to use the native MUI components across the app. Improvements: - Uses dark mode if OS of user is set to dark appearance - Improves design / flow of the app
bh2smith
approved these changes
Feb 23, 2023
Comment on lines
+30
to
+33
| "@safe-global/safe-apps-provider": "^0.16.0", | ||
| "@safe-global/safe-apps-react-sdk": "^4.6.4", | ||
| "@safe-global/safe-apps-sdk": "^7.10.0", | ||
| "@safe-global/safe-react-components": "2.0.3", |
Comment on lines
+12
to
+13
| const isDarkMode = useDarkMode(); | ||
| const themeMode = isDarkMode ? "dark" : "light"; |
| <SafeProvider | ||
| loader={ | ||
| <> | ||
| <Typography>Waiting for Safe...</Typography> |
There was a problem hiding this comment.
I am surprised that we need to put this ourselves. Seems like it should just be the default.
Comment on lines
-21
to
-22
| Send arbitrarily many distinct tokens, to arbitrarily many distinct accounts with various different values from | ||
| a CSV file in a single transaction. |
There was a problem hiding this comment.
Does this mean the app no longer had a short description in the App Store tile?
There was a problem hiding this comment.
No the description in the AppStore is in our manifest file
| @@ -22,6 +39,7 @@ export const DonateDialog = ({ | |||
| const { safe } = useSafeAppsSDK(); | |||
| const dispatch = useAppDispatch(); | |||
| const csvContent = useCsvContent(); | |||
| const darkMode = useDarkMode(); | |||
| @@ -14,10 +20,22 @@ export const Summary = (props: SummaryProps): JSX.Element => { | |||
| const { assetTransfers, collectibleTransfers } = props; | |||
| const assetTxCount = assetTransfers.length; | |||
| const collectibleTxCount = collectibleTransfers.length; | |||
| const darkMode = useDarkMode(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update safe-react-components and use the new theme to redesign the app.
This requires an update of MUI to v5 and removes styled-components.
All wrapped MUI components were removed meaning that we have to use the native MUI components across the app.
Further Improvements: