adds test for token list fetching #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Feb 11, 2022
bh2smith
approved these changes
Feb 16, 2022
src/__tests__/tokenList.test.ts
Outdated
Comment on lines
54
to
56
| const resultingTokens = await fetchTokenList(1); | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | ||
| expect(resultingTokens).to.be.empty; |
There was a problem hiding this comment.
Could you avoid the lint ignore by putting the await statement directly into the expect?
There was a problem hiding this comment.
The problem here is that the to.be.empty is not a function so it looks like a normal expression which is not used.
But in fact this actually does something (checking if the object ist empty). There are other tests with the same issue.
I found a more elegant solution which disabled this rule for all test files by including this in the eslint config:
{
"overrides": [
{
"files": ["*.test.ts", "*.test.tsx"],
"rules": {
"no-unused-expressions": "off"
}
}
]
}
We use chai for testing and the empty check is always a false positive finding.
|
Looks ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small test case which would have found the error while fetching / parsing the token list.