update all safe dependencies #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmanu
approved these changes
Feb 11, 2022
| @@ -1,12 +1,6 @@ | |||
| module.exports = { | |||
| plugins: ["import"], | |||
| extends: [ | |||
| "plugin:import/recommended", | |||
There was a problem hiding this comment.
Why was this rule removed?
If I add it locally it does not cause any problems.
There was a problem hiding this comment.
I think its because I was using a different node version. We probably don't need to fix this. I have tried with v14 (as specified here in the our package file). I think I was trying to use v17. Will revert this change.
There was a problem hiding this comment.
This is the problem for me (even with v14)
Creating an optimized production build...
Failed to compile.
Plugin "import" was conflicted between ".eslintrc.js" and ".eslintrc.js » plugin:import/recommended".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #348 and #349
Had to change the build script (which is weird).