Display app even for unknown networks #325
Conversation
|
@bh2smith |
|
This is already deployed to IPFS (available in PR description). The failing build here are just warnings that I will fix nonetheless and redeploy ASAP. New deployment hash (without warnings) is https://bafybeiepy5xhantx776xnp5pb3442de3kp4owmoc36e5ni23optcauam44.ipfs.infura-ipfs.io/ will also update the PR description. |
|
Hey @bh2smith , I think we should at least put a warning that the app has not officially been released / tested for the chosen network. Otherwise this looks good. |
| @@ -51,7 +50,7 @@ const App: React.FC = () => { | |||
| return ( | |||
| <Container> | |||
| <Header /> | |||
| {networkMap.has(safe.chainId) ? ( | |||
There was a problem hiding this comment.
Here we should add a warning or a small warning banner on top of the app.
We could also separate this into an issue and I add it in January.
There was a problem hiding this comment.
I would prefer to keep that separate (not even sure what the warning should say) and let you do it in January if you don't mind.
|
@bh2smith perfect... it worked. thanks! |
|
Cool then we will merge this but I won't plan to publish a new release until a few more fixes come in. Alright for you to use the deployed version linked here? |
If this works, this PR closes #324
By removing the "unsupported network" page for unknown networks.
This version is deployed at IPFS hash: QmTef26dDY2XABj84ioRBpFk7vZPRmSkNJ2eYJeKMnTMk9
and can be tested by loading this app into the safe interface
https://bafybeiepy5xhantx776xnp5pb3442de3kp4owmoc36e5ni23optcauam44.ipfs.infura-ipfs.io/
Please try it out @sirpy and let us know if this is what you were hoping for.