Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app stuck on loading tokens and balances on mainnet #357

Closed
schmanu opened this issue Feb 11, 2022 · 3 comments
Closed

app stuck on loading tokens and balances on mainnet #357

schmanu opened this issue Feb 11, 2022 · 3 comments
Assignees
@schmanu

Comments

@schmanu
Copy link
Collaborator

schmanu commented Feb 11, 2022

Right now the app seems to be stuck while loading the safes balances / tokens.
This should never happen as they are not necessary for the app to work. Instead we should display a warning that balance checks are not possible.
@schmanu schmanu self-assigned this Feb 11, 2022
@bh2smith
Copy link
Owner

Looks like this particular uniswap token list has all the addresses:

https://gateway.ipfs.io/ipns/tokens.uniswap.org

@bh2smith
Copy link
Owner

Must be this one:

https://tokens.coingecko.com/uniswap/all.json

@schmanu schmanu mentioned this issue Feb 11, 2022
Closed
@bh2smith
Copy link
Owner

63 Matches.
Screen Shot 2022-02-11 at 12 27 54 PM

schmanu added a commit that referenced this issue Feb 11, 2022
@schmanu
Fixes #357 and #358
20e2b0c 
* Ignores tokens without address in token lists
* Allows to use amount or value column header

Other changes
* row-objects all consitently changed to use value instead of amount
* test for column header backward compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmanu schmanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmanu @bh2smith