Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to clean up multiple hosts with one rm #3

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

nathanleclaire
Copy link

This one was throwing me off since you can use this style with docker ps etc.

ping @bfirsh

Example:

$ ./bundles/1.2.0-dev/binary/docker hosts 
NAME             ACTIVE   DRIVER   STATE   URL
default                                    unix:///var/run/docker.sock
bar                       none             unix:///var/run/docker.sock
foo                       none             unix:///var/run/docker.sock
giantrobot                none             unix:///var/run/docker.sock
godzilla         *        none             unix:///var/run/docker.sock
mischiefwidget            none             unix:///var/run/docker.sock
quux                      none             unix:///var/run/docker.sock
$ ./bundles/1.2.0-dev/binary/docker hosts rm bar foo giantrobot godzilla mischiefwidget quux
$ ./bundles/1.2.0-dev/binary/docker hosts 
NAME      ACTIVE   DRIVER   STATE   URL
default   *                         unix:///var/run/docker.sock

Signed-off-by: Nathan LeClaire nathan.leclaire@gmail.com

Signed-off-by: Nathan LeClaire <nathan.leclaire@gmail.com>
@bfirsh
Copy link
Owner

bfirsh commented Oct 22, 2014

Thanks!

@bfirsh bfirsh merged this pull request into bfirsh:host-management Oct 22, 2014
bfirsh pushed a commit that referenced this pull request Jul 31, 2015
TL;DR: check for IsExist(err) after a failed MkdirAll() is both
redundant and wrong -- so two reasons to remove it.

Quoting MkdirAll documentation:

> MkdirAll creates a directory named path, along with any necessary
> parents, and returns nil, or else returns an error. If path
> is already a directory, MkdirAll does nothing and returns nil.

This means two things:

1. If a directory to be created already exists, no error is returned.

2. If the error returned is IsExist (EEXIST), it means there exists
a non-directory with the same name as MkdirAll need to use for
directory. Example: we want to MkdirAll("a/b"), but file "a"
(or "a/b") already exists, so MkdirAll fails.

The above is a theory, based on quoted documentation and my UNIX
knowledge.

3. In practice, though, current MkdirAll implementation [1] returns
ENOTDIR in most of cases described in #2, with the exception when
there is a race between MkdirAll and someone else creating the
last component of MkdirAll argument as a file. In this very case
MkdirAll() will indeed return EEXIST.

Because of #1, IsExist check after MkdirAll is not needed.

Because of #2 and #3, ignoring IsExist error is just plain wrong,
as directory we require is not created. It's cleaner to report
the error now.

Note this error is all over the tree, I guess due to copy-paste,
or trying to follow the same usage pattern as for Mkdir(),
or some not quite correct examples on the Internet.

[v2: a separate aufs commit is merged into this one]

[1] https://github.com/golang/go/blob/f9ed2f75/src/os/path.go

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants