Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eventbus subscriber name #135

Merged
merged 1 commit into from
May 4, 2023

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented May 4, 2023

add eventbus subcribers name to help montoring bus events state

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.10 🎉

Comparison is base (5288b5d) 62.73% compared to head (7ab1b80) 62.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   62.73%   62.84%   +0.10%     
==========================================
  Files          37       37              
  Lines        2544     2546       +2     
==========================================
+ Hits         1596     1600       +4     
+ Misses        649      648       -1     
+ Partials      299      298       -1     
Flag Coverage Δ
unittests 62.84% <83.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cesscontroller/orbitdb/accesscontroller_orbitdb.go 2.27% <0.00%> (ø)
baseorbitdb/orbitdb.go 70.40% <100.00%> (+0.07%) ⬆️
stores/basestore/base_store.go 58.56% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gfanton gfanton merged commit 368618e into berty:master May 4, 2023
@gfanton gfanton deleted the feat/add-eventbus-metrics branch May 4, 2023 09:58
@github-actions
Copy link

github-actions bot commented May 4, 2023

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants