feat(venv): support pip options #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more information, see https://pre-commit.ci
aarnphm
reviewed
Aug 1, 2024
src/openllm/local.py
Outdated
| venv = ensure_venv(bento) | ||
| cmd, env, cwd = _get_serve_cmd(bento, port=port) | ||
| output(f'Access the Chat UI at http://localhost:{port}/chat (or with you IP)') | ||
| run_command(cmd, env=env, cwd=cwd, venv=venv) | ||
|
|
||
|
|
||
| def prep_env_vars(bento: BentoInfo): | ||
| import os |
There was a problem hiding this comment.
we should move this to top of files.
aarnphm
changed the title
Signed-off-by: Rick Zhou <rickzhoucmu@gmail.com>
Yeah, i realized the CI is already doing this. No need for black format |
For more information, see https://pre-commit.ci
aarnphm
approved these changes
Aug 2, 2024
bojiang
reviewed
Aug 2, 2024
| @@ -16,6 +28,7 @@ def _get_serve_cmd(bento: BentoInfo, port: int = 3000): | |||
|
|
|||
|
|
|||
| def serve(bento: BentoInfo, port: int = 3000): | |||
| prep_env_vars(bento) | |||
| venv = ensure_venv(bento) | |||
| cmd, env, cwd = _get_serve_cmd(bento, port=port) | |||
There was a problem hiding this comment.
It seems the prepared env isn't applied to bentoml serve? @rickzx
There was a problem hiding this comment.
It is applied to bentoml serve. The run_command function explicitly copies the env vars from the current process to the new process (even if it doesn't, the default subprocess will also inherit env from the current process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txtcan have options likeblack