Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] order: recognize ".." as a "parent" path #1658

Merged
merged 1 commit into from
Feb 17, 2020
Merged

[fix] order: recognize ".." as a "parent" path #1658

merged 1 commit into from
Feb 17, 2020

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Feb 17, 2020

fixes #1405

@coveralls
Copy link

coveralls commented Feb 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.839% when pulling 12971f5 on golopot:order-dot-dot into 47f912e on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.838% when pulling 6aa3c2c on golopot:order-dot-dot into 2beec94 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.838% when pulling 6aa3c2c on golopot:order-dot-dot into 2beec94 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.838% when pulling 6aa3c2c on golopot:order-dot-dot into 2beec94 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.838% when pulling 6aa3c2c on golopot:order-dot-dot into 2beec94 on benmosher:master.

ljharb
ljharb reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1405 (comment), should this go through the resolver to consider "parent"-ness?

tests/src/rules/order.js Outdated Show resolved Hide resolved
@golopot
Copy link
Contributor Author

golopot commented Feb 17, 2020

Per #1405 (comment), should this go through the resolver to consider "parent"-ness?

I believe it is better to order the import statements by the apparent path rather the resolved path. What I wanted for this rule is a consistent ordering that looks nice. Ordering by resolved path does not provide a consistent ordering that looks nice.

@ljharb
Copy link
Member

ljharb commented Feb 17, 2020

True, that makes sense.

@ljharb ljharb merged commit 12971f5 into import-js:master Feb 17, 2020
@golopot golopot mentioned this pull request May 13, 2020
Closed
@golopot golopot mentioned this pull request Jun 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
import/export ordering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

order: '..' is not recognized
3 participants
@golopot @coveralls @ljharb