-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: import-js/eslint-plugin-import
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: import-js/eslint-plugin-import
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 7 files changed
- 2 contributors
Commits on Mar 15, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0942a7b - Browse repository at this point
Copy the full SHA 0942a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3cb7ab - Browse repository at this point
Copy the full SHA f3cb7abView commit details
Commits on Mar 17, 2016
-
Cache fileExists in core/resolve
In a project where I have import/no-unresolved enabled, I get the following results with ESLint's TIMING=1 environment variable enabled: ``` Rule | Time (ms) | Relative :-----------------------------|----------:|--------: import/no-unresolved | 18563.065 | 40.6% react/sort-comp | 1621.646 | 3.5% no-irregular-whitespace | 1386.958 | 3.0% react/prop-types | 1197.552 | 2.6% no-implied-eval | 829.967 | 1.8% react/jsx-uses-vars | 765.702 | 1.7% keyword-spacing | 765.665 | 1.7% no-eval | 578.730 | 1.3% semi-spacing | 549.684 | 1.2% no-whitespace-before-property | 477.285 | 1.0% ``` To speed up this outlier, I decided to cache the results of file existence checks in a Map. Adding this cache brings this time down from ~18s to ~13s: ``` Rule | Time (ms) | Relative :-----------------------|----------:|--------: import/no-unresolved | 13199.978 | 32.5% react/sort-comp | 1793.781 | 4.4% react/prop-types | 1400.975 | 3.4% no-irregular-whitespace | 1315.485 | 3.2% react/jsx-uses-vars | 794.097 | 2.0% no-implied-eval | 765.593 | 1.9% keyword-spacing | 752.945 | 1.9% no-eval | 592.048 | 1.5% semi-spacing | 532.061 | 1.3% no-control-regex | 479.856 | 1.2% ``` Addresses #187
Configuration menu - View commit details
-
Copy full SHA for 5df6c55 - Browse repository at this point
Copy the full SHA 5df6c55View commit details
Commits on Mar 18, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 137955b - Browse repository at this point
Copy the full SHA 137955bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06e6244 - Browse repository at this point
Copy the full SHA 06e6244View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1d4a4 - Browse repository at this point
Copy the full SHA dc1d4a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753e25f - Browse repository at this point
Copy the full SHA 753e25fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c63475 - Browse repository at this point
Copy the full SHA 7c63475View commit details -
realized that resolving a file implies it exists, regardless of casing.
only need to cache case-sensitivity.
Configuration menu - View commit details
-
Copy full SHA for a44774a - Browse repository at this point
Copy the full SHA a44774aView commit details
Commits on Mar 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for c35b477 - Browse repository at this point
Copy the full SHA c35b477View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9376fa4 - Browse repository at this point
Copy the full SHA 9376fa4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.0...v1.2.0