Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unquote_to_bytes to moved urllib.parse. Fixes #171. #172

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Add unquote_to_bytes to moved urllib.parse. Fixes #171. #172

merged 2 commits into from
Mar 2, 2017

Conversation

jaraco
Copy link
Contributor

@jaraco jaraco commented Jan 14, 2017

No description provided.

@benjaminp
Copy link
Owner

Thanks for the PR. Could you

  1. update the table in documentation/index.rst,
  2. add a (probably sundry) test to test_six.py?

@jaraco
Copy link
Contributor Author

jaraco commented Mar 1, 2017

Yes

@jaraco
Copy link
Contributor Author

jaraco commented Mar 1, 2017

I've added docs... and there's already a test that covers the attribute.

@jaraco
Copy link
Contributor Author

jaraco commented Mar 1, 2017

If it weren't for #182, you could demonstrate that the test was being run by invoking tox -- -k unquote_to_bytes.

@jaraco
Copy link
Contributor Author

jaraco commented Mar 1, 2017

Merging the changes from the issue-182 branch, it can be show that the tests are run:

$ git checkout unquote_to_bytes 
Switched to branch 'unquote_to_bytes'
Your branch is up-to-date with 'origin/unquote_to_bytes'.
$ git merge issue-182
Merge made by the 'recursive' strategy.
 tox.ini | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
$ tox -e py -- -k unquote_to_bytes -v
py recreate: /Users/jaraco/Dropbox/code/public/six/.tox/py
py installdeps: pytest, git+https://github.com/jaraco/pip@hotfix/issue4264-2
py develop-inst: /Users/jaraco/Dropbox/code/public/six
py installed: appdirs==1.4.2,packaging==16.8,py==1.4.32,pyparsing==2.1.10,pytest==3.0.6,-e git+gh://jaraco/six@0bb369282df2fb1364f44fabc501d8817ea79cec#egg=six
py runtests: PYTHONHASHSEED='4129616605'
py runtests: commands[0] | py.test -rfsxX -k unquote_to_bytes -v
====================================== test session starts =======================================
platform darwin -- Python 3.6.0, pytest-3.0.6, py-1.4.32, pluggy-0.4.0 -- /Users/jaraco/Dropbox/code/public/six/.tox/py/bin/python3
cachedir: .cache
rootdir: /Users/jaraco/Dropbox/code/public/six, inifile: setup.cfg
collected 189 items 

test_six.py::test_move_items_urllib_parse[unquote_to_bytes] PASSED

===================================== pytest-warning summary =====================================
WC1 None [pytest] section in setup.cfg files is deprecated, use [tool:pytest] instead.
====================================== 188 tests deselected ======================================
================== 1 passed, 188 deselected, 1 pytest-warnings in 0.08 seconds ===================
____________________________________________ summary _____________________________________________
  py: commands succeeded
  congratulations :)

@benjaminp benjaminp merged commit 2c3492a into benjaminp:master Mar 2, 2017
benjaminp added a commit that referenced this pull request Mar 2, 2017
@benjaminp
document #172
89ab315
@jaraco jaraco deleted the unquote_to_bytes branch July 3, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaraco @benjaminp