Fix a ctime fastcheck miss #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug when using ctime for fastcheck, not unlike the bug with mtime fixed by commit e2ac124. The cause of the issue is similar to the one described in the abovementioned commit. There is a problem when rescanning the extended properties (like xattrs) of previously synced files (for example, when changing the "xattrs" preference from false to true, which causes a one-time rescan of all properties). If new extended properties are detected but the file is eventually not synced (due to an error, or the user actively skipping the file), these extended properties are no longer detected on the next update check because the ctime in the archive matches the ctime on disk and a complete rescan is this time not requested (as it was a one-time rescan). This patch fixes the bug by always resetting the ctime in the archive when a one-time rescan is requested and new extended properties are detected. Resetting the ctime in the archive guarantees that the extended properties for the file are rescanned every time until they are either successfully synced or the user preferences change (for example, the "xattrs" preference is set to false again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go again. After having fixed mtime fastcheck in #769 I went ahead and introduced the exact same bug with ctime. Sigh.
Some more details in the commit message but this is pretty much the same story as with #769 (except that it is exposed with preferences for extended props, like "xattrs" and "acl").