Add a more sensible install target in Makefile #939
Conversation
Makefile
Outdated
| @@ -37,16 +37,42 @@ clean: | |||
| $(MAKE) -C man clean | |||
| $(MAKE) -C src clean | |||
|
|
|||
| INSTALL=install | |||
| INSTALL_PROGRAM=$(INSTALL) | |||
There was a problem hiding this comment.
maybe a 755? maybe that's defined by default, and can be skipped, but if that's what we mean, it's a nice declaration of intent that makes this easier to understand.
There was a problem hiding this comment.
I would go after examples from some common projects. Any suggestions as to what those might be?
Makefile
Outdated
| install: all | ||
| $(INSTALL) -d "$(DESTDIR)$(bindir)" | ||
| ifneq ($(wildcard src/unison),) | ||
| $(INSTALL_PROGRAM) src/unison "$(DESTDIR)$(bindir)/unison" |
There was a problem hiding this comment.
bindir is not mkdir -d'd. I know that sounds funny, but I think it's normal to install a program into its own prefix for testing.
There was a problem hiding this comment.
$(INSTALL) -d on line 54 is supposed to do that here. (Also tested precisely as you describe.)
tleedjarv
force-pushed
the
makefile-install
branch
from
9864476 to
dc237c8
Compare
|
Rebased and updated. Now all variables should be env-able. In fact, variables from env will override GNU-style lowercase variables. |
|
Is there anything blocking this PR? Should we merge? It seems like no reviewer raised any issue, and, as far as I can tell, the target is doing what is needed ;) Also, this PR is a dependency for #845, which I'm trying to push. |
|
I tested on NetBSD and was able to control PREFIX and MANDIR from the environment, so I'm now ok with this. |
Provide a basic install target. Not intended to work on Windows but should work on most POSIX-y systems that have a BSD- or GNU-compatible
install.@gdt could you review if this works for packagers?